All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gisi: log normal responses in a less confusing way
@ 2011-04-27 12:45 Pekka.Pessi
  2011-04-28 19:59 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: Pekka.Pessi @ 2011-04-27 12:45 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

From: Pekka Pessi <Pekka.Pessi@nokia.com>

---
 gisi/modem.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/gisi/modem.c b/gisi/modem.c
index 384983d..070cb9c 100644
--- a/gisi/modem.c
+++ b/gisi/modem.c
@@ -163,7 +163,8 @@ static void pending_remove_and_dispatch(GIsiPending *op, GIsiMessage *msg)
 	modem = op->service->modem;
 
 	ISIDBG(modem, "%s %s to %p [res=0x%02X, id=0x%02X, utid=0x%02X]",
-		g_isi_msg_strerror(msg), pend_type_to_str(op->type), op,
+		g_isi_msg_error(msg) ? g_isi_msg_strerror(msg) : "normal",
+		pend_type_to_str(op->type), op,
 		g_isi_msg_resource(msg), g_isi_msg_id(msg),
 		g_isi_msg_utid(msg));
 
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gisi: log normal responses in a less confusing way
  2011-04-27 12:45 [PATCH] gisi: log normal responses in a less confusing way Pekka.Pessi
@ 2011-04-28 19:59 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2011-04-28 19:59 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

Hi Pekka,

On 04/27/2011 07:45 AM, Pekka.Pessi(a)nokia.com wrote:
> From: Pekka Pessi <Pekka.Pessi@nokia.com>
> 
> ---
>  gisi/modem.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-04-28 19:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-27 12:45 [PATCH] gisi: log normal responses in a less confusing way Pekka.Pessi
2011-04-28 19:59 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.