From: Jan Kiszka <jan.kiszka@web.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Ulrich Obergfell <uobergfe@redhat.com>,
qemu-devel@nongnu.org, aliguori@us.ibm.com, kvm@vger.kernel.org,
gcosta@redhat.com, avi@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only)
Date: Fri, 29 Apr 2011 00:50:30 +0200 [thread overview]
Message-ID: <4DB9EF36.1010803@web.de> (raw)
In-Reply-To: <BANLkTindvvtKewuakXkLZBQHkp_BM1eiLw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On 2011-04-28 20:51, Blue Swirl wrote:
> On Thu, Apr 28, 2011 at 5:24 PM, Ulrich Obergfell <uobergfe@redhat.com> wrote:
>> 'target_get_irq_delivered' and 'target_reset_irq_delivered' contain
>> entry addresses of functions that are utilized by update_irq() to
>> detect coalesced interrupts. apic code loads these pointers during
>> initialization.
>
> I'm not so happy with this approach, but probably then the i386
> dependencies can be removed from RTC and it can be compiled only once
> for all targets.
This whole series is really the minimalistic approach. The callbacks
defined here must remain a temporary "shortcut". Just like proper
abstraction of periodic tick compensation for reuse in other timers has
to be added later on. And the limitation to edge-triggered legacy HPET
INTs has to be removed.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, qemu-devel@nongnu.org,
Ulrich Obergfell <uobergfe@redhat.com>,
gcosta@redhat.com, avi@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only)
Date: Fri, 29 Apr 2011 00:50:30 +0200 [thread overview]
Message-ID: <4DB9EF36.1010803@web.de> (raw)
In-Reply-To: <BANLkTindvvtKewuakXkLZBQHkp_BM1eiLw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On 2011-04-28 20:51, Blue Swirl wrote:
> On Thu, Apr 28, 2011 at 5:24 PM, Ulrich Obergfell <uobergfe@redhat.com> wrote:
>> 'target_get_irq_delivered' and 'target_reset_irq_delivered' contain
>> entry addresses of functions that are utilized by update_irq() to
>> detect coalesced interrupts. apic code loads these pointers during
>> initialization.
>
> I'm not so happy with this approach, but probably then the i386
> dependencies can be removed from RTC and it can be compiled only once
> for all targets.
This whole series is really the minimalistic approach. The callbacks
defined here must remain a temporary "shortcut". Just like proper
abstraction of periodic tick compensation for reuse in other timers has
to be added later on. And the limitation to edge-triggered legacy HPET
INTs has to be removed.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2011-04-28 22:50 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 14:24 [PATCH v3 0/5] hpet 'driftfix': alleviate time drift with HPET periodic timers Ulrich Obergfell
2011-04-28 14:24 ` [Qemu-devel] " Ulrich Obergfell
2011-04-28 14:24 ` [PATCH v3 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only) Ulrich Obergfell
2011-04-28 14:24 ` [Qemu-devel] " Ulrich Obergfell
2011-04-28 18:51 ` Blue Swirl
2011-04-28 18:51 ` Blue Swirl
2011-04-28 22:50 ` Jan Kiszka [this message]
2011-04-28 22:50 ` Jan Kiszka
2011-04-29 9:45 ` Ulrich Obergfell
2011-04-29 9:45 ` Ulrich Obergfell
2011-04-29 10:15 ` Jan Kiszka
2011-04-29 10:15 ` [Qemu-devel] " Jan Kiszka
2011-04-29 21:44 ` Blue Swirl
2011-04-29 21:44 ` Blue Swirl
2011-04-28 14:24 ` [PATCH v3 2/5] hpet 'driftfix': add driftfix property to HPETState and DeviceInfo Ulrich Obergfell
2011-04-28 14:24 ` [Qemu-devel] " Ulrich Obergfell
2011-04-28 14:24 ` [PATCH v3 3/5] hpet 'driftfix': add fields to HPETTimer and VMStateDescription Ulrich Obergfell
2011-04-28 14:24 ` [Qemu-devel] " Ulrich Obergfell
2011-04-28 14:24 ` [PATCH v3 4/5] hpet 'driftfix': add code in update_irq() to detect coalesced interrupts (x86 apic only) Ulrich Obergfell
2011-04-28 14:24 ` [Qemu-devel] " Ulrich Obergfell
2011-04-28 14:25 ` [PATCH v3 5/5] hpet 'driftfix': add code in hpet_timer() to compensate delayed callbacks and coalesced interrupts Ulrich Obergfell
2011-04-28 14:25 ` [Qemu-devel] " Ulrich Obergfell
2011-05-03 19:03 ` Marcelo Tosatti
2011-05-03 19:03 ` [Qemu-devel] " Marcelo Tosatti
2011-05-03 22:08 ` Glauber Costa
2011-05-03 22:08 ` [Qemu-devel] " Glauber Costa
2011-05-03 22:55 ` Marcelo Tosatti
2011-05-03 22:55 ` [Qemu-devel] " Marcelo Tosatti
2011-05-04 8:06 ` Ulrich Obergfell
2011-05-04 8:06 ` [Qemu-devel] " Ulrich Obergfell
2011-05-04 9:09 ` Marcelo Tosatti
2011-05-04 9:09 ` [Qemu-devel] " Marcelo Tosatti
2011-05-04 13:36 ` Glauber Costa
2011-05-04 13:36 ` [Qemu-devel] " Glauber Costa
2011-05-04 13:46 ` Gleb Natapov
2011-05-04 13:46 ` [Qemu-devel] " Gleb Natapov
2011-05-04 13:47 ` Glauber Costa
2011-05-04 13:47 ` [Qemu-devel] " Glauber Costa
2011-05-04 13:55 ` Gleb Natapov
2011-05-04 13:55 ` [Qemu-devel] " Gleb Natapov
2011-05-05 8:07 ` Ulrich Obergfell
2011-05-05 8:07 ` [Qemu-devel] " Ulrich Obergfell
2011-05-06 14:39 ` Marcelo Tosatti
2011-05-06 14:39 ` [Qemu-devel] " Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB9EF36.1010803@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=gcosta@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.