[PATCH 1/2] AM35xx-Craneboard: USB EHCI: Fix USB ECHI PHY reset

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 1/2] AM35xx-Craneboard: USB EHCI: Fix USB ECHI PHY reset
       [not found] <[PATCH]>
@ 2011-04-29 11:41   ` srinath at mistralsolutions.com
  2011-04-29 11:41   ` srinath at mistralsolutions.com
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 13+ messages in thread
From: srinath @ 2011-04-29 11:41 UTC (permalink / raw)
  To: linux-omap
  Cc: jdk, tony, linux-kernel, linux, linux-arm-kernel, khilman, nm,
	nagendra, umeshk, Srinath

From: Srinath <srinath@mistralsolutions.com>

This patch fixes the EHCI PHY reset issue found on CraneBoard.

Signed-off-by: Srinath <srinath@mistralsolutions.com>
---
 arch/arm/mach-omap2/board-am3517crane.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
index a890d24..05867b5 100644
--- a/arch/arm/mach-omap2/board-am3517crane.c
+++ b/arch/arm/mach-omap2/board-am3517crane.c
@@ -60,7 +60,7 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = {
 	.port_mode[1] = OMAP_USBHS_PORT_MODE_UNUSED,
 	.port_mode[2] = OMAP_USBHS_PORT_MODE_UNUSED,
 
-	.phy_reset  = true,
+	.phy_reset  = false,
 	.reset_gpio_port[0]  = GPIO_USB_NRESET,
 	.reset_gpio_port[1]  = -EINVAL,
 	.reset_gpio_port[2]  = -EINVAL
-- 
1.7.1.226.g770c5


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 1/2] AM35xx-Craneboard: USB EHCI: Fix USB ECHI PHY reset
@ 2011-04-29 11:41   ` srinath at mistralsolutions.com
  0 siblings, 0 replies; 13+ messages in thread
From: srinath at mistralsolutions.com @ 2011-04-29 11:41 UTC (permalink / raw)
  To: linux-arm-kernel

From: Srinath <srinath@mistralsolutions.com>

This patch fixes the EHCI PHY reset issue found on CraneBoard.

Signed-off-by: Srinath <srinath@mistralsolutions.com>
---
 arch/arm/mach-omap2/board-am3517crane.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
index a890d24..05867b5 100644
--- a/arch/arm/mach-omap2/board-am3517crane.c
+++ b/arch/arm/mach-omap2/board-am3517crane.c
@@ -60,7 +60,7 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = {
 	.port_mode[1] = OMAP_USBHS_PORT_MODE_UNUSED,
 	.port_mode[2] = OMAP_USBHS_PORT_MODE_UNUSED,
 
-	.phy_reset  = true,
+	.phy_reset  = false,
 	.reset_gpio_port[0]  = GPIO_USB_NRESET,
 	.reset_gpio_port[1]  = -EINVAL,
 	.reset_gpio_port[2]  = -EINVAL
-- 
1.7.1.226.g770c5

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH 1/2] AM35xx-Craneboard: USB EHCI: Fix USB ECHI PHY reset
  2011-04-29 11:41   ` srinath at mistralsolutions.com
@ 2011-04-29 12:39     ` Sergei Shtylyov
  -1 siblings, 0 replies; 13+ messages in thread
From: Sergei Shtylyov @ 2011-04-29 12:39 UTC (permalink / raw)
  To: srinath
  Cc: linux-omap, nm, linux, umeshk, tony, nagendra, linux-kernel,
	khilman, jdk, linux-arm-kernel

Hello.

On 29-04-2011 15:41, srinath@mistralsolutions.com wrote:

> From: Srinath <srinath@mistralsolutions.com>

> This patch fixes the EHCI PHY reset issue found on CraneBoard.

> Signed-off-by: Srinath <srinath@mistralsolutions.com>

    AFAIK full name required in signoff.

WBR, Sergei

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH 1/2] AM35xx-Craneboard: USB EHCI: Fix USB ECHI PHY reset
@ 2011-04-29 12:39     ` Sergei Shtylyov
  0 siblings, 0 replies; 13+ messages in thread
From: Sergei Shtylyov @ 2011-04-29 12:39 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 29-04-2011 15:41, srinath at mistralsolutions.com wrote:

> From: Srinath <srinath@mistralsolutions.com>

> This patch fixes the EHCI PHY reset issue found on CraneBoard.

> Signed-off-by: Srinath <srinath@mistralsolutions.com>

    AFAIK full name required in signoff.

WBR, Sergei

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH 2/2] AM35xx-Craneboard:Display: Add DVI and TV Support
       [not found] <[PATCH]>
  2011-04-29 11:41   ` srinath at mistralsolutions.com
@ 2011-04-29 11:41   ` srinath at mistralsolutions.com
  2011-05-02 13:40   ` srinath at mistralsolutions.com
  2011-05-02 13:40   ` srinath at mistralsolutions.com
  3 siblings, 0 replies; 13+ messages in thread
From: srinath @ 2011-04-29 11:41 UTC (permalink / raw)
  To: linux-omap
  Cc: nm, linux, umeshk, tony, nagendra, Srinath, linux-kernel, khilman,
	jdk, linux-arm-kernel

From: Srinath <srinath@mistralsolutions.com>

Added Display (DVI and TV) support for CraneBoard.

Signed-off-by: Srinath <srinath@mistralsolutions.com>
---
 arch/arm/mach-omap2/board-am3517crane.c |   78 +++++++++++++++++++++++++++++++
 1 files changed, 78 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
index 05867b5..83fe85b 100644
--- a/arch/arm/mach-omap2/board-am3517crane.c
+++ b/arch/arm/mach-omap2/board-am3517crane.c
@@ -29,12 +29,15 @@
 #include <plat/board.h>
 #include <plat/common.h>
 #include <plat/usb.h>
+#include <plat/display.h>
+#include <plat/panel-generic-dpi.h>
 
 #include "mux.h"
 #include "control.h"
 
 #define GPIO_USB_POWER		35
 #define GPIO_USB_NRESET		38
+#define GPIO_DVI_ENABLE		52
 
 
 /* Board initialization */
@@ -66,11 +69,83 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = {
 	.reset_gpio_port[2]  = -EINVAL
 };
 
+static void __init am3517_crane_display_init(void)
+{
+	int ret;
+
+	ret = omap_mux_init_gpio(GPIO_DVI_ENABLE, OMAP_PIN_OUTPUT);
+	if (ret < 0) {
+		pr_err("Can not configure mux for GPIO_DVI_ENABLE %d\n",
+			GPIO_DVI_ENABLE);
+		return;
+	}
+
+	ret = gpio_request(GPIO_DVI_ENABLE, "dvi_enable");
+	if (ret < 0) {
+		pr_err("Can not request GPIO %d\n", GPIO_DVI_ENABLE);
+		return;
+	}
+
+	ret = gpio_direction_output(GPIO_DVI_ENABLE, 1);
+	if (ret < 0) {
+		gpio_free(GPIO_DVI_ENABLE);
+		pr_err("Unable to enable DVI\n");
+		return;
+	}
+}
+
+static struct omap_dss_device am3517_crane_tv_device = {
+	.type                   = OMAP_DISPLAY_TYPE_VENC,
+	.name                   = "tv",
+	.driver_name            = "venc",
+	.phy.venc.type          = OMAP_DSS_VENC_TYPE_COMPOSITE,
+	.platform_enable        = NULL,
+	.platform_disable       = NULL,
+};
+
+static int am3517_crane_panel_enable_dvi(struct omap_dss_device *dssdev)
+{
+	gpio_set_value(GPIO_DVI_ENABLE, 1);
+	return 0;
+}
+
+static void am3517_crane_panel_disable_dvi(struct omap_dss_device *dssdev)
+{
+	gpio_set_value(GPIO_DVI_ENABLE, 0);
+}
+
+
+static struct panel_generic_dpi_data dvi_panel = {
+	.name                   = "generic",
+	.platform_enable        = am3517_crane_panel_enable_dvi,
+	.platform_disable       = am3517_crane_panel_disable_dvi,
+};
+
+static struct omap_dss_device am3517_crane_dvi_device = {
+	.type                   = OMAP_DISPLAY_TYPE_DPI,
+	.name                   = "dvi",
+	.driver_name            = "generic_dpi_panel",
+	.data                   = &dvi_panel,
+	.phy.dpi.data_lines     = 24,
+};
+
+static struct omap_dss_device *am3517_crane_dss_devices[] = {
+	&am3517_crane_tv_device,
+	&am3517_crane_dvi_device,
+};
+
+static struct omap_dss_board_info am3517_crane_dss_data = {
+	.num_devices    = ARRAY_SIZE(am3517_crane_dss_devices),
+	.devices        = am3517_crane_dss_devices,
+	.default_device = &am3517_crane_dvi_device,
+};
+
 static void __init am3517_crane_init(void)
 {
 	int ret;
 
 	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
+	omap_display_init(&am3517_crane_dss_data);
 	omap_serial_init();
 
 	omap_board_config = am3517_crane_config;
@@ -103,6 +178,9 @@ static void __init am3517_crane_init(void)
 	}
 
 	usbhs_init(&usbhs_bdata);
+
+	/* DSS */
+	am3517_crane_display_init();
 }
 
 MACHINE_START(CRANEBOARD, "AM3517/05 CRANEBOARD")
-- 
1.7.1.226.g770c5

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 2/2] AM35xx-Craneboard:Display: Add DVI and TV Support
@ 2011-04-29 11:41   ` srinath at mistralsolutions.com
  0 siblings, 0 replies; 13+ messages in thread
From: srinath @ 2011-04-29 11:41 UTC (permalink / raw)
  To: linux-omap
  Cc: jdk, tony, linux-kernel, linux, linux-arm-kernel, khilman, nm,
	nagendra, umeshk, Srinath

From: Srinath <srinath@mistralsolutions.com>

Added Display (DVI and TV) support for CraneBoard.

Signed-off-by: Srinath <srinath@mistralsolutions.com>
---
 arch/arm/mach-omap2/board-am3517crane.c |   78 +++++++++++++++++++++++++++++++
 1 files changed, 78 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
index 05867b5..83fe85b 100644
--- a/arch/arm/mach-omap2/board-am3517crane.c
+++ b/arch/arm/mach-omap2/board-am3517crane.c
@@ -29,12 +29,15 @@
 #include <plat/board.h>
 #include <plat/common.h>
 #include <plat/usb.h>
+#include <plat/display.h>
+#include <plat/panel-generic-dpi.h>
 
 #include "mux.h"
 #include "control.h"
 
 #define GPIO_USB_POWER		35
 #define GPIO_USB_NRESET		38
+#define GPIO_DVI_ENABLE		52
 
 
 /* Board initialization */
@@ -66,11 +69,83 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = {
 	.reset_gpio_port[2]  = -EINVAL
 };
 
+static void __init am3517_crane_display_init(void)
+{
+	int ret;
+
+	ret = omap_mux_init_gpio(GPIO_DVI_ENABLE, OMAP_PIN_OUTPUT);
+	if (ret < 0) {
+		pr_err("Can not configure mux for GPIO_DVI_ENABLE %d\n",
+			GPIO_DVI_ENABLE);
+		return;
+	}
+
+	ret = gpio_request(GPIO_DVI_ENABLE, "dvi_enable");
+	if (ret < 0) {
+		pr_err("Can not request GPIO %d\n", GPIO_DVI_ENABLE);
+		return;
+	}
+
+	ret = gpio_direction_output(GPIO_DVI_ENABLE, 1);
+	if (ret < 0) {
+		gpio_free(GPIO_DVI_ENABLE);
+		pr_err("Unable to enable DVI\n");
+		return;
+	}
+}
+
+static struct omap_dss_device am3517_crane_tv_device = {
+	.type                   = OMAP_DISPLAY_TYPE_VENC,
+	.name                   = "tv",
+	.driver_name            = "venc",
+	.phy.venc.type          = OMAP_DSS_VENC_TYPE_COMPOSITE,
+	.platform_enable        = NULL,
+	.platform_disable       = NULL,
+};
+
+static int am3517_crane_panel_enable_dvi(struct omap_dss_device *dssdev)
+{
+	gpio_set_value(GPIO_DVI_ENABLE, 1);
+	return 0;
+}
+
+static void am3517_crane_panel_disable_dvi(struct omap_dss_device *dssdev)
+{
+	gpio_set_value(GPIO_DVI_ENABLE, 0);
+}
+
+
+static struct panel_generic_dpi_data dvi_panel = {
+	.name                   = "generic",
+	.platform_enable        = am3517_crane_panel_enable_dvi,
+	.platform_disable       = am3517_crane_panel_disable_dvi,
+};
+
+static struct omap_dss_device am3517_crane_dvi_device = {
+	.type                   = OMAP_DISPLAY_TYPE_DPI,
+	.name                   = "dvi",
+	.driver_name            = "generic_dpi_panel",
+	.data                   = &dvi_panel,
+	.phy.dpi.data_lines     = 24,
+};
+
+static struct omap_dss_device *am3517_crane_dss_devices[] = {
+	&am3517_crane_tv_device,
+	&am3517_crane_dvi_device,
+};
+
+static struct omap_dss_board_info am3517_crane_dss_data = {
+	.num_devices    = ARRAY_SIZE(am3517_crane_dss_devices),
+	.devices        = am3517_crane_dss_devices,
+	.default_device = &am3517_crane_dvi_device,
+};
+
 static void __init am3517_crane_init(void)
 {
 	int ret;
 
 	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
+	omap_display_init(&am3517_crane_dss_data);
 	omap_serial_init();
 
 	omap_board_config = am3517_crane_config;
@@ -103,6 +178,9 @@ static void __init am3517_crane_init(void)
 	}
 
 	usbhs_init(&usbhs_bdata);
+
+	/* DSS */
+	am3517_crane_display_init();
 }
 
 MACHINE_START(CRANEBOARD, "AM3517/05 CRANEBOARD")
-- 
1.7.1.226.g770c5


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 2/2] AM35xx-Craneboard:Display: Add DVI and TV Support
@ 2011-04-29 11:41   ` srinath at mistralsolutions.com
  0 siblings, 0 replies; 13+ messages in thread
From: srinath at mistralsolutions.com @ 2011-04-29 11:41 UTC (permalink / raw)
  To: linux-arm-kernel

From: Srinath <srinath@mistralsolutions.com>

Added Display (DVI and TV) support for CraneBoard.

Signed-off-by: Srinath <srinath@mistralsolutions.com>
---
 arch/arm/mach-omap2/board-am3517crane.c |   78 +++++++++++++++++++++++++++++++
 1 files changed, 78 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
index 05867b5..83fe85b 100644
--- a/arch/arm/mach-omap2/board-am3517crane.c
+++ b/arch/arm/mach-omap2/board-am3517crane.c
@@ -29,12 +29,15 @@
 #include <plat/board.h>
 #include <plat/common.h>
 #include <plat/usb.h>
+#include <plat/display.h>
+#include <plat/panel-generic-dpi.h>
 
 #include "mux.h"
 #include "control.h"
 
 #define GPIO_USB_POWER		35
 #define GPIO_USB_NRESET		38
+#define GPIO_DVI_ENABLE		52
 
 
 /* Board initialization */
@@ -66,11 +69,83 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = {
 	.reset_gpio_port[2]  = -EINVAL
 };
 
+static void __init am3517_crane_display_init(void)
+{
+	int ret;
+
+	ret = omap_mux_init_gpio(GPIO_DVI_ENABLE, OMAP_PIN_OUTPUT);
+	if (ret < 0) {
+		pr_err("Can not configure mux for GPIO_DVI_ENABLE %d\n",
+			GPIO_DVI_ENABLE);
+		return;
+	}
+
+	ret = gpio_request(GPIO_DVI_ENABLE, "dvi_enable");
+	if (ret < 0) {
+		pr_err("Can not request GPIO %d\n", GPIO_DVI_ENABLE);
+		return;
+	}
+
+	ret = gpio_direction_output(GPIO_DVI_ENABLE, 1);
+	if (ret < 0) {
+		gpio_free(GPIO_DVI_ENABLE);
+		pr_err("Unable to enable DVI\n");
+		return;
+	}
+}
+
+static struct omap_dss_device am3517_crane_tv_device = {
+	.type                   = OMAP_DISPLAY_TYPE_VENC,
+	.name                   = "tv",
+	.driver_name            = "venc",
+	.phy.venc.type          = OMAP_DSS_VENC_TYPE_COMPOSITE,
+	.platform_enable        = NULL,
+	.platform_disable       = NULL,
+};
+
+static int am3517_crane_panel_enable_dvi(struct omap_dss_device *dssdev)
+{
+	gpio_set_value(GPIO_DVI_ENABLE, 1);
+	return 0;
+}
+
+static void am3517_crane_panel_disable_dvi(struct omap_dss_device *dssdev)
+{
+	gpio_set_value(GPIO_DVI_ENABLE, 0);
+}
+
+
+static struct panel_generic_dpi_data dvi_panel = {
+	.name                   = "generic",
+	.platform_enable        = am3517_crane_panel_enable_dvi,
+	.platform_disable       = am3517_crane_panel_disable_dvi,
+};
+
+static struct omap_dss_device am3517_crane_dvi_device = {
+	.type                   = OMAP_DISPLAY_TYPE_DPI,
+	.name                   = "dvi",
+	.driver_name            = "generic_dpi_panel",
+	.data                   = &dvi_panel,
+	.phy.dpi.data_lines     = 24,
+};
+
+static struct omap_dss_device *am3517_crane_dss_devices[] = {
+	&am3517_crane_tv_device,
+	&am3517_crane_dvi_device,
+};
+
+static struct omap_dss_board_info am3517_crane_dss_data = {
+	.num_devices    = ARRAY_SIZE(am3517_crane_dss_devices),
+	.devices        = am3517_crane_dss_devices,
+	.default_device = &am3517_crane_dvi_device,
+};
+
 static void __init am3517_crane_init(void)
 {
 	int ret;
 
 	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
+	omap_display_init(&am3517_crane_dss_data);
 	omap_serial_init();
 
 	omap_board_config = am3517_crane_config;
@@ -103,6 +178,9 @@ static void __init am3517_crane_init(void)
 	}
 
 	usbhs_init(&usbhs_bdata);
+
+	/* DSS */
+	am3517_crane_display_init();
 }
 
 MACHINE_START(CRANEBOARD, "AM3517/05 CRANEBOARD")
-- 
1.7.1.226.g770c5

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/2] AM35xx-Craneboard:Display: Add DVI and TV Support
  2011-04-29 11:41   ` srinath at mistralsolutions.com
@ 2011-04-29 12:44     ` Sergei Shtylyov
  -1 siblings, 0 replies; 13+ messages in thread
From: Sergei Shtylyov @ 2011-04-29 12:44 UTC (permalink / raw)
  To: srinath
  Cc: linux-omap, nm, linux, umeshk, tony, nagendra, linux-kernel,
	khilman, jdk, linux-arm-kernel

Hello.

On 29-04-2011 15:41, srinath@mistralsolutions.com wrote:

> From: Srinath <srinath@mistralsolutions.com>

> Added Display (DVI and TV) support for CraneBoard.

> Signed-off-by: Srinath <srinath@mistralsolutions.com>
[...]

> diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
> index 05867b5..83fe85b 100644
> --- a/arch/arm/mach-omap2/board-am3517crane.c
> +++ b/arch/arm/mach-omap2/board-am3517crane.c
[...]
> @@ -66,11 +69,83 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = {
>   	.reset_gpio_port[2]  = -EINVAL
>   };
>
> +static void __init am3517_crane_display_init(void)
> +{
> +	int ret;
> +
> +	ret = omap_mux_init_gpio(GPIO_DVI_ENABLE, OMAP_PIN_OUTPUT);
> +	if (ret<  0) {
> +		pr_err("Can not configure mux for GPIO_DVI_ENABLE %d\n",
> +			GPIO_DVI_ENABLE);
> +		return;
> +	}
> +
> +	ret = gpio_request(GPIO_DVI_ENABLE, "dvi_enable");
> +	if (ret<  0) {
> +		pr_err("Can not request GPIO %d\n", GPIO_DVI_ENABLE);
> +		return;
> +	}
> +
> +	ret = gpio_direction_output(GPIO_DVI_ENABLE, 1);
> +	if (ret<  0) {
> +		gpio_free(GPIO_DVI_ENABLE);
> +		pr_err("Unable to enable DVI\n");
> +		return;
> +	}

    You can use gpio_request_one() ISO gpio_request()/gpio_direction_output().

WBR, Sergei

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH 2/2] AM35xx-Craneboard:Display: Add DVI and TV Support
@ 2011-04-29 12:44     ` Sergei Shtylyov
  0 siblings, 0 replies; 13+ messages in thread
From: Sergei Shtylyov @ 2011-04-29 12:44 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 29-04-2011 15:41, srinath at mistralsolutions.com wrote:

> From: Srinath <srinath@mistralsolutions.com>

> Added Display (DVI and TV) support for CraneBoard.

> Signed-off-by: Srinath <srinath@mistralsolutions.com>
[...]

> diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
> index 05867b5..83fe85b 100644
> --- a/arch/arm/mach-omap2/board-am3517crane.c
> +++ b/arch/arm/mach-omap2/board-am3517crane.c
[...]
> @@ -66,11 +69,83 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = {
>   	.reset_gpio_port[2]  = -EINVAL
>   };
>
> +static void __init am3517_crane_display_init(void)
> +{
> +	int ret;
> +
> +	ret = omap_mux_init_gpio(GPIO_DVI_ENABLE, OMAP_PIN_OUTPUT);
> +	if (ret<  0) {
> +		pr_err("Can not configure mux for GPIO_DVI_ENABLE %d\n",
> +			GPIO_DVI_ENABLE);
> +		return;
> +	}
> +
> +	ret = gpio_request(GPIO_DVI_ENABLE, "dvi_enable");
> +	if (ret<  0) {
> +		pr_err("Can not request GPIO %d\n", GPIO_DVI_ENABLE);
> +		return;
> +	}
> +
> +	ret = gpio_direction_output(GPIO_DVI_ENABLE, 1);
> +	if (ret<  0) {
> +		gpio_free(GPIO_DVI_ENABLE);
> +		pr_err("Unable to enable DVI\n");
> +		return;
> +	}

    You can use gpio_request_one() ISO gpio_request()/gpio_direction_output().

WBR, Sergei

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Patch v2] AM35xx-Craneboard: USB EHCI: Fix USB ECHI PHY reset
       [not found] <[PATCH]>
@ 2011-05-02 13:40   ` srinath at mistralsolutions.com
  2011-04-29 11:41   ` srinath at mistralsolutions.com
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 13+ messages in thread
From: srinath @ 2011-05-02 13:40 UTC (permalink / raw)
  To: linux-omap
  Cc: jdk, tony, linux-kernel, linux, linux-arm-kernel, khilman, nm,
	nagendra, umeshk, Srinath.R

From: Srinath.R <srinath@mistralsolutions.com>

This patch fixes the EHCI PHY reset issue found on CraneBoard.

History:
https://patchwork.kernel.org/patch/740741/

Signed-off-by: Srinath.R <srinath@mistralsolutions.com>
---
 arch/arm/mach-omap2/board-am3517crane.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
index a890d24..05867b5 100644
--- a/arch/arm/mach-omap2/board-am3517crane.c
+++ b/arch/arm/mach-omap2/board-am3517crane.c
@@ -60,7 +60,7 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = {
 	.port_mode[1] = OMAP_USBHS_PORT_MODE_UNUSED,
 	.port_mode[2] = OMAP_USBHS_PORT_MODE_UNUSED,
 
-	.phy_reset  = true,
+	.phy_reset  = false,
 	.reset_gpio_port[0]  = GPIO_USB_NRESET,
 	.reset_gpio_port[1]  = -EINVAL,
 	.reset_gpio_port[2]  = -EINVAL
-- 
1.5.3.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Patch v2] AM35xx-Craneboard: USB EHCI: Fix USB ECHI PHY reset
@ 2011-05-02 13:40   ` srinath at mistralsolutions.com
  0 siblings, 0 replies; 13+ messages in thread
From: srinath at mistralsolutions.com @ 2011-05-02 13:40 UTC (permalink / raw)
  To: linux-arm-kernel

From: Srinath.R <srinath@mistralsolutions.com>

This patch fixes the EHCI PHY reset issue found on CraneBoard.

History:
https://patchwork.kernel.org/patch/740741/

Signed-off-by: Srinath.R <srinath@mistralsolutions.com>
---
 arch/arm/mach-omap2/board-am3517crane.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
index a890d24..05867b5 100644
--- a/arch/arm/mach-omap2/board-am3517crane.c
+++ b/arch/arm/mach-omap2/board-am3517crane.c
@@ -60,7 +60,7 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = {
 	.port_mode[1] = OMAP_USBHS_PORT_MODE_UNUSED,
 	.port_mode[2] = OMAP_USBHS_PORT_MODE_UNUSED,
 
-	.phy_reset  = true,
+	.phy_reset  = false,
 	.reset_gpio_port[0]  = GPIO_USB_NRESET,
 	.reset_gpio_port[1]  = -EINVAL,
 	.reset_gpio_port[2]  = -EINVAL
-- 
1.5.3.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Patch v2] AM35xx-Craneboard:Display: Add DVI and TV Support
       [not found] <[PATCH]>
@ 2011-05-02 13:40   ` srinath at mistralsolutions.com
  2011-04-29 11:41   ` srinath at mistralsolutions.com
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 13+ messages in thread
From: srinath @ 2011-05-02 13:40 UTC (permalink / raw)
  To: linux-omap
  Cc: jdk, tony, linux-kernel, linux, linux-arm-kernel, khilman, nm,
	nagendra, umeshk, Srinath.R

From: Srinath.R <srinath@mistralsolutions.com>

Added Display (DVI and TV) support for CraneBoard.

History:
https://patchwork.kernel.org/patch/740761/

Signed-off-by: Srinath.R <srinath@mistralsolutions.com>
---
 arch/arm/mach-omap2/board-am3517crane.c |   73 +++++++++++++++++++++++++++++++
 1 files changed, 73 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
index 05867b5..26fa565 100644
--- a/arch/arm/mach-omap2/board-am3517crane.c
+++ b/arch/arm/mach-omap2/board-am3517crane.c
@@ -29,12 +29,15 @@
 #include <plat/board.h>
 #include <plat/common.h>
 #include <plat/usb.h>
+#include <plat/display.h>
+#include <plat/panel-generic-dpi.h>
 
 #include "mux.h"
 #include "control.h"
 
 #define GPIO_USB_POWER		35
 #define GPIO_USB_NRESET		38
+#define GPIO_DVI_ENABLE		52
 
 
 /* Board initialization */
@@ -66,11 +69,78 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = {
 	.reset_gpio_port[2]  = -EINVAL
 };
 
+static void __init am3517_crane_display_init(void)
+{
+	int ret;
+
+	ret = omap_mux_init_gpio(GPIO_DVI_ENABLE, OMAP_PIN_OUTPUT);
+	if (ret < 0) {
+		pr_err("Can not configure mux for GPIO_DVI_ENABLE %d\n",
+			GPIO_DVI_ENABLE);
+		return;
+	}
+
+	ret = gpio_request_one(GPIO_DVI_ENABLE, GPIOF_OUT_INIT_HIGH,
+				"dvi_enable");
+	if (ret < 0) {
+		pr_err("Can not request GPIO %d\n", GPIO_DVI_ENABLE);
+		return;
+	}
+
+}
+
+static struct omap_dss_device am3517_crane_tv_device = {
+	.type                   = OMAP_DISPLAY_TYPE_VENC,
+	.name                   = "tv",
+	.driver_name            = "venc",
+	.phy.venc.type          = OMAP_DSS_VENC_TYPE_COMPOSITE,
+	.platform_enable        = NULL,
+	.platform_disable       = NULL,
+};
+
+static int am3517_crane_panel_enable_dvi(struct omap_dss_device *dssdev)
+{
+	gpio_set_value(GPIO_DVI_ENABLE, 1);
+	return 0;
+}
+
+static void am3517_crane_panel_disable_dvi(struct omap_dss_device *dssdev)
+{
+	gpio_set_value(GPIO_DVI_ENABLE, 0);
+}
+
+
+static struct panel_generic_dpi_data dvi_panel = {
+	.name                   = "generic",
+	.platform_enable        = am3517_crane_panel_enable_dvi,
+	.platform_disable       = am3517_crane_panel_disable_dvi,
+};
+
+static struct omap_dss_device am3517_crane_dvi_device = {
+	.type                   = OMAP_DISPLAY_TYPE_DPI,
+	.name                   = "dvi",
+	.driver_name            = "generic_dpi_panel",
+	.data                   = &dvi_panel,
+	.phy.dpi.data_lines     = 24,
+};
+
+static struct omap_dss_device *am3517_crane_dss_devices[] = {
+	&am3517_crane_tv_device,
+	&am3517_crane_dvi_device,
+};
+
+static struct omap_dss_board_info am3517_crane_dss_data = {
+	.num_devices    = ARRAY_SIZE(am3517_crane_dss_devices),
+	.devices        = am3517_crane_dss_devices,
+	.default_device = &am3517_crane_dvi_device,
+};
+
 static void __init am3517_crane_init(void)
 {
 	int ret;
 
 	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
+	omap_display_init(&am3517_crane_dss_data);
 	omap_serial_init();
 
 	omap_board_config = am3517_crane_config;
@@ -103,6 +173,9 @@ static void __init am3517_crane_init(void)
 	}
 
 	usbhs_init(&usbhs_bdata);
+
+	/* DSS */
+	am3517_crane_display_init();
 }
 
 MACHINE_START(CRANEBOARD, "AM3517/05 CRANEBOARD")
-- 
1.5.3.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Patch v2] AM35xx-Craneboard:Display: Add DVI and TV Support
@ 2011-05-02 13:40   ` srinath at mistralsolutions.com
  0 siblings, 0 replies; 13+ messages in thread
From: srinath at mistralsolutions.com @ 2011-05-02 13:40 UTC (permalink / raw)
  To: linux-arm-kernel

From: Srinath.R <srinath@mistralsolutions.com>

Added Display (DVI and TV) support for CraneBoard.

History:
https://patchwork.kernel.org/patch/740761/

Signed-off-by: Srinath.R <srinath@mistralsolutions.com>
---
 arch/arm/mach-omap2/board-am3517crane.c |   73 +++++++++++++++++++++++++++++++
 1 files changed, 73 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
index 05867b5..26fa565 100644
--- a/arch/arm/mach-omap2/board-am3517crane.c
+++ b/arch/arm/mach-omap2/board-am3517crane.c
@@ -29,12 +29,15 @@
 #include <plat/board.h>
 #include <plat/common.h>
 #include <plat/usb.h>
+#include <plat/display.h>
+#include <plat/panel-generic-dpi.h>
 
 #include "mux.h"
 #include "control.h"
 
 #define GPIO_USB_POWER		35
 #define GPIO_USB_NRESET		38
+#define GPIO_DVI_ENABLE		52
 
 
 /* Board initialization */
@@ -66,11 +69,78 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = {
 	.reset_gpio_port[2]  = -EINVAL
 };
 
+static void __init am3517_crane_display_init(void)
+{
+	int ret;
+
+	ret = omap_mux_init_gpio(GPIO_DVI_ENABLE, OMAP_PIN_OUTPUT);
+	if (ret < 0) {
+		pr_err("Can not configure mux for GPIO_DVI_ENABLE %d\n",
+			GPIO_DVI_ENABLE);
+		return;
+	}
+
+	ret = gpio_request_one(GPIO_DVI_ENABLE, GPIOF_OUT_INIT_HIGH,
+				"dvi_enable");
+	if (ret < 0) {
+		pr_err("Can not request GPIO %d\n", GPIO_DVI_ENABLE);
+		return;
+	}
+
+}
+
+static struct omap_dss_device am3517_crane_tv_device = {
+	.type                   = OMAP_DISPLAY_TYPE_VENC,
+	.name                   = "tv",
+	.driver_name            = "venc",
+	.phy.venc.type          = OMAP_DSS_VENC_TYPE_COMPOSITE,
+	.platform_enable        = NULL,
+	.platform_disable       = NULL,
+};
+
+static int am3517_crane_panel_enable_dvi(struct omap_dss_device *dssdev)
+{
+	gpio_set_value(GPIO_DVI_ENABLE, 1);
+	return 0;
+}
+
+static void am3517_crane_panel_disable_dvi(struct omap_dss_device *dssdev)
+{
+	gpio_set_value(GPIO_DVI_ENABLE, 0);
+}
+
+
+static struct panel_generic_dpi_data dvi_panel = {
+	.name                   = "generic",
+	.platform_enable        = am3517_crane_panel_enable_dvi,
+	.platform_disable       = am3517_crane_panel_disable_dvi,
+};
+
+static struct omap_dss_device am3517_crane_dvi_device = {
+	.type                   = OMAP_DISPLAY_TYPE_DPI,
+	.name                   = "dvi",
+	.driver_name            = "generic_dpi_panel",
+	.data                   = &dvi_panel,
+	.phy.dpi.data_lines     = 24,
+};
+
+static struct omap_dss_device *am3517_crane_dss_devices[] = {
+	&am3517_crane_tv_device,
+	&am3517_crane_dvi_device,
+};
+
+static struct omap_dss_board_info am3517_crane_dss_data = {
+	.num_devices    = ARRAY_SIZE(am3517_crane_dss_devices),
+	.devices        = am3517_crane_dss_devices,
+	.default_device = &am3517_crane_dvi_device,
+};
+
 static void __init am3517_crane_init(void)
 {
 	int ret;
 
 	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
+	omap_display_init(&am3517_crane_dss_data);
 	omap_serial_init();
 
 	omap_board_config = am3517_crane_config;
@@ -103,6 +173,9 @@ static void __init am3517_crane_init(void)
 	}
 
 	usbhs_init(&usbhs_bdata);
+
+	/* DSS */
+	am3517_crane_display_init();
 }
 
 MACHINE_START(CRANEBOARD, "AM3517/05 CRANEBOARD")
-- 
1.5.3.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2011-05-02 13:40 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <[PATCH]>
2011-04-29 11:41 ` [PATCH 1/2] AM35xx-Craneboard: USB EHCI: Fix USB ECHI PHY reset srinath
2011-04-29 11:41   ` srinath at mistralsolutions.com
2011-04-29 12:39   ` Sergei Shtylyov
2011-04-29 12:39     ` Sergei Shtylyov
2011-04-29 11:41 ` [PATCH 2/2] AM35xx-Craneboard:Display: Add DVI and TV Support srinath
2011-04-29 11:41   ` srinath
2011-04-29 11:41   ` srinath at mistralsolutions.com
2011-04-29 12:44   ` Sergei Shtylyov
2011-04-29 12:44     ` Sergei Shtylyov
2011-05-02 13:40 ` [Patch v2] AM35xx-Craneboard: USB EHCI: Fix USB ECHI PHY reset srinath
2011-05-02 13:40   ` srinath at mistralsolutions.com
2011-05-02 13:40 ` [Patch v2] AM35xx-Craneboard:Display: Add DVI and TV Support srinath
2011-05-02 13:40   ` srinath at mistralsolutions.com

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.