Re: [Xen-devel] Re: [PATCH] Two patches fixing regression introduced by 'x86-64, mm: Put early page table high'

All of lore.kernel.org
 help / color / mirror / Atom feed

From: "H. Peter Anvin" <hpa@zytor.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xensource.com, yinghai@kernel.org,
	linux-kernel@vger.kernel.org, stefano.stabellini@eu.citrix.com
Subject: Re: [Xen-devel] Re: [PATCH] Two patches fixing regression introduced by 'x86-64, mm: Put early page table high'
Date: Mon, 02 May 2011 11:33:16 -0700	[thread overview]
Message-ID: <4DBEF8EC.7080301@zytor.com> (raw)
In-Reply-To: <20110502180802.GA7498@dumpdata.com>

On 05/02/2011 11:08 AM, Konrad Rzeszutek Wilk wrote:
>>
>> My inclination would be to apply your workaround -- are there any
>> adverse effects to doing that?
> 
> There is a bootup slowdown (not noticeable). That is because we call the
> 'memblock_find_range' function on every PTE table creation (only during
> bootup of course). 
> 
> Testing wise, on the machines on which the regression occurred, with these two
> patches the regression disappears - so that is a good sign. I am testing
> it on some more today to assure myself I am not missing anything.
> 

OK, sounds like a plan then.  I like it because it doesn't affect the
native kernel.

	-hpa

WARNING: multiple messages have this Message-ID (diff)

From: "H. Peter Anvin" <hpa@zytor.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xensource.com, yinghai@kernel.org,
	linux-kernel@vger.kernel.org, stefano.stabellini@eu.citrix.com
Subject: Re: Re: [PATCH] Two patches fixing regression introduced by 'x86-64, mm: Put early page table high'
Date: Mon, 02 May 2011 11:33:16 -0700	[thread overview]
Message-ID: <4DBEF8EC.7080301@zytor.com> (raw)
In-Reply-To: <20110502180802.GA7498@dumpdata.com>

On 05/02/2011 11:08 AM, Konrad Rzeszutek Wilk wrote:
>>
>> My inclination would be to apply your workaround -- are there any
>> adverse effects to doing that?
> 
> There is a bootup slowdown (not noticeable). That is because we call the
> 'memblock_find_range' function on every PTE table creation (only during
> bootup of course). 
> 
> Testing wise, on the machines on which the regression occurred, with these two
> patches the regression disappears - so that is a good sign. I am testing
> it on some more today to assure myself I am not missing anything.
> 

OK, sounds like a plan then.  I like it because it doesn't affect the
native kernel.

	-hpa

next prev parent reply	other threads:[~2011-05-02 18:33 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-02 17:22 [PATCH] Two patches fixing regression introduced by 'x86-64, mm: Put early page table high' Konrad Rzeszutek Wilk
2011-05-02 17:22 ` [PATCH 1/2] xen/mmu: Add workaround "x86-64, mm: Put early page table high" Konrad Rzeszutek Wilk
2011-05-03  0:55   ` Daniel Kiper
2011-05-03  0:55     ` Daniel Kiper
2011-05-03 15:12     ` Konrad Rzeszutek Wilk
2011-05-03 15:12       ` Konrad Rzeszutek Wilk
2011-05-03 19:51       ` Daniel Kiper
2011-05-03 19:51         ` Daniel Kiper
2011-05-04 18:59         ` Daniel Kiper
2011-05-04 19:33           ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-05-05 11:34             ` Daniel Kiper
2011-05-05 11:34               ` Daniel Kiper
2011-05-05 12:55           ` Stefano Stabellini
2011-05-05 14:01             ` Konrad Rzeszutek Wilk
2011-05-05 14:06               ` Stefano Stabellini
2011-05-09  7:06                 ` Daniel Kiper
2011-05-03 13:20   ` Stefano Stabellini
2011-05-03 15:27     ` Konrad Rzeszutek Wilk
2011-05-02 17:22 ` [PATCH 2/2] xen: mask_rw_pte mark RO all pagetable pages up to pgt_buf_top Konrad Rzeszutek Wilk
2011-05-02 17:31 ` [PATCH] Two patches fixing regression introduced by 'x86-64, mm: Put early page table high' H. Peter Anvin
2011-05-02 17:31   ` H. Peter Anvin
2011-05-02 18:08   ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-05-02 18:33     ` H. Peter Anvin [this message]
2011-05-02 18:33       ` H. Peter Anvin
2011-05-02 19:34       ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-05-02 19:34         ` Konrad Rzeszutek Wilk
2011-05-02 19:59         ` [Xen-devel] " H. Peter Anvin
2011-05-02 20:07           ` Konrad Rzeszutek Wilk
2011-05-02 20:16             ` Yinghai Lu
2011-05-02 20:16               ` Yinghai Lu
2011-05-05 16:28           ` [Xen-devel] Re: [PATCH] Two patches fixing regression introduced by 'x86-64, mm: Put early page table high' - does not work Konrad Rzeszutek Wilk
2011-05-05 16:28             ` Konrad Rzeszutek Wilk
2011-05-05 18:45             ` [Xen-devel] " Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DBEF8EC.7080301@zytor.com \
    --to=hpa@zytor.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.