Re: [PATCH V4 2/5] USB: OTG: msm: vote for dayatona fabric clock

[Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>]

Hello.

On 03-05-2011 9:13, Pavankumar Kondeti wrote:

> From: Anji jonnala <anjir-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>

> HSUSB core clock is derived from daytona fabric clock and for
> HSUSB operational require minimum core clock at 55MHz. Since, HSUSB
> cannot tolerate daytona fabric clock change in the middle of HSUSB
> operational, vote for maximum Daytona fabric clock
> while usb is operational

> Signed-off-by: Anji jonnala<anjir-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> Signed-off-by: Pavankumar Kondeti<pkondeti-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
[...]

> diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c
> index 2965986..cfbb606 100644
> --- a/drivers/usb/otg/msm_otg.c
> +++ b/drivers/usb/otg/msm_otg.c
[...]
> @@ -954,7 +979,11 @@ free_regs:
>   put_core_clk:
>   	if (motg->core_clk)
>   		clk_put(motg->core_clk);
> -	clk_put(motg->pclk);

    Is it really correct to remove this line?

> +put_pclk_src:
> +	if (!IS_ERR(motg->pclk_src)) {
> +		clk_disable(motg->pclk_src);
> +		clk_put(motg->pclk_src);
> +	}
>   put_clk:
>   	clk_put(motg->clk);
>   put_phy_reset_clk:

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html