From: Jan Kiszka <jan.kiszka@siemens.com>
To: Alexander Graf <agraf@suse.de>
Cc: KVM devel mailing list <kvm@vger.kernel.org>
Subject: Re: [PATCH 6/6] KVM: PPC: Add kvm headers to headers_install
Date: Tue, 03 May 2011 17:10:04 +0200 [thread overview]
Message-ID: <4DC01ACC.4020700@siemens.com> (raw)
In-Reply-To: <00EA08FF-5902-4D50-87A9-6D2FE8565657@suse.de>
On 2011-05-03 17:04, Alexander Graf wrote:
>
> On 03.05.2011, at 16:44, Jan Kiszka wrote:
>
>> On 2011-05-03 16:36, Alexander Graf wrote:
>>>
>>> On 03.05.2011, at 16:20, Jan Kiszka wrote:
>>>
>>>> On 2011-05-03 14:37, Alexander Graf wrote:
>>>>> When running "make headers_install", we don't install kvm headers on
>>>>> PPC. This confuses Qemu, as it really wants to include kernel headers
>>>>> to know the ioctl structs.
>>>>>
>>>>> So let's add the arch/powerpc/include/asm headers that are important
>>>>> for KVM to the headers_install list.
>>>>>
>>>>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>>>> ---
>>>>> arch/powerpc/include/asm/Kbuild | 2 ++
>>>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>>>
>>>>> diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
>>>>> index d51df17..568b000 100644
>>>>> --- a/arch/powerpc/include/asm/Kbuild
>>>>> +++ b/arch/powerpc/include/asm/Kbuild
>>>>> @@ -34,3 +34,5 @@ header-y += termios.h
>>>>> header-y += types.h
>>>>> header-y += ucontext.h
>>>>> header-y += unistd.h
>>>>> +header-y += kvm.h
>>>>> +header-y += kvm_para.h
>>>>
>>>> Weird, just worked for me with current kvm master without your patch.
>>>
>>> Oh? You did do make headers_install and it did push the correct headers to usr?
>>
>> I strongly suspect. It's all documented in my header patch.
>
> Your header patch manually copies the respective files, so you're not using that code path there?
>
I'm copying from the output dir auf headers_install (INSTALL_HDR_PATH).
What step does this patch target at?
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-05-03 15:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 12:36 [PULL 0/6] PPC KVM patches Alexander Graf
2011-05-03 12:36 ` [PATCH 1/6] KVM: PPC: e500: emulate SVR Alexander Graf
2011-05-03 12:36 ` [PATCH 2/6] KVM: PPC: fix exit accounting for SPRs, tlbwe, tlbsx Alexander Graf
2011-05-03 12:36 ` [PATCH 3/6] KVM: PPC: use ticks, not usecs, for exit timing Alexander Graf
2011-05-03 12:36 ` [PATCH 4/6] KVM: PPC: booke: save/restore VRSAVE (a.k.a. USPRG0) Alexander Graf
2011-05-03 12:37 ` [PATCH 5/6] KVM: PPC: booke: add sregs support Alexander Graf
2011-05-03 12:37 ` [PATCH 6/6] KVM: PPC: Add kvm headers to headers_install Alexander Graf
2011-05-03 14:20 ` Jan Kiszka
2011-05-03 14:36 ` Alexander Graf
2011-05-03 14:44 ` Jan Kiszka
2011-05-03 15:04 ` Alexander Graf
2011-05-03 15:10 ` Jan Kiszka [this message]
2011-05-03 15:14 ` Alexander Graf
2011-05-03 16:20 ` Scott Wood
2011-05-04 5:55 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC01ACC.4020700@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=agraf@suse.de \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.