From: Luca Ceresoli <luca.ceresoli@comelit.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/8] net/net.c: cosmetic: variable initializations
Date: Wed, 04 May 2011 18:42:30 +0200 [thread overview]
Message-ID: <4DC181F6.8000306@comelit.it> (raw)
In-Reply-To: <BANLkTim3Lk=NJjNF4v-e4iA9p2uNXYaOsg@mail.gmail.com>
Mike Frysinger wrote:
> On Wed, May 4, 2011 at 08:40, Luca Ceresoli wrote:
>> - ERROR: that open brace { should be on the previous line
>> ...
>> -uchar NetCDPAddr[6] =
>> - { 0x01, 0x00, 0x0c, 0xcc, 0xcc, 0xcc };
>> +uchar NetCDPAddr[6] = {
>> + 0x01, 0x00, 0x0c, 0xcc, 0xcc, 0xcc };
>> ...
> your fix here is worse than the original. just leave them be.
Damn, you're right!
I think a one-line solution would be even better (and much simpler):
uchar NetCDPAddr[6] = {0x01, 0x00, 0x0c, 0xcc, 0xcc, 0xcc};
BTW, this is the original checkpatch message:
ERROR: that open brace { should be on the previous line
#172: FILE: net.c:172:
+uchar NetCDPAddr[6] =
+ { 0x01, 0x00, 0x0c, 0xcc, 0xcc, 0xcc };
So either we choose the one-line solution above, or we have the first
checkpatch message that should be disabled in the U-Boot version, when it
will exist.
Your opinion?
Luca
next prev parent reply other threads:[~2011-05-04 16:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 12:40 [U-Boot] [PATCH 0/8] net/net.c: clenups for checkpatch compliance Luca Ceresoli
2011-05-04 12:40 ` [U-Boot] [PATCH 1/8] net/net.c: cosmetic: fix lines over 80 characters Luca Ceresoli
2011-05-09 19:42 ` Mike Frysinger
2011-05-10 7:13 ` Luca Ceresoli
2011-05-10 15:51 ` Mike Frysinger
2011-05-04 12:40 ` [U-Boot] [PATCH 2/8] net/net.c: cosmetic: variable initializations Luca Ceresoli
2011-05-04 13:16 ` Mike Frysinger
2011-05-04 16:42 ` Luca Ceresoli [this message]
2011-05-05 7:54 ` Mike Frysinger
2011-05-04 12:40 ` [U-Boot] [PATCH 3/8] net/net.c: cosmetic: fix whitespace issues Luca Ceresoli
2011-05-04 12:40 ` [U-Boot] [PATCH 4/8] net/net.c: cosmetic: fix brace issues Luca Ceresoli
2011-05-04 12:40 ` [U-Boot] [PATCH 5/8] net/net.c: cosmetic: fix pointer syntax issues Luca Ceresoli
2011-05-04 12:40 ` [U-Boot] [PATCH 6/8] net/net.c: cosmetic: parentheses not required for return Luca Ceresoli
2011-05-04 12:40 ` [U-Boot] [PATCH 7/8] net/net.c: cosmetic: fix indentation Luca Ceresoli
2011-05-04 12:40 ` [U-Boot] [PATCH 8/8] net/net.c: cosmetic: do not use assignment in if condition Luca Ceresoli
2011-05-11 13:59 ` [U-Boot] [PATCH v2 0/8] net/net.c: cleanups for checkpatch compliance Luca Ceresoli
2011-05-11 13:59 ` [U-Boot] [PATCH v2 1/8] net/net.c: cosmetic: fix lines over 80 characters Luca Ceresoli
2011-05-12 20:14 ` Wolfgang Denk
2011-05-11 13:59 ` [U-Boot] [PATCH v2 2/8] net/net.c: cosmetic: variable initializations Luca Ceresoli
2011-05-12 20:17 ` Wolfgang Denk
2011-05-11 13:59 ` [U-Boot] [PATCH v2 3/8] net/net.c: cosmetic: fix whitespace issues Luca Ceresoli
2011-05-12 20:17 ` Wolfgang Denk
2011-05-11 13:59 ` [U-Boot] [PATCH v2 4/8] net/net.c: cosmetic: fix brace issues Luca Ceresoli
2011-05-12 20:17 ` Wolfgang Denk
2011-05-11 13:59 ` [U-Boot] [PATCH v2 5/8] net/net.c: cosmetic: fix pointer syntax issues Luca Ceresoli
2011-05-12 20:17 ` Wolfgang Denk
2011-05-11 13:59 ` [U-Boot] [PATCH v2 6/8] net/net.c: cosmetic: parentheses not required for return Luca Ceresoli
2011-05-12 20:18 ` Wolfgang Denk
2011-05-11 14:00 ` [U-Boot] [PATCH v2 7/8] net/net.c: cosmetic: fix indentation Luca Ceresoli
2011-05-12 20:18 ` Wolfgang Denk
2011-05-11 14:00 ` [U-Boot] [PATCH v2 8/8] net/net.c: cosmetic: do not use assignment in if condition Luca Ceresoli
2011-05-12 20:18 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC181F6.8000306@comelit.it \
--to=luca.ceresoli@comelit.it \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.