From: Luca Ceresoli <luca.ceresoli@comelit.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/8] net/net.c: cosmetic: fix lines over 80 characters
Date: Tue, 10 May 2011 09:13:44 +0200 [thread overview]
Message-ID: <4DC8E5A8.1090203@comelit.it> (raw)
In-Reply-To: <201105091542.04858.vapier@gentoo.org>
Hi Mike,
Mike Frysinger wrote:
> On Wednesday, May 04, 2011 08:40:40 Luca Ceresoli wrote:
>> - debug("Got ICMP ECHO REQUEST, return %d bytes \n",
>> - ETHER_HDR_SIZE + len);
>> + debug("Got ICMP ECHO REQUEST, "
>> + "return %d bytes \n",
>> + ETHER_HDR_SIZE + len);
> please do not split string literals
What do you suggest as an alternative? Leave the line more than
80 characters long?
I think the best thing would be to split the NetReceive() function that
contains that line, which is currently ~400 lines long. This would reduce
the amount of tabs in front of the deeply nested lines (such as this).
So I would agree to leave the line as is, waiting for NetReceive() to be
split in a future cleanup work.
Luca
next prev parent reply other threads:[~2011-05-10 7:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 12:40 [U-Boot] [PATCH 0/8] net/net.c: clenups for checkpatch compliance Luca Ceresoli
2011-05-04 12:40 ` [U-Boot] [PATCH 1/8] net/net.c: cosmetic: fix lines over 80 characters Luca Ceresoli
2011-05-09 19:42 ` Mike Frysinger
2011-05-10 7:13 ` Luca Ceresoli [this message]
2011-05-10 15:51 ` Mike Frysinger
2011-05-04 12:40 ` [U-Boot] [PATCH 2/8] net/net.c: cosmetic: variable initializations Luca Ceresoli
2011-05-04 13:16 ` Mike Frysinger
2011-05-04 16:42 ` Luca Ceresoli
2011-05-05 7:54 ` Mike Frysinger
2011-05-04 12:40 ` [U-Boot] [PATCH 3/8] net/net.c: cosmetic: fix whitespace issues Luca Ceresoli
2011-05-04 12:40 ` [U-Boot] [PATCH 4/8] net/net.c: cosmetic: fix brace issues Luca Ceresoli
2011-05-04 12:40 ` [U-Boot] [PATCH 5/8] net/net.c: cosmetic: fix pointer syntax issues Luca Ceresoli
2011-05-04 12:40 ` [U-Boot] [PATCH 6/8] net/net.c: cosmetic: parentheses not required for return Luca Ceresoli
2011-05-04 12:40 ` [U-Boot] [PATCH 7/8] net/net.c: cosmetic: fix indentation Luca Ceresoli
2011-05-04 12:40 ` [U-Boot] [PATCH 8/8] net/net.c: cosmetic: do not use assignment in if condition Luca Ceresoli
2011-05-11 13:59 ` [U-Boot] [PATCH v2 0/8] net/net.c: cleanups for checkpatch compliance Luca Ceresoli
2011-05-11 13:59 ` [U-Boot] [PATCH v2 1/8] net/net.c: cosmetic: fix lines over 80 characters Luca Ceresoli
2011-05-12 20:14 ` Wolfgang Denk
2011-05-11 13:59 ` [U-Boot] [PATCH v2 2/8] net/net.c: cosmetic: variable initializations Luca Ceresoli
2011-05-12 20:17 ` Wolfgang Denk
2011-05-11 13:59 ` [U-Boot] [PATCH v2 3/8] net/net.c: cosmetic: fix whitespace issues Luca Ceresoli
2011-05-12 20:17 ` Wolfgang Denk
2011-05-11 13:59 ` [U-Boot] [PATCH v2 4/8] net/net.c: cosmetic: fix brace issues Luca Ceresoli
2011-05-12 20:17 ` Wolfgang Denk
2011-05-11 13:59 ` [U-Boot] [PATCH v2 5/8] net/net.c: cosmetic: fix pointer syntax issues Luca Ceresoli
2011-05-12 20:17 ` Wolfgang Denk
2011-05-11 13:59 ` [U-Boot] [PATCH v2 6/8] net/net.c: cosmetic: parentheses not required for return Luca Ceresoli
2011-05-12 20:18 ` Wolfgang Denk
2011-05-11 14:00 ` [U-Boot] [PATCH v2 7/8] net/net.c: cosmetic: fix indentation Luca Ceresoli
2011-05-12 20:18 ` Wolfgang Denk
2011-05-11 14:00 ` [U-Boot] [PATCH v2 8/8] net/net.c: cosmetic: do not use assignment in if condition Luca Ceresoli
2011-05-12 20:18 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC8E5A8.1090203@comelit.it \
--to=luca.ceresoli@comelit.it \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.