From: Andi Kleen <ak@linux.intel.com>
To: David Rientjes <rientjes@google.com>
Cc: Andi Kleen <andi@firstfloor.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Michal Hocko <mhocko@suse.cz>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Balbir Singh <balbir@in.ibm.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] Allocate memory cgroup structures in local nodes
Date: Wed, 04 May 2011 13:04:33 -0700 [thread overview]
Message-ID: <4DC1B151.7010300@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1105041213310.22426@chino.kir.corp.google.com>
> Before that's considered, the order of the arguments to
> alloc_pages_exact_node() needs to be fixed.
Good point. I'll send another one.
This is really misleading BTW. Grumble. Maybe it would be actually
better to
change the prototype too.
> The vmalloc_node() calls ensure that the nid is actually set in
>N_HIGH_MEMORY and fails otherwise (we don't fallback to using vmalloc()),
>so it looks like the failures for alloc_pages_exact_node() and
>vmalloc_node() would be different? Why do we want to fallback for one and
>not the other?
The right order would be to try everything (alloc_pages + vmalloc)
to get it node local, before trying everything else. Right now that's
not how it's done.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@linux.intel.com>
To: David Rientjes <rientjes@google.com>
Cc: Andi Kleen <andi@firstfloor.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Michal Hocko <mhocko@suse.cz>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Balbir Singh <balbir@in.ibm.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] Allocate memory cgroup structures in local nodes
Date: Wed, 04 May 2011 13:04:33 -0700 [thread overview]
Message-ID: <4DC1B151.7010300@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1105041213310.22426@chino.kir.corp.google.com>
> Before that's considered, the order of the arguments to
> alloc_pages_exact_node() needs to be fixed.
Good point. I'll send another one.
This is really misleading BTW. Grumble. Maybe it would be actually
better to
change the prototype too.
> The vmalloc_node() calls ensure that the nid is actually set in
>N_HIGH_MEMORY and fails otherwise (we don't fallback to using vmalloc()),
>so it looks like the failures for alloc_pages_exact_node() and
>vmalloc_node() would be different? Why do we want to fallback for one and
>not the other?
The right order would be to try everything (alloc_pages + vmalloc)
to get it node local, before trying everything else. Right now that's
not how it's done.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-04 20:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 18:17 [PATCH] Allocate memory cgroup structures in local nodes Andi Kleen
2011-05-04 18:17 ` Andi Kleen
2011-05-04 19:17 ` David Rientjes
2011-05-04 19:17 ` David Rientjes
2011-05-04 20:04 ` Andi Kleen [this message]
2011-05-04 20:04 ` Andi Kleen
2011-05-04 20:10 ` David Rientjes
2011-05-04 20:10 ` David Rientjes
2011-05-04 20:18 ` Andi Kleen
2011-05-04 20:18 ` Andi Kleen
2011-05-04 19:36 ` Balbir Singh
2011-05-04 19:36 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC1B151.7010300@linux.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=balbir@in.ibm.com \
--cc=dave@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.