From: Ian Romanick <idr-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org>
To: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
Cc: xorg-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] glxproto: make GLX swap event struct match spec
Date: Wed, 04 May 2011 15:11:16 -0700 [thread overview]
Message-ID: <4DC1CF04.2060708@freedesktop.org> (raw)
In-Reply-To: <20110503140858.65d5f945@jbarnes-desktop>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 05/03/2011 02:08 PM, Jesse Barnes wrote:
> On Tue, 3 May 2011 14:02:31 -0700
> Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org> wrote:
>
>> On Tue, 03 May 2011 13:54:38 -0700
>> Keith Packard <keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org> wrote:
>>
>>> On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org> wrote:
>>>
>>>> We only spec a 32 bit swap count, so drop the high sbc field.
>>>
>>> You're missing the explicit 16-bit padding field after 'event_type'
>>>
>>> The documented encoding
>>> http://www.opengl.org/registry/specs/INTEL/swap_event.txt needs to be
>>> fixed to match this, it has the padding at the end which leaves most of
>>> the structure mis-aligned.
>>
>> Right, another case where we updated the spec incorrectly then failed
>> to make the code match the broken definition (the complete enums also
>> need to match the final values, which are correct in the first part of
>> the spec). Yay for divergence.
>
> Fixed version below.
>
Does this need the "B16" cruft?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk3BzwQACgkQX1gOwKyEAw/SowCfaAm1gxkowryhD2ku9oPMlaUY
YyoAniZgXMFszpUBwnJH17JDyZwtsOw+
=k7tr
-----END PGP SIGNATURE-----
_______________________________________________
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
next prev parent reply other threads:[~2011-05-04 22:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 19:21 Make swap event handling match the spec Jesse Barnes
2011-05-03 19:21 ` [PATCH] dri2proto: make DRI2 swap event match GLX spec Jesse Barnes
2011-05-03 21:09 ` Jesse Barnes
[not found] ` <1304450489-31415-1-git-send-email-jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
2011-05-03 19:21 ` [PATCH] glxproto: make GLX swap event struct match spec Jesse Barnes
2011-05-03 20:54 ` Keith Packard
2011-05-03 21:02 ` Jesse Barnes
2011-05-03 21:08 ` Jesse Barnes
2011-05-03 21:15 ` Keith Packard
2011-05-03 21:20 ` Jesse Barnes
2011-05-04 22:11 ` Ian Romanick [this message]
2011-05-04 22:17 ` [Mesa-dev] " Ian Romanick
2011-05-04 23:16 ` Jesse Barnes
2011-05-04 23:21 ` Jesse Barnes
2011-05-04 23:32 ` [Mesa-dev] " Dave Airlie
2011-05-05 0:49 ` Jesse Barnes
2011-05-05 0:54 ` Jesse Barnes
2011-05-03 19:21 ` [PATCH 3/4] GLX/DRI2: pass drawable correctly for indirect swap events Jesse Barnes
2011-05-03 19:21 ` [PATCH 5/6] GLX: don't crash when indirect clients try to set an event mask Jesse Barnes
2011-05-03 19:24 ` Make swap event handling match the spec Jesse Barnes
2011-05-03 19:21 ` [PATCH 4/4] GLX/DRI2: make GLX swap event handling match spec Jesse Barnes
2011-05-03 19:21 ` [PATCH 6/6] DRI2/GLX: make " Jesse Barnes
2011-05-04 22:26 ` [Mesa-dev] Make swap event handling match the spec Ian Romanick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC1CF04.2060708@freedesktop.org \
--to=idr-cc+yj3umiyqdupfqwhejaq@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org \
--cc=mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=xorg-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.