From: Hauke Mehrtens <hauke@hauke-m.de>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH][WAS:bcmai, axi] bcma: add Broadcom specific AMBA bus driver
Date: Sun, 08 May 2011 14:48:15 +0200 [thread overview]
Message-ID: <4DC6910F.2020008@hauke-m.de> (raw)
In-Reply-To: <1304632783-8781-1-git-send-email-zajec5@gmail.com>
On 05/05/2011 11:59 PM, Rafa? Mi?ecki wrote:
.....
> --- /dev/null
> +++ b/drivers/bcma/bcma_private.h
.....
> +
> +#define BCMA_ADDR_BASE 0x18000000
> +#define BCMA_WRAP_BASE 0x18100000
> +
......
> --- /dev/null
> +++ b/drivers/bcma/scan.h
> @@ -0,0 +1,56 @@
> +#ifndef BCMA_SCAN_H_
> +#define BCMA_SCAN_H_
> +
> +#define BCMA_ADDR_BASE 0x18000000
> +#define BCMA_WRAP_BASE 0x18100000
> +
.....
While graping through the code I found this. BCMA_ADDR_BASE and
BCMA_WRAP_BASE are defined twice.
Why are some constants defined in purpose specific headers in
drivers/bcma/*.h like drivers/bcma/scan.h and some in
drivers/bcma/bcma_private.h and other in include/linux/bcma/bcma_regs.h ?
Hauke
WARNING: multiple messages have this Message-ID (diff)
From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org, "Greg KH" <greg@kroah.com>,
"Michael Büsch" <mb@bu3sch.de>,
"Larry Finger" <Larry.Finger@lwfinger.net>,
"George Kashperko" <george@znau.edu.ua>,
"Arend van Spriel" <arend@broadcom.com>,
linux-arm-kernel@lists.infradead.org,
"Russell King" <rmk@arm.linux.org.uk>,
"Arnd Bergmann" <arnd@arndb.de>,
"Andy Botting" <andy@andybotting.com>,
linuxdriverproject <devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver
Date: Sun, 08 May 2011 14:48:15 +0200 [thread overview]
Message-ID: <4DC6910F.2020008@hauke-m.de> (raw)
In-Reply-To: <1304632783-8781-1-git-send-email-zajec5@gmail.com>
On 05/05/2011 11:59 PM, Rafał Miłecki wrote:
.....
> --- /dev/null
> +++ b/drivers/bcma/bcma_private.h
.....
> +
> +#define BCMA_ADDR_BASE 0x18000000
> +#define BCMA_WRAP_BASE 0x18100000
> +
......
> --- /dev/null
> +++ b/drivers/bcma/scan.h
> @@ -0,0 +1,56 @@
> +#ifndef BCMA_SCAN_H_
> +#define BCMA_SCAN_H_
> +
> +#define BCMA_ADDR_BASE 0x18000000
> +#define BCMA_WRAP_BASE 0x18100000
> +
.....
While graping through the code I found this. BCMA_ADDR_BASE and
BCMA_WRAP_BASE are defined twice.
Why are some constants defined in purpose specific headers in
drivers/bcma/*.h like drivers/bcma/scan.h and some in
drivers/bcma/bcma_private.h and other in include/linux/bcma/bcma_regs.h ?
Hauke
WARNING: multiple messages have this Message-ID (diff)
From: hauke@hauke-m.de (Hauke Mehrtens)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH][WAS:bcmai, axi] bcma: add Broadcom specific AMBA bus driver
Date: Sun, 08 May 2011 14:48:15 +0200 [thread overview]
Message-ID: <4DC6910F.2020008@hauke-m.de> (raw)
In-Reply-To: <1304632783-8781-1-git-send-email-zajec5@gmail.com>
On 05/05/2011 11:59 PM, Rafa? Mi?ecki wrote:
.....
> --- /dev/null
> +++ b/drivers/bcma/bcma_private.h
.....
> +
> +#define BCMA_ADDR_BASE 0x18000000
> +#define BCMA_WRAP_BASE 0x18100000
> +
......
> --- /dev/null
> +++ b/drivers/bcma/scan.h
> @@ -0,0 +1,56 @@
> +#ifndef BCMA_SCAN_H_
> +#define BCMA_SCAN_H_
> +
> +#define BCMA_ADDR_BASE 0x18000000
> +#define BCMA_WRAP_BASE 0x18100000
> +
.....
While graping through the code I found this. BCMA_ADDR_BASE and
BCMA_WRAP_BASE are defined twice.
Why are some constants defined in purpose specific headers in
drivers/bcma/*.h like drivers/bcma/scan.h and some in
drivers/bcma/bcma_private.h and other in include/linux/bcma/bcma_regs.h ?
Hauke
next prev parent reply other threads:[~2011-05-08 12:48 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 21:59 [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver Rafał Miłecki
2011-07-08 17:41 ` Rafał Miłecki
2011-05-05 21:59 ` Rafał Miłecki
2011-05-05 22:59 ` Julian Calaby
2011-05-05 22:59 ` [PATCH][WAS:bcmai, axi] " Julian Calaby
2011-05-05 23:01 ` Rafał Miłecki
2011-05-05 23:01 ` Rafał Miłecki
2011-05-05 23:01 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-06 14:05 ` Arnd Bergmann
2011-05-06 14:05 ` [PATCH][WAS:bcmai, axi] " Arnd Bergmann
2011-05-06 14:50 ` Rafał Miłecki
2011-05-06 14:50 ` Rafał Miłecki
2011-05-06 14:50 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-07 13:34 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 13:34 ` Rafał Miłecki
2011-05-07 13:34 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-07 13:55 ` Michael Büsch
2011-05-07 13:55 ` Michael Büsch
2011-05-07 13:55 ` Michael Büsch
2011-05-07 16:29 ` Arend van Spriel
2011-05-07 16:29 ` Arend van Spriel
2011-05-07 16:49 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 16:49 ` Rafał Miłecki
2011-05-07 16:49 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-07 17:04 ` Arend van Spriel
2011-05-07 17:04 ` Arend van Spriel
2011-05-07 17:20 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 17:20 ` Rafał Miłecki
2011-05-07 17:20 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-07 17:51 ` George Kashperko
2011-05-07 17:51 ` George Kashperko
2011-05-07 18:05 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 18:05 ` Rafał Miłecki
2011-05-07 18:05 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-07 18:26 ` George Kashperko
2011-05-07 18:26 ` George Kashperko
2011-05-07 18:48 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 18:48 ` Rafał Miłecki
2011-05-07 18:48 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-07 19:02 ` George Kashperko
2011-05-07 19:02 ` George Kashperko
2011-05-07 19:21 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 19:21 ` Rafał Miłecki
2011-05-07 19:21 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-07 19:35 ` George Kashperko
2011-05-07 19:35 ` George Kashperko
2011-05-08 1:44 ` Michael Büsch
2011-05-08 1:44 ` Michael Büsch
2011-05-08 1:44 ` Michael Büsch
2011-05-08 2:01 ` George Kashperko
2011-05-08 2:01 ` George Kashperko
2011-05-07 19:03 ` George Kashperko
2011-05-07 19:03 ` George Kashperko
2011-05-08 8:43 ` Arend van Spriel
2011-05-08 8:43 ` Arend van Spriel
2011-05-08 10:16 ` Russell King - ARM Linux
2011-05-08 10:16 ` Russell King - ARM Linux
2011-05-08 10:37 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-08 10:37 ` Rafał Miłecki
2011-05-08 10:37 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-08 10:50 ` Russell King - ARM Linux
2011-05-08 10:50 ` Russell King - ARM Linux
2011-05-08 15:06 ` Arnd Bergmann
2011-05-08 15:06 ` [PATCH][WAS:bcmai, axi] " Arnd Bergmann
2011-05-08 15:25 ` Rafał Miłecki
2011-05-08 15:25 ` Rafał Miłecki
2011-05-08 15:25 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-08 15:54 ` Arnd Bergmann
2011-05-08 15:54 ` [PATCH][WAS:bcmai, axi] " Arnd Bergmann
2011-05-08 14:47 ` [PATCH][WAS:bcmai,axi] " Arnd Bergmann
2011-05-08 14:47 ` [PATCH][WAS:bcmai, axi] " Arnd Bergmann
2011-05-08 14:59 ` Rafał Miłecki
2011-05-08 14:59 ` Rafał Miłecki
2011-05-08 14:59 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-08 15:59 ` [PATCH][WAS:bcmai, axi] " Arnd Bergmann
2011-05-08 15:59 ` Arnd Bergmann
2011-05-09 14:33 ` Rafał Miłecki
2011-05-09 14:33 ` Rafał Miłecki
2011-05-09 14:33 ` Rafał Miłecki
2011-05-09 15:37 ` Greg KH
2011-05-09 15:37 ` Greg KH
2011-05-09 15:48 ` Rafał Miłecki
2011-05-09 15:48 ` Rafał Miłecki
2011-05-09 15:48 ` Rafał Miłecki
2011-05-07 16:13 ` Hauke Mehrtens
2011-05-07 16:13 ` Hauke Mehrtens
2011-05-07 16:13 ` [PATCH][WAS:bcmai,axi] " Hauke Mehrtens
2011-05-07 16:23 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 16:23 ` Rafał Miłecki
2011-05-07 16:23 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-07 16:32 ` [PATCH][WAS:bcmai, axi] " Hauke Mehrtens
2011-05-07 16:32 ` Hauke Mehrtens
2011-05-07 16:32 ` [PATCH][WAS:bcmai,axi] " Hauke Mehrtens
2011-05-07 16:51 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 16:51 ` Rafał Miłecki
2011-05-07 16:51 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-07 17:24 ` [PATCH][WAS:bcmai, axi] " Hauke Mehrtens
2011-05-07 17:24 ` Hauke Mehrtens
2011-05-07 17:24 ` [PATCH][WAS:bcmai,axi] " Hauke Mehrtens
2011-05-07 17:35 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 17:35 ` Rafał Miłecki
2011-05-07 17:35 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
2011-05-07 17:45 ` George Kashperko
2011-05-07 17:45 ` George Kashperko
2011-05-07 22:42 ` Henry Ptasinski
2011-05-07 22:42 ` Henry Ptasinski
2011-05-07 23:17 ` [PATCH][WAS:bcmai, axi] " Hauke Mehrtens
2011-05-07 23:17 ` Hauke Mehrtens
2011-05-07 23:17 ` [PATCH][WAS:bcmai,axi] " Hauke Mehrtens
2011-05-08 12:48 ` Hauke Mehrtens [this message]
2011-05-08 12:48 ` [PATCH][WAS:bcmai, axi] " Hauke Mehrtens
2011-05-08 12:48 ` [PATCH][WAS:bcmai,axi] " Hauke Mehrtens
2011-05-08 12:55 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-08 12:55 ` Rafał Miłecki
2011-05-08 12:55 ` [PATCH][WAS:bcmai,axi] " Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC6910F.2020008@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.