Re: [Qemu-devel] [PATCH] virtio-9p: Remove statement without effect (fix warning from cppcheck)

[Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>]

On 05/07/2011 01:23 PM, Stefan Weil wrote:
> cppcheck report:
> virtio-9p.c:197: warning: Redundant assignment of "flags" to itself
>
> Cc: Venkateswararao Jujjuri<jvrao@linux.vnet.ibm.com>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>

Reviewed-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>

BTW, New threading model will change these functions completely.
But in the mean while, we can keep merging these fixes as they come.

Thanks,
JV

> ---
>   hw/9pfs/virtio-9p.c |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
> index ac5a1d0..d31b34a 100644
> --- a/hw/9pfs/virtio-9p.c
> +++ b/hw/9pfs/virtio-9p.c
> @@ -194,7 +194,6 @@ static int v9fs_do_open2(V9fsState *s, char *fullname, uid_t uid, gid_t gid,
>       cred.fc_uid = uid;
>       cred.fc_gid = gid;
>       cred.fc_mode = mode&  07777;
> -    flags = flags;
>       return s->ops->open2(&s->ctx, fullname, flags,&cred);
>   }