Re: [Qemu-devel] [PATCH] virtio-9p: Remove statement without effect (fix warning from cppcheck)

[Aurelien Jarno <aurelien@aurel32.net>]

On Sat, May 07, 2011 at 10:23:49PM +0200, Stefan Weil wrote:
> cppcheck report:
> virtio-9p.c:197: warning: Redundant assignment of "flags" to itself
> 
> Cc: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  hw/9pfs/virtio-9p.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

Thanks, applied.

> diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
> index ac5a1d0..d31b34a 100644
> --- a/hw/9pfs/virtio-9p.c
> +++ b/hw/9pfs/virtio-9p.c
> @@ -194,7 +194,6 @@ static int v9fs_do_open2(V9fsState *s, char *fullname, uid_t uid, gid_t gid,
>      cred.fc_uid = uid;
>      cred.fc_gid = gid;
>      cred.fc_mode = mode & 07777;
> -    flags = flags;
>  
>      return s->ops->open2(&s->ctx, fullname, flags, &cred);
>  }
> -- 
> 1.7.2.5
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net