From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH 4/4] fix compilation when reconfiguring without dtrace backend
Date: Mon, 09 May 2011 10:42:08 +0200 [thread overview]
Message-ID: <4DC7A8E0.1020500@redhat.com> (raw)
In-Reply-To: <BANLkTinvh3YJMqJJG9mm27MSYShyBDeZtg@mail.gmail.com>
On 05/09/2011 10:34 AM, Stefan Hajnoczi wrote:
> BTW the Makefiles don't
> seem to have a step before compilation to generate all the
> dependencies, instead dependencies only kick in after the first build
> has completed?
Yes, the first build doesn't need dependencies on headers. Rules for
.c->.o and .o->executable are enough to get everything built.
> Is there some smart change detection you are thinking about or just
> something like keeping the old copy of config-host.h and friends to
> see if they have changed?
Just that, perhaps for both .h and .mak files. Consider this very
patch; it is plausible that switching to another tracing backend does
not change the .h files, right now the backend is only present in .h
files to enable the monitor/cmdline interfaces.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 4/4] fix compilation when reconfiguring without dtrace backend
Date: Mon, 09 May 2011 10:42:08 +0200 [thread overview]
Message-ID: <4DC7A8E0.1020500@redhat.com> (raw)
In-Reply-To: <BANLkTinvh3YJMqJJG9mm27MSYShyBDeZtg@mail.gmail.com>
On 05/09/2011 10:34 AM, Stefan Hajnoczi wrote:
> BTW the Makefiles don't
> seem to have a step before compilation to generate all the
> dependencies, instead dependencies only kick in after the first build
> has completed?
Yes, the first build doesn't need dependencies on headers. Rules for
.c->.o and .o->executable are enough to get everything built.
> Is there some smart change detection you are thinking about or just
> something like keeping the old copy of config-host.h and friends to
> see if they have changed?
Just that, perhaps for both .h and .mak files. Consider this very
patch; it is plausible that switching to another tracing backend does
not change the .h files, right now the backend is only present in .h
files to enable the monitor/cmdline interfaces.
Paolo
next prev parent reply other threads:[~2011-05-09 8:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 7:54 [Qemu-trivial] [PATCH 4/4] fix compilation when reconfiguring without dtrace backend Paolo Bonzini
2011-05-02 7:54 ` [Qemu-devel] " Paolo Bonzini
2011-05-08 11:15 ` [Qemu-trivial] " Stefan Hajnoczi
2011-05-08 11:15 ` [Qemu-devel] " Stefan Hajnoczi
2011-05-09 6:53 ` Paolo Bonzini
2011-05-09 6:53 ` [Qemu-devel] " Paolo Bonzini
2011-05-09 8:34 ` Stefan Hajnoczi
2011-05-09 8:34 ` [Qemu-devel] " Stefan Hajnoczi
2011-05-09 8:42 ` Paolo Bonzini [this message]
2011-05-09 8:42 ` Paolo Bonzini
2011-05-09 9:06 ` Stefan Hajnoczi
2011-05-09 9:06 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC7A8E0.1020500@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.