* [PATCH] sparc32/LEON: Added __init declaration to leon_flush_needed()
@ 2011-05-10 23:53 Matthias Rosenfelder
2011-05-11 7:18 ` Daniel Hellstrom
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Rosenfelder @ 2011-05-10 23:53 UTC (permalink / raw)
To: sparclinux
The function leon_flush_needed() is called only during bootup
from another __init function. Therefore, we can add
__init to leon_flush_needed().
Signed-off-by: Matthias Rosenfelder <rosenfelder.lkml@googlemail.com>
---
arch/sparc/mm/leon_mm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/sparc/mm/leon_mm.c b/arch/sparc/mm/leon_mm.c
index c0e0129..e485a68 100644
--- a/arch/sparc/mm/leon_mm.c
+++ b/arch/sparc/mm/leon_mm.c
@@ -226,7 +226,7 @@ void leon3_getCacheRegs(struct leon3_cacheregs *regs)
* Leon2 and Leon3 differ in their way of telling cache information
*
*/
-int leon_flush_needed(void)
+int __init leon_flush_needed(void)
{
int flush_needed = -1;
unsigned int ssize, sets;
--
1.6.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sparc32/LEON: Added __init declaration to leon_flush_needed()
2011-05-10 23:53 [PATCH] sparc32/LEON: Added __init declaration to leon_flush_needed() Matthias Rosenfelder
@ 2011-05-11 7:18 ` Daniel Hellstrom
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Hellstrom @ 2011-05-11 7:18 UTC (permalink / raw)
To: sparclinux
Matthias Rosenfelder wrote:
> The function leon_flush_needed() is called only during bootup
> from another __init function. Therefore, we can add
> __init to leon_flush_needed().
>
> Signed-off-by: Matthias Rosenfelder <rosenfelder.lkml@googlemail.com>
> ---
> arch/sparc/mm/leon_mm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/sparc/mm/leon_mm.c b/arch/sparc/mm/leon_mm.c
> index c0e0129..e485a68 100644
> --- a/arch/sparc/mm/leon_mm.c
> +++ b/arch/sparc/mm/leon_mm.c
> @@ -226,7 +226,7 @@ void leon3_getCacheRegs(struct leon3_cacheregs *regs)
> * Leon2 and Leon3 differ in their way of telling cache information
> *
> */
> -int leon_flush_needed(void)
> +int __init leon_flush_needed(void)
> {
> int flush_needed = -1;
> unsigned int ssize, sets;
> --
> 1.6.4.2
>
Please change to the standard commit message format: "sparc32,leon: "
instead of sparc32/LEON. Otherwise it looks good,
Acked-by: Daniel Hellstrom <daniel@gaisler.com>
Thanks,
Daniel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-11 7:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-10 23:53 [PATCH] sparc32/LEON: Added __init declaration to leon_flush_needed() Matthias Rosenfelder
2011-05-11 7:18 ` Daniel Hellstrom
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.