From: Tom Rini <tom_rini@mentor.com>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Martin Jansa <martin.jansa@gmail.com>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>,
"poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: RFC: create-pull-request / send-pull-request updates
Date: Wed, 11 May 2011 11:35:26 -0700 [thread overview]
Message-ID: <4DCAD6EE.5050609@mentor.com> (raw)
In-Reply-To: <4DCAB609.8030601@linux.intel.com>
On 05/11/2011 09:15 AM, Darren Hart wrote:
> Between myself and others, there are several outstanding proposals to
> modify the pull-request scripts. Patches have been sent, but nothing has
> been merged due to a lack of consensus. I thought I would summarize what
> I see to be the current weaknesses of the scripts and my proposal to
> address them. I would like your feedback to ensure we have tools that
> meet the needs of a broad user base. Once we agree, I'll be happy to
> write up the patches or help review those written by others.
Thanks for taking this up!
[snip]
> 2) create-pull-request needs to facilitate the use of multiple
> repositories (Tom Rini)
So long as (a) it's supported and (b) it's easy to use, I'm fine with
however you want to implement it :) Which brings me to...
[snip]
> 3) Rewrite the scripts in python (Tom)
>
> While I agree that anything of any significant complexity is better
> written in python than bash, I feel that with the above changes, the
> current scripts will be smaller and remain simple enough for bash to
> be a viable option.
>
> I propose we leave the scripts in bash for the time being, leaving
> the door open to rewrite them at a later date should their complexity
> increase to merit the effort.
To me, dealing with some sort of prefs file means non-bash. But if you
can figure out everything that's needed with a little bit of asking git
and a little bit of standard-shell-magic (which it sounds like you can),
yeah, keeping it in bash is fine.
--
Tom Rini
Mentor Graphics Corporation
WARNING: multiple messages have this Message-ID (diff)
From: Tom Rini <tom_rini@mentor.com>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>,
"poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: RFC: create-pull-request / send-pull-request updates
Date: Wed, 11 May 2011 11:35:26 -0700 [thread overview]
Message-ID: <4DCAD6EE.5050609@mentor.com> (raw)
In-Reply-To: <4DCAB609.8030601@linux.intel.com>
On 05/11/2011 09:15 AM, Darren Hart wrote:
> Between myself and others, there are several outstanding proposals to
> modify the pull-request scripts. Patches have been sent, but nothing has
> been merged due to a lack of consensus. I thought I would summarize what
> I see to be the current weaknesses of the scripts and my proposal to
> address them. I would like your feedback to ensure we have tools that
> meet the needs of a broad user base. Once we agree, I'll be happy to
> write up the patches or help review those written by others.
Thanks for taking this up!
[snip]
> 2) create-pull-request needs to facilitate the use of multiple
> repositories (Tom Rini)
So long as (a) it's supported and (b) it's easy to use, I'm fine with
however you want to implement it :) Which brings me to...
[snip]
> 3) Rewrite the scripts in python (Tom)
>
> While I agree that anything of any significant complexity is better
> written in python than bash, I feel that with the above changes, the
> current scripts will be smaller and remain simple enough for bash to
> be a viable option.
>
> I propose we leave the scripts in bash for the time being, leaving
> the door open to rewrite them at a later date should their complexity
> increase to merit the effort.
To me, dealing with some sort of prefs file means non-bash. But if you
can figure out everything that's needed with a little bit of asking git
and a little bit of standard-shell-magic (which it sounds like you can),
yeah, keeping it in bash is fine.
--
Tom Rini
Mentor Graphics Corporation
next prev parent reply other threads:[~2011-05-11 18:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 16:15 RFC: create-pull-request / send-pull-request updates Darren Hart
2011-05-11 16:15 ` Darren Hart
2011-05-11 16:22 ` [poky] " Koen Kooi
2011-05-11 16:22 ` Koen Kooi
2011-05-11 18:06 ` [poky] " Darren Hart
2011-05-11 18:06 ` Darren Hart
2011-05-11 17:01 ` Khem Raj
2011-05-11 17:01 ` Khem Raj
2011-05-11 17:40 ` Richard Purdie
2011-05-11 17:40 ` Richard Purdie
2011-05-11 18:24 ` Darren Hart
2011-05-11 18:24 ` Darren Hart
2011-05-12 2:43 ` Khem Raj
2011-05-12 2:43 ` Khem Raj
2011-05-11 18:35 ` Tom Rini [this message]
2011-05-11 18:35 ` Tom Rini
2011-05-12 0:49 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCAD6EE.5050609@mentor.com \
--to=tom_rini@mentor.com \
--cc=dvhart@linux.intel.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.