From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Ying Han <yinghan@google.com>, Michal Hocko <mhocko@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan.kim@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [rfc patch 1/6] memcg: remove unused retry signal from reclaim
Date: Thu, 12 May 2011 11:02:18 -0400 [thread overview]
Message-ID: <4DCBF67A.3060700@redhat.com> (raw)
In-Reply-To: <1305212038-15445-2-git-send-email-hannes@cmpxchg.org>
On 05/12/2011 10:53 AM, Johannes Weiner wrote:
> If the memcg reclaim code detects the target memcg below its limit it
> exits and returns a guaranteed non-zero value so that the charge is
> retried.
>
> Nowadays, the charge side checks the memcg limit itself and does not
> rely on this non-zero return value trick.
>
> This patch removes it. The reclaim code will now always return the
> true number of pages it reclaimed on its own.
>
> Signed-off-by: Johannes Weiner<hannes@cmpxchg.org>
Acked-by: Rik van Riel<riel@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Ying Han <yinghan@google.com>, Michal Hocko <mhocko@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan.kim@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [rfc patch 1/6] memcg: remove unused retry signal from reclaim
Date: Thu, 12 May 2011 11:02:18 -0400 [thread overview]
Message-ID: <4DCBF67A.3060700@redhat.com> (raw)
In-Reply-To: <1305212038-15445-2-git-send-email-hannes@cmpxchg.org>
On 05/12/2011 10:53 AM, Johannes Weiner wrote:
> If the memcg reclaim code detects the target memcg below its limit it
> exits and returns a guaranteed non-zero value so that the charge is
> retried.
>
> Nowadays, the charge side checks the memcg limit itself and does not
> rely on this non-zero return value trick.
>
> This patch removes it. The reclaim code will now always return the
> true number of pages it reclaimed on its own.
>
> Signed-off-by: Johannes Weiner<hannes@cmpxchg.org>
Acked-by: Rik van Riel<riel@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-12 15:38 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 14:53 [rfc patch 0/6] mm: memcg naturalization Johannes Weiner
2011-05-12 14:53 ` Johannes Weiner
2011-05-12 14:53 ` [rfc patch 1/6] memcg: remove unused retry signal from reclaim Johannes Weiner
2011-05-12 14:53 ` Johannes Weiner
2011-05-12 15:02 ` Rik van Riel [this message]
2011-05-12 15:02 ` Rik van Riel
2011-05-12 17:22 ` Ying Han
2011-05-12 23:44 ` KAMEZAWA Hiroyuki
2011-05-12 23:44 ` KAMEZAWA Hiroyuki
2011-05-13 9:23 ` Michal Hocko
2011-05-13 9:23 ` Michal Hocko
2011-05-12 14:53 ` [rfc patch 2/6] vmscan: make distinction between memcg reclaim and LRU list selection Johannes Weiner
2011-05-12 14:53 ` Johannes Weiner
2011-05-12 15:33 ` Rik van Riel
2011-05-12 15:33 ` Rik van Riel
2011-05-12 16:03 ` Johannes Weiner
2011-05-12 16:03 ` Johannes Weiner
2011-05-17 6:38 ` Ying Han
2011-05-17 6:38 ` Ying Han
2011-05-17 8:25 ` Johannes Weiner
2011-05-17 8:25 ` Johannes Weiner
2011-05-12 23:50 ` KAMEZAWA Hiroyuki
2011-05-12 23:50 ` KAMEZAWA Hiroyuki
2011-05-13 6:58 ` Johannes Weiner
2011-05-13 6:58 ` Johannes Weiner
2011-05-16 22:36 ` Andrew Morton
2011-05-16 22:36 ` Andrew Morton
2011-05-12 14:53 ` [rfc patch 3/6] mm: memcg-aware global reclaim Johannes Weiner
2011-05-12 14:53 ` Johannes Weiner
2011-05-12 16:04 ` Rik van Riel
2011-05-12 16:04 ` Rik van Riel
2011-05-12 19:19 ` Ying Han
2011-05-13 7:08 ` Johannes Weiner
2011-05-13 7:08 ` Johannes Weiner
2011-05-13 0:04 ` KAMEZAWA Hiroyuki
2011-05-13 0:04 ` KAMEZAWA Hiroyuki
2011-05-13 7:18 ` Johannes Weiner
2011-05-13 7:18 ` Johannes Weiner
2011-05-13 0:40 ` KAMEZAWA Hiroyuki
2011-05-13 0:40 ` KAMEZAWA Hiroyuki
2011-05-13 6:54 ` Johannes Weiner
2011-05-13 6:54 ` Johannes Weiner
2011-05-13 9:53 ` Michal Hocko
2011-05-13 9:53 ` Michal Hocko
2011-05-13 10:28 ` Johannes Weiner
2011-05-13 10:28 ` Johannes Weiner
2011-05-13 11:02 ` Michal Hocko
2011-05-13 11:02 ` Michal Hocko
2011-05-12 14:53 ` [rfc patch 4/6] memcg: reclaim statistics Johannes Weiner
2011-05-12 14:53 ` Johannes Weiner
2011-05-12 19:33 ` Ying Han
2011-05-16 23:10 ` Johannes Weiner
2011-05-16 23:10 ` Johannes Weiner
2011-05-17 0:20 ` Ying Han
2011-05-17 7:42 ` Johannes Weiner
2011-05-17 7:42 ` Johannes Weiner
2011-05-17 13:55 ` Rik van Riel
2011-05-17 13:55 ` Rik van Riel
2011-05-12 14:53 ` [rfc patch 5/6] memcg: remove global LRU list Johannes Weiner
2011-05-12 14:53 ` Johannes Weiner
2011-05-13 9:53 ` Michal Hocko
2011-05-13 9:53 ` Michal Hocko
2011-05-13 10:36 ` Johannes Weiner
2011-05-13 10:36 ` Johannes Weiner
2011-05-13 11:01 ` Michal Hocko
2011-05-13 11:01 ` Michal Hocko
2011-05-12 14:53 ` [rfc patch 6/6] memcg: rework soft limit reclaim Johannes Weiner
2011-05-12 14:53 ` Johannes Weiner
2011-05-12 18:41 ` Ying Han
2011-05-12 18:41 ` Ying Han
2011-05-12 18:53 ` [rfc patch 0/6] mm: memcg naturalization Ying Han
2011-05-13 7:20 ` Johannes Weiner
2011-05-13 7:20 ` Johannes Weiner
2011-05-17 0:53 ` Ying Han
2011-05-17 8:11 ` Johannes Weiner
2011-05-17 8:11 ` Johannes Weiner
2011-05-17 14:45 ` Ying Han
2011-05-16 10:30 ` Balbir Singh
2011-05-16 10:30 ` Balbir Singh
2011-05-16 10:57 ` Johannes Weiner
2011-05-16 10:57 ` Johannes Weiner
2011-05-17 6:32 ` Balbir Singh
2011-05-17 6:32 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCBF67A.3060700@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=minchan.kim@gmail.com \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.