From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Jonghwan Choi <jhbird.choi@samsung.com>,
ben-linux@fluff.org
Subject: Re: [PATCH] ARM: S5PV210: Fix possible null pointer dereference.
Date: Fri, 13 May 2011 15:43:54 +0400 [thread overview]
Message-ID: <4DCD197A.9020900@ru.mvista.com> (raw)
In-Reply-To: <1305270186-7722-1-git-send-email-kgene.kim@samsung.com>
Hello.
On 13-05-2011 11:03, Kukjin Kim wrote:
> From: Jonghwan Choi<jhbird.choi@samsung.com>
> Signed-off-by: Jonghwan Choi<jhbird.choi@samsung.com>
> Signed-off-by: Kukjin Kim<kgene.kim@samsung.com>
> ---
> arch/arm/mach-s5pv210/cpufreq.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
> diff --git a/arch/arm/mach-s5pv210/cpufreq.c b/arch/arm/mach-s5pv210/cpufreq.c
> index 22046e2..58340ee 100644
> --- a/arch/arm/mach-s5pv210/cpufreq.c
> +++ b/arch/arm/mach-s5pv210/cpufreq.c
> @@ -105,8 +105,10 @@ static void s5pv210_set_refresh(enum s5pv210_dmc_port ch, unsigned long freq)
> reg = (S5P_VA_DMC0 + 0x30);
> else if (ch == DMC1)
> reg = (S5P_VA_DMC1 + 0x30);
> - else
> + else {
> printk(KERN_ERR "Cannot find DMC port\n");
> + return;
> + }
According to CodingStyle, other branches should now have {} too.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S5PV210: Fix possible null pointer dereference.
Date: Fri, 13 May 2011 15:43:54 +0400 [thread overview]
Message-ID: <4DCD197A.9020900@ru.mvista.com> (raw)
In-Reply-To: <1305270186-7722-1-git-send-email-kgene.kim@samsung.com>
Hello.
On 13-05-2011 11:03, Kukjin Kim wrote:
> From: Jonghwan Choi<jhbird.choi@samsung.com>
> Signed-off-by: Jonghwan Choi<jhbird.choi@samsung.com>
> Signed-off-by: Kukjin Kim<kgene.kim@samsung.com>
> ---
> arch/arm/mach-s5pv210/cpufreq.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
> diff --git a/arch/arm/mach-s5pv210/cpufreq.c b/arch/arm/mach-s5pv210/cpufreq.c
> index 22046e2..58340ee 100644
> --- a/arch/arm/mach-s5pv210/cpufreq.c
> +++ b/arch/arm/mach-s5pv210/cpufreq.c
> @@ -105,8 +105,10 @@ static void s5pv210_set_refresh(enum s5pv210_dmc_port ch, unsigned long freq)
> reg = (S5P_VA_DMC0 + 0x30);
> else if (ch == DMC1)
> reg = (S5P_VA_DMC1 + 0x30);
> - else
> + else {
> printk(KERN_ERR "Cannot find DMC port\n");
> + return;
> + }
According to CodingStyle, other branches should now have {} too.
WBR, Sergei
next prev parent reply other threads:[~2011-05-13 11:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 7:03 [PATCH] ARM: S5PV210: Fix possible null pointer dereference Kukjin Kim
2011-05-13 7:03 ` Kukjin Kim
2011-05-13 11:43 ` Sergei Shtylyov [this message]
2011-05-13 11:43 ` Sergei Shtylyov
2011-05-16 4:56 ` Kukjin Kim
2011-05-16 4:56 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCD197A.9020900@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=ben-linux@fluff.org \
--cc=jhbird.choi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.