[PATCH resend] Kernel command line options for runqemu

[PATCH resend] Kernel command line options for runqemu

[Gary Thomas]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

This patch lets the user add options to the kernel command line when
started via runqemu.  Very useful for things like 'psplash=false'

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

[-- Attachment #2: 0001-runqemu-allow-kernel-command-line-options-to-be-spec.patch --]
[-- Type: text/x-patch, Size: 692 bytes --]

From eaeb894f1bd4b769ec05c28cca4e31f334339261 Mon Sep 17 00:00:00 2001
From: Gary Thomas <gary@mlbassoc.com>
Date: Mon, 16 May 2011 05:29:24 -0600
Subject: [PATCH] runqemu: allow kernel command line options to be specified by user

Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
 scripts/runqemu |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/runqemu b/scripts/runqemu
index a09362c..2c3f6f4 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -51,7 +51,7 @@ ROOTFS=""
 LAZY_ROOTFS=""
 SCRIPT_QEMU_OPT=""
 SCRIPT_QEMU_EXTRA_OPT=""
-SCRIPT_KERNEL_OPT=""
+SCRIPT_KERNEL_OPT=${SCRIPT_KERNEL_OPT:-""}
 
 TMPDIR=""
 
-- 
1.7.3.4

Re: [PATCH resend] Kernel command line options for runqemu

[Saul Wold]

On 05/16/2011 04:32 AM, Gary Thomas wrote:
> This patch lets the user add options to the kernel command line when
> started via runqemu. Very useful for things like 'psplash=false'
>
>
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky

Gary,

This is a reasonable idea, but it exposes an internal variable that 
might change in the future, so am I hesitant to take this.

Sau!

Re: [PATCH resend] Kernel command line options for runqemu

[Gary Thomas]

On 05/16/2011 10:35 AM, Saul Wold wrote:
> On 05/16/2011 04:32 AM, Gary Thomas wrote:
>> This patch lets the user add options to the kernel command line when
>> started via runqemu. Very useful for things like 'psplash=false'
>>
>>
>>
>> _______________________________________________
>> poky mailing list
>> poky@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/poky
>
> Gary,
>
> This is a reasonable idea, but it exposes an internal variable that might change in the future, so am I hesitant to take this.

Without it, the only way to change the kernel command line is by
editing the script, which doesn't seem very friendly.

Would you feel better if it were a special variable, just for
this purpose, which is by default empty?  I was just using the
infrastructure that was already in place.

Thanks

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [PATCH resend] Kernel command line options for runqemu

[Scott Garman]

On 05/16/2011 09:49 AM, Gary Thomas wrote:
> On 05/16/2011 10:35 AM, Saul Wold wrote:
>> On 05/16/2011 04:32 AM, Gary Thomas wrote:
>>> This patch lets the user add options to the kernel command line when
>>> started via runqemu. Very useful for things like 'psplash=false'
>>>
>>>
>>>
>>> _______________________________________________
>>> poky mailing list
>>> poky@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/poky
>>
>> Gary,
>>
>> This is a reasonable idea, but it exposes an internal variable that
>> might change in the future, so am I hesitant to take this.
>
> Without it, the only way to change the kernel command line is by
> editing the script, which doesn't seem very friendly.
>
> Would you feel better if it were a special variable, just for
> this purpose, which is by default empty? I was just using the
> infrastructure that was already in place.

Hi Gary,

I believe this is being tracked with bug #1019:

http://bugzilla.pokylinux.org/show_bug.cgi?id=1019

I do not have an ETA on this except for "before 1.1". Your workaround 
could be used in the meantime.

I haven't given any thought to creating an environment variable "API" to 
the script, so I'm not comfortable taking the patch currently.

As a temporary workaround, you could use the patch locally.

Scott

-- 
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center