From: Fabien Marteau <fabien.marteau@armadeus.com>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: "khali@linux-fr.org" <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: Driver for as1531,
Date: Tue, 17 May 2011 07:06:06 +0000 [thread overview]
Message-ID: <4DD21E5E.9000605@armadeus.com> (raw)
In-Reply-To: <20110516153900.GA31255@ericsson.com>
Hi Guenter,
Thanks for the review.
On 16/05/2011 17:39, Guenter Roeck wrote:
> On Mon, May 16, 2011 at 09:39:14AM -0400, fabien.marteau@armadeus.com wrote:
>> From: Fabien Marteau <fabien.marteau@armadeus.com>
>>
>>
> Some description, such as "Dhis driver adds support for xxx" would be nice.
>
> Also, I wonder if this driver belongs into hwmon in the first place. It is
> a generic ADC chip with high conversion rate. iio would probably be more
> appropriate and also much better in supporting high speed readings.
I provided this driver "as is" because it's a driver that work well on
our platform. I thought that iio was not stable enough driver framework
to be used.
I can rewrite it under iio framework but I have no time for this moment
to do that. You think it's better to wait for an iio driver or to
continue commiting this ?
regards,
Fabien M
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Fabien Marteau <fabien.marteau@armadeus.com>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: "khali@linux-fr.org" <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon: Driver for as1531, Austria-Microsystem Analog to Digital Converter.
Date: Tue, 17 May 2011 09:06:06 +0200 [thread overview]
Message-ID: <4DD21E5E.9000605@armadeus.com> (raw)
In-Reply-To: <20110516153900.GA31255@ericsson.com>
Hi Guenter,
Thanks for the review.
On 16/05/2011 17:39, Guenter Roeck wrote:
> On Mon, May 16, 2011 at 09:39:14AM -0400, fabien.marteau@armadeus.com wrote:
>> From: Fabien Marteau <fabien.marteau@armadeus.com>
>>
>>
> Some description, such as "Dhis driver adds support for xxx" would be nice.
>
> Also, I wonder if this driver belongs into hwmon in the first place. It is
> a generic ADC chip with high conversion rate. iio would probably be more
> appropriate and also much better in supporting high speed readings.
I provided this driver "as is" because it's a driver that work well on
our platform. I thought that iio was not stable enough driver framework
to be used.
I can rewrite it under iio framework but I have no time for this moment
to do that. You think it's better to wait for an iio driver or to
continue commiting this ?
regards,
Fabien M
next prev parent reply other threads:[~2011-05-17 7:06 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 13:39 [lm-sensors] [PATCH] hwmon: Driver for as1531, fabien.marteau
2011-05-16 13:39 ` [PATCH] hwmon: Driver for as1531, Austria-Microsystem Analog to Digital Converter fabien.marteau
2011-05-16 15:01 ` [lm-sensors] [PATCH] hwmon: Driver for as1531, Randy Dunlap
2011-05-16 15:01 ` [PATCH] hwmon: Driver for as1531, Austria-Microsystem Analog to Digital Converter Randy Dunlap
2011-05-16 15:39 ` [lm-sensors] [PATCH] hwmon: Driver for as1531, Guenter Roeck
2011-05-16 15:39 ` [PATCH] hwmon: Driver for as1531, Austria-Microsystem Analog to Digital Converter Guenter Roeck
2011-05-17 7:06 ` Fabien Marteau [this message]
2011-05-17 7:06 ` Fabien Marteau
2011-05-17 9:25 ` [lm-sensors] [PATCH] hwmon: Driver for as1531, Jonathan Cameron
2011-05-17 9:25 ` [PATCH] hwmon: Driver for as1531, Austria-Microsystem Analog to Digital Converter Jonathan Cameron
2011-05-17 9:34 ` [lm-sensors] [PATCH] hwmon: Driver for as1531, Jonathan Cameron
2011-05-17 9:34 ` [PATCH] hwmon: Driver for as1531, Austria-Microsystem Analog to Digital Converter Jonathan Cameron
2011-05-17 11:59 ` [lm-sensors] [PATCH] hwmon: Driver for as1531, Fabien Marteau
2011-05-17 11:59 ` [PATCH] hwmon: Driver for as1531, Austria-Microsystem Analog to Digital Converter Fabien Marteau
2011-05-18 15:39 ` [PATCH 0/2] staging:iio:adc:as1531 driver port from hwmon driver Jonathan Cameron
2011-05-18 15:39 ` [lm-sensors] [PATCH 0/2] staging:iio:adc:as1531 driver port from Jonathan Cameron
2011-05-18 16:16 ` [PATCH V2 0/2] staging:iio:adc:as1531 driver port from hwmon driver Jonathan Cameron
2011-05-18 16:16 ` [lm-sensors] [PATCH V2 0/2] staging:iio:adc:as1531 driver port from Jonathan Cameron
2011-05-18 17:01 ` [PATCH V2 0/2] staging:iio:adc:as1531 driver port from hwmon driver Fabien Marteau
2011-05-18 17:01 ` [lm-sensors] [PATCH V2 0/2] staging:iio:adc:as1531 driver port Fabien Marteau
2011-05-18 16:16 ` [PATCH 1/2] staging:iio:adc: as1531 driver initial conversion from hwmon submission Jonathan Cameron
2011-05-18 16:16 ` [lm-sensors] [PATCH 1/2] staging:iio:adc: as1 Jonathan Cameron
2011-05-18 16:37 ` [PATCH 1/2] staging:iio:adc: as1531 driver initial conversion from hwmon submission Guenter Roeck
2011-05-18 16:37 ` [lm-sensors] [PATCH 1/2] staging:iio:adc: as1531 driver initial Guenter Roeck
2011-05-18 16:17 ` [PATCH 2/2] staging:iio:adc:as1351 general cleanup and conversion to standard functions Jonathan Cameron
2011-05-18 16:17 ` [lm-sensors] [PATCH 2/2] staging:iio:adc:as1351 general cleanup and Jonathan Cameron
2011-05-18 16:35 ` [PATCH 2/2] staging:iio:adc:as1351 general cleanup and conversion to standard functions Guenter Roeck
2011-05-18 16:35 ` [lm-sensors] [PATCH 2/2] staging:iio:adc:as1351 general cleanup Guenter Roeck
2011-05-19 8:42 ` [PATCH 2/2] staging:iio:adc:as1351 general cleanup and conversion to standard functions Jonathan Cameron
2011-05-19 8:42 ` [lm-sensors] [PATCH 2/2] staging:iio:adc:as1351 general cleanup Jonathan Cameron
2011-05-18 15:39 ` [PATCH 1/2] staging:iio:adc: as1531 driver initial conversion from hwmon submission Jonathan Cameron
2011-05-18 15:39 ` [lm-sensors] [PATCH 1/2] staging:iio:adc: as1 Jonathan Cameron
2011-05-18 16:02 ` [PATCH 1/2] staging:iio:adc: as1531 driver initial conversion from hwmon submission Guenter Roeck
2011-05-18 16:02 ` [lm-sensors] [PATCH 1/2] staging:iio:adc: as1531 driver initial Guenter Roeck
2011-05-18 16:12 ` [PATCH 1/2] staging:iio:adc: as1531 driver initial conversion from hwmon submission Jonathan Cameron
2011-05-18 16:12 ` [lm-sensors] [PATCH 1/2] staging:iio:adc: as1531 driver initial Jonathan Cameron
2011-05-18 15:39 ` [PATCH 2/2] staging:iio:adc:as1351 general cleanup and conversion to standard functions Jonathan Cameron
2011-05-18 15:39 ` [lm-sensors] [PATCH 2/2] staging:iio:adc:as1351 general cleanup and Jonathan Cameron
2011-05-18 15:57 ` [PATCH 2/2] staging:iio:adc:as1351 general cleanup and conversion to standard functions Guenter Roeck
2011-05-18 15:57 ` [lm-sensors] [PATCH 2/2] staging:iio:adc:as1351 general cleanup Guenter Roeck
2011-05-17 13:38 ` [lm-sensors] [PATCH] hwmon: Driver for as1531, Guenter Roeck
2011-05-17 13:38 ` [PATCH] hwmon: Driver for as1531, Austria-Microsystem Analog to Digital Converter Guenter Roeck
2011-05-18 13:09 ` [lm-sensors] [PATCH] hwmon: Driver for as1531, Jonathan Cameron
2011-05-18 13:09 ` [PATCH] hwmon: Driver for as1531, Austria-Microsystem Analog to Digital Converter Jonathan Cameron
2011-05-18 15:05 ` [lm-sensors] [PATCH] hwmon: Driver for as1531, Jonathan Cameron
2011-05-18 15:05 ` [PATCH] hwmon: Driver for as1531, Austria-Microsystem Analog to Digital Converter Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2011-05-16 13:39 [lm-sensors] [PATCH] hwmon: Driver for as1531, fabien.marteau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD21E5E.9000605@armadeus.com \
--to=fabien.marteau@armadeus.com \
--cc=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.