From: Timur Tabi <timur@freescale.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: kumar.gala@freescale.com, benh@kernel.crashing.org,
greg@kroah.com, akpm@kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-console@vger.kernel.org
Subject: Re: [PATCH 6/7] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver
Date: Thu, 19 May 2011 11:05:49 -0500 [thread overview]
Message-ID: <4DD53FDD.7070503@freescale.com> (raw)
In-Reply-To: <20110519153358.5876f310@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>> > + /* Pass the received data to the tty layer. Note that this
>> > + * function calls tty_buffer_request_room(), so I'm not sure if
>> > + * we should have also called tty_buffer_request_room().
>> > + */
>> > + ret = tty_insert_flip_string(ttys, buffer, len);
> You only need to request_room in advance if you can't handle the case
> where the insert_flip_string returns less than you stuffed down it.
If tty_insert_flip_string() returns less than I stuffed down it, the characters
it didn't accept will be dropped. That's because once I receive them, I have
nowhere else to put them. I suppose I could implement a receive FIFO, but that
seems overkill. If calling tty_buffer_request_room() ensures that
tty_insert_flip_string() always accepts all the characters, I would rather do that.
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@freescale.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: kumar.gala@freescale.com, linux-kernel@vger.kernel.org,
akpm@kernel.org, linux-console@vger.kernel.org, greg@kroah.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 6/7] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver
Date: Thu, 19 May 2011 11:05:49 -0500 [thread overview]
Message-ID: <4DD53FDD.7070503@freescale.com> (raw)
In-Reply-To: <20110519153358.5876f310@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>> > + /* Pass the received data to the tty layer. Note that this
>> > + * function calls tty_buffer_request_room(), so I'm not sure if
>> > + * we should have also called tty_buffer_request_room().
>> > + */
>> > + ret = tty_insert_flip_string(ttys, buffer, len);
> You only need to request_room in advance if you can't handle the case
> where the insert_flip_string returns less than you stuffed down it.
If tty_insert_flip_string() returns less than I stuffed down it, the characters
it didn't accept will be dropped. That's because once I receive them, I have
nowhere else to put them. I suppose I could implement a receive FIFO, but that
seems overkill. If calling tty_buffer_request_room() ensures that
tty_insert_flip_string() always accepts all the characters, I would rather do that.
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@freescale.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: <kumar.gala@freescale.com>, <benh@kernel.crashing.org>,
<greg@kroah.com>, <akpm@kernel.org>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
<linux-console@vger.kernel.org>
Subject: Re: [PATCH 6/7] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver
Date: Thu, 19 May 2011 11:05:49 -0500 [thread overview]
Message-ID: <4DD53FDD.7070503@freescale.com> (raw)
In-Reply-To: <20110519153358.5876f310@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>> > + /* Pass the received data to the tty layer. Note that this
>> > + * function calls tty_buffer_request_room(), so I'm not sure if
>> > + * we should have also called tty_buffer_request_room().
>> > + */
>> > + ret = tty_insert_flip_string(ttys, buffer, len);
> You only need to request_room in advance if you can't handle the case
> where the insert_flip_string returns less than you stuffed down it.
If tty_insert_flip_string() returns less than I stuffed down it, the characters
it didn't accept will be dropped. That's because once I receive them, I have
nowhere else to put them. I suppose I could implement a receive FIFO, but that
seems overkill. If calling tty_buffer_request_room() ensures that
tty_insert_flip_string() always accepts all the characters, I would rather do that.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-05-19 16:05 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 13:54 [PATCH 0/7] This patchset adds support for running Linux under the Freescale hypervisor, Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-05-19 13:54 ` [PATCH 1/7] powerpc: make irq_choose_cpu() available to all PIC drivers Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-05-19 13:54 ` [PATCH 2/7] powerpc: introduce ePAPR embedded hypervisor hcall interface Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-05-19 13:54 ` [PATCH 3/7] powerpc: introduce the ePAPR embedded hypervisor vmpic driver Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-05-19 13:54 ` [PATCH 4/7] powerpc: add Freescale hypervisor partition control functions Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-05-19 13:54 ` [PATCH 5/7] powerpc/85xx: add board support for the Freescale hypervisor Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-06-22 11:42 ` Kumar Gala
2011-06-22 11:42 ` Kumar Gala
2011-06-22 11:42 ` Kumar Gala
2011-05-19 13:54 ` [PATCH 6/7] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-05-19 14:22 ` Greg KH
2011-05-19 14:22 ` Greg KH
2011-05-19 14:27 ` Timur Tabi
2011-05-19 14:27 ` Timur Tabi
2011-05-19 14:27 ` Timur Tabi
2011-05-19 14:36 ` Alan Cox
2011-05-19 14:36 ` Alan Cox
2011-05-19 14:33 ` Alan Cox
2011-05-19 14:33 ` Alan Cox
2011-05-19 14:33 ` Alan Cox
2011-05-19 15:14 ` Timur Tabi
2011-05-19 15:14 ` Timur Tabi
2011-05-19 15:14 ` Timur Tabi
2011-05-19 15:50 ` Alan Cox
2011-05-19 15:50 ` Alan Cox
2011-05-19 15:50 ` Alan Cox
2011-05-19 15:54 ` Timur Tabi
2011-05-19 15:54 ` Timur Tabi
2011-05-19 15:54 ` Timur Tabi
2011-05-19 16:00 ` Alan Cox
2011-05-19 16:00 ` Alan Cox
2011-05-19 16:00 ` Alan Cox
2011-05-19 16:02 ` Greg KH
2011-05-19 16:02 ` Greg KH
2011-05-19 16:18 ` Timur Tabi
2011-05-19 16:18 ` Timur Tabi
2011-05-19 16:18 ` Timur Tabi
2011-05-19 16:05 ` Timur Tabi [this message]
2011-05-19 16:05 ` Timur Tabi
2011-05-19 16:05 ` Timur Tabi
2011-05-20 9:54 ` Alan Cox
2011-05-20 9:54 ` Alan Cox
2011-05-20 9:54 ` Alan Cox
2011-05-19 16:31 ` Timur Tabi
2011-05-19 16:31 ` Timur Tabi
2011-05-19 16:31 ` Timur Tabi
2011-05-19 17:25 ` Alan Cox
2011-05-19 17:25 ` Alan Cox
2011-05-19 17:25 ` Alan Cox
2011-05-19 15:02 ` Arnd Bergmann
2011-05-19 15:02 ` Arnd Bergmann
2011-05-19 15:09 ` Timur Tabi
2011-05-19 15:09 ` Timur Tabi
2011-05-19 15:09 ` Timur Tabi
2011-05-19 13:54 ` [PATCH 7/7] drivers/misc: introduce Freescale hypervisor management driver Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-05-19 13:56 ` [PATCH 0/7] This patchset adds support for running Linux under the Freescale hypervisor, Timur Tabi
2011-05-19 13:56 ` Timur Tabi
2011-05-20 20:29 ` Kumar Gala
2011-05-20 20:29 ` Kumar Gala
2011-05-20 20:29 ` Kumar Gala
2011-05-23 21:09 ` Tabi Timur-B04825
2011-05-23 21:09 ` Tabi Timur-B04825
2011-05-23 21:09 ` Tabi Timur-B04825
2011-05-23 22:27 ` Kumar Gala
2011-05-23 22:27 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD53FDD.7070503@freescale.com \
--to=timur@freescale.com \
--cc=akpm@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=kumar.gala@freescale.com \
--cc=linux-console@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.