From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: John W Linville <linville@tuxdriver.com>,
b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: [PATCH] b43: Fix bogus compilation warning for phy_n
Date: Thu, 19 May 2011 17:48:10 -0500 [thread overview]
Message-ID: <4DD59E2A.4070405@lwfinger.net> (raw)
In-Reply-To: <BANLkTi=P-uCzunSyjf2ziX6BaCyq9Muj+g@mail.gmail.com>
On 05/19/2011 05:40 PM, Rafa? Mi?ecki wrote:
>
> I should have describe where I can see the problem.
>
> If error is other than 0 (it can be as the result of "error =
> b43_nphy_tx_tone(dev, freq, 250, true, false);"), then "last" won't be
> set in 3256. In 3300 we use "last", no matter what "error" is.
You are correct. I missed the level of indent in line 3256. What initialization
should be used for last? It clearly needs to be set to something.
John: Please drop my patch. I'll let Rafa? fix it.
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: John W Linville <linville@tuxdriver.com>,
b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43: Fix bogus compilation warning for phy_n
Date: Thu, 19 May 2011 17:48:10 -0500 [thread overview]
Message-ID: <4DD59E2A.4070405@lwfinger.net> (raw)
In-Reply-To: <BANLkTi=P-uCzunSyjf2ziX6BaCyq9Muj+g@mail.gmail.com>
On 05/19/2011 05:40 PM, Rafał Miłecki wrote:
>
> I should have describe where I can see the problem.
>
> If error is other than 0 (it can be as the result of "error =
> b43_nphy_tx_tone(dev, freq, 250, true, false);"), then "last" won't be
> set in 3256. In 3300 we use "last", no matter what "error" is.
You are correct. I missed the level of indent in line 3256. What initialization
should be used for last? It clearly needs to be set to something.
John: Please drop my patch. I'll let Rafał fix it.
Larry
next prev parent reply other threads:[~2011-05-19 22:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 21:35 [PATCH] b43: Fix bogus compilation warning for phy_n Larry Finger
2011-05-19 21:35 ` Larry Finger
2011-05-19 21:43 ` Rafał Miłecki
2011-05-19 21:43 ` Rafał Miłecki
2011-05-19 22:12 ` Larry Finger
2011-05-19 22:12 ` Larry Finger
2011-05-19 22:40 ` Rafał Miłecki
2011-05-19 22:40 ` Rafał Miłecki
2011-05-19 22:48 ` Larry Finger [this message]
2011-05-19 22:48 ` Larry Finger
2011-05-19 22:59 ` Rafał Miłecki
2011-05-19 22:59 ` Rafał Miłecki
2011-05-19 23:07 ` Larry Finger
2011-05-19 23:07 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD59E2A.4070405@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.