From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: spitz pm: adjust messages
Date: Sun, 22 May 2011 16:42:30 +0400 [thread overview]
Message-ID: <4DD904B6.4010700@ru.mvista.com> (raw)
In-Reply-To: <20110521122450.GA6954@elf.ucw.cz>
Hello.
On 21-05-2011 16:24, Pavel Machek wrote:
> Charger error is something that should be reported to the syslog; do
> it. If temperature reading fails, we do not want to charge the
> battery, anyway.
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> diff --git a/arch/arm/mach-pxa/sharpsl_pm.c b/arch/arm/mach-pxa/sharpsl_pm.c
> index 785880f..513588c 100644
> --- a/arch/arm/mach-pxa/sharpsl_pm.c
> +++ b/arch/arm/mach-pxa/sharpsl_pm.c
[...]
> @@ -513,8 +500,10 @@ static int sharpsl_check_battery_temp(void)
> val = get_select_val(buff);
>
> dev_dbg(sharpsl_pm.dev, "Temperature: %d\n", val);
> - if (val> sharpsl_pm.machinfo->charge_on_temp) {
> - printk(KERN_WARNING "Not charging: temperature out of limits.\n");
> + /* FIXME: this should catch battery read errors, but we should
> + probably avoid charging in<0C temperatures, too. */
The preferred style of the multi-line comments is this:
/*
* bla
* bla
*/
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: rpurdie@rpsys.net, lenz@cs.wisc.edu,
kernel list <linux-kernel@vger.kernel.org>,
arminlitzel@web.de, Cyril Hrubis <metan@ucw.cz>,
thommycheck@gmail.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
dbaryshkov@gmail.com, omegamoon@gmail.com, eric.y.miao@gmail.com,
utx@penguin.cz, zaurus-devel@www.linuxtogo.org,
Marek Vasut <marek.vasut@gmail.com>
Subject: Re: spitz pm: adjust messages
Date: Sun, 22 May 2011 16:42:30 +0400 [thread overview]
Message-ID: <4DD904B6.4010700@ru.mvista.com> (raw)
In-Reply-To: <20110521122450.GA6954@elf.ucw.cz>
Hello.
On 21-05-2011 16:24, Pavel Machek wrote:
> Charger error is something that should be reported to the syslog; do
> it. If temperature reading fails, we do not want to charge the
> battery, anyway.
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> diff --git a/arch/arm/mach-pxa/sharpsl_pm.c b/arch/arm/mach-pxa/sharpsl_pm.c
> index 785880f..513588c 100644
> --- a/arch/arm/mach-pxa/sharpsl_pm.c
> +++ b/arch/arm/mach-pxa/sharpsl_pm.c
[...]
> @@ -513,8 +500,10 @@ static int sharpsl_check_battery_temp(void)
> val = get_select_val(buff);
>
> dev_dbg(sharpsl_pm.dev, "Temperature: %d\n", val);
> - if (val> sharpsl_pm.machinfo->charge_on_temp) {
> - printk(KERN_WARNING "Not charging: temperature out of limits.\n");
> + /* FIXME: this should catch battery read errors, but we should
> + probably avoid charging in<0C temperatures, too. */
The preferred style of the multi-line comments is this:
/*
* bla
* bla
*/
WBR, Sergei
next prev parent reply other threads:[~2011-05-22 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 12:24 spitz pm: adjust messages Pavel Machek
2011-05-21 12:24 ` Pavel Machek
2011-05-21 17:27 ` Marek Vasut
2011-05-21 17:27 ` Marek Vasut
2011-05-22 12:42 ` Sergei Shtylyov [this message]
2011-05-22 12:42 ` Sergei Shtylyov
2011-05-26 13:49 ` Pavel Machek
2011-05-26 13:49 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD904B6.4010700@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.