From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp
Subject: Re: [PATCH] KVM: x86 emulator: Fix unconditional return from get_descriptor_table_ptr()
Date: Sun, 22 May 2011 15:57:10 +0300 [thread overview]
Message-ID: <4DD90826.9040806@redhat.com> (raw)
In-Reply-To: <20110521130639.d4615ee1.takuya.yoshikawa@gmail.com>
On 05/21/2011 07:06 AM, Takuya Yoshikawa wrote:
> From: Takuya Yoshikawa<yoshikawa.takuya@oss.ntt.co.jp>
>
> A trivial typo was found in the following commit:
> commit 7753ed6043bfce55dc0c407490896632014b677e
> KVM: x86 emulator: drop vcpu argument from segment/gdt/idt callbacks
>
> When the table indicator flag is set, when the selector selects the
> current LDT, get_descriptor_table_ptr() returns without setting the
> size and address of the table.
>
> Guests will see #GP if this happens.
>
Thanks, applied.
> Signed-off-by: Takuya Yoshikawa<yoshikawa.takuya@oss.ntt.co.jp>
> ---
> Is this stable material? -- IIRC, someone reported a suspicous
> emulator bug recently.
This was not yet merged upstream, so I folded this into the bad commit,
and upstream will never see the bug. It's now 4bff1e86ad286d in kvm.git.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2011-05-22 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 4:06 [PATCH] KVM: x86 emulator: Fix unconditional return from get_descriptor_table_ptr() Takuya Yoshikawa
2011-05-22 12:57 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD90826.9040806@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.