From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: kosaki.motohiro@jp.fujitsu.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
aarcange@redhat.com, akpm@linux-foundation.org,
n-horiguchi@ah.jp.nec.com, kamezawa.hiroyu@jp.fujitsu.com
Subject: [PATCH 1/4] pagewalk: Fix walk_page_range() don't check find_vma() result properly
Date: Wed, 25 May 2011 16:08:49 +0900 [thread overview]
Message-ID: <4DDCAB01.8080700@jp.fujitsu.com> (raw)
In-Reply-To: <4DDCAAC0.20102@jp.fujitsu.com>
The doc of find_vma() says,
/* Look up the first VMA which satisfies addr < vm_end, NULL if none. */
struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
{
(snip)
Thus, caller should confirm whether the returned vma matches a desired one.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/pagewalk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/pagewalk.c b/mm/pagewalk.c
index c3450d5..606bbb4 100644
--- a/mm/pagewalk.c
+++ b/mm/pagewalk.c
@@ -176,7 +176,7 @@ int walk_page_range(unsigned long addr, unsigned long end,
* we can't handled it in the same manner as non-huge pages.
*/
vma = find_vma(walk->mm, addr);
- if (vma && is_vm_hugetlb_page(vma)) {
+ if (vma && vma->vm_start <= addr && is_vm_hugetlb_page(vma)) {
if (vma->vm_end < next)
next = vma->vm_end;
/*
--
1.7.3.1
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: kosaki.motohiro@jp.fujitsu.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
aarcange@redhat.com, akpm@linux-foundation.org,
n-horiguchi@ah.jp.nec.com, kamezawa.hiroyu@jp.fujitsu.com
Subject: [PATCH 1/4] pagewalk: Fix walk_page_range() don't check find_vma() result properly
Date: Wed, 25 May 2011 16:08:49 +0900 [thread overview]
Message-ID: <4DDCAB01.8080700@jp.fujitsu.com> (raw)
In-Reply-To: <4DDCAAC0.20102@jp.fujitsu.com>
The doc of find_vma() says,
/* Look up the first VMA which satisfies addr < vm_end, NULL if none. */
struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
{
(snip)
Thus, caller should confirm whether the returned vma matches a desired one.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/pagewalk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/pagewalk.c b/mm/pagewalk.c
index c3450d5..606bbb4 100644
--- a/mm/pagewalk.c
+++ b/mm/pagewalk.c
@@ -176,7 +176,7 @@ int walk_page_range(unsigned long addr, unsigned long end,
* we can't handled it in the same manner as non-huge pages.
*/
vma = find_vma(walk->mm, addr);
- if (vma && is_vm_hugetlb_page(vma)) {
+ if (vma && vma->vm_start <= addr && is_vm_hugetlb_page(vma)) {
if (vma->vm_end < next)
next = vma->vm_end;
/*
--
1.7.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-25 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 7:07 [PATCH 0/4] fix pagewalk minor issues KOSAKI Motohiro
2011-05-25 7:07 ` KOSAKI Motohiro
2011-05-25 7:08 ` KOSAKI Motohiro [this message]
2011-05-25 7:08 ` [PATCH 1/4] pagewalk: Fix walk_page_range() don't check find_vma() result properly KOSAKI Motohiro
2011-05-25 7:09 ` [PATCH 2/4] pagewalk: don't look up vma if walk->hugetlb_entry is unused KOSAKI Motohiro
2011-05-25 7:09 ` KOSAKI Motohiro
2011-05-25 7:10 ` [PATCH 3/4] pagewalk: add locking-rule commnets KOSAKI Motohiro
2011-05-25 7:10 ` KOSAKI Motohiro
2011-05-25 7:11 ` [PATCH 4/4] pagewalk: fix code comment for THP KOSAKI Motohiro
2011-05-25 7:11 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDCAB01.8080700@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.