* [PATCH] set_migratetype_isolate: remove unused variable.
@ 2011-05-24 13:34 ` Luca Tettamanti
0 siblings, 0 replies; 10+ messages in thread
From: Luca Tettamanti @ 2011-05-24 13:34 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-mm
Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
---
mm/page_alloc.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 9d5498e..bcbdaf1 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5508,10 +5508,8 @@ int set_migratetype_isolate(struct page *page)
struct memory_isolate_notify arg;
int notifier_ret;
int ret = -EBUSY;
- int zone_idx;
zone = page_zone(page);
- zone_idx = zone_idx(zone);
spin_lock_irqsave(&zone->lock, flags);
--
1.7.5.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] set_migratetype_isolate: remove unused variable.
@ 2011-05-24 13:34 ` Luca Tettamanti
0 siblings, 0 replies; 10+ messages in thread
From: Luca Tettamanti @ 2011-05-24 13:34 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-mm
Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
---
mm/page_alloc.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 9d5498e..bcbdaf1 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5508,10 +5508,8 @@ int set_migratetype_isolate(struct page *page)
struct memory_isolate_notify arg;
int notifier_ret;
int ret = -EBUSY;
- int zone_idx;
zone = page_zone(page);
- zone_idx = zone_idx(zone);
spin_lock_irqsave(&zone->lock, flags);
--
1.7.5.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] set_migratetype_isolate: remove unused variable.
2011-05-24 13:34 ` Luca Tettamanti
@ 2011-05-24 22:29 ` Minchan Kim
-1 siblings, 0 replies; 10+ messages in thread
From: Minchan Kim @ 2011-05-24 22:29 UTC (permalink / raw)
To: Luca Tettamanti; +Cc: linux-kernel, linux-mm, Andrew Morton
On Tue, May 24, 2011 at 10:34 PM, Luca Tettamanti <kronos.it@gmail.com> wrote:
> Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
If it's trivial, please write log body down.
Anyway, nice catch.
Thanks.
--
Kind regards,
Minchan Kim
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] set_migratetype_isolate: remove unused variable.
@ 2011-05-24 22:29 ` Minchan Kim
0 siblings, 0 replies; 10+ messages in thread
From: Minchan Kim @ 2011-05-24 22:29 UTC (permalink / raw)
To: Luca Tettamanti; +Cc: linux-kernel, linux-mm, Andrew Morton
On Tue, May 24, 2011 at 10:34 PM, Luca Tettamanti <kronos.it@gmail.com> wrote:
> Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
If it's trivial, please write log body down.
Anyway, nice catch.
Thanks.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] set_migratetype_isolate: remove unused variable.
2011-05-24 22:29 ` Minchan Kim
@ 2011-05-25 7:28 ` Luca Tettamanti
-1 siblings, 0 replies; 10+ messages in thread
From: Luca Tettamanti @ 2011-05-25 7:28 UTC (permalink / raw)
To: Minchan Kim; +Cc: linux-kernel, linux-mm, Andrew Morton
On Wed, May 25, 2011 at 12:29 AM, Minchan Kim <minchan.kim@gmail.com> wrote:
> On Tue, May 24, 2011 at 10:34 PM, Luca Tettamanti <kronos.it@gmail.com> wrote:
>> Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
>
> If it's trivial, please write log body down.
Ok, I'll keep that in mind.
> Anyway, nice catch.
I'm cheating ;-)
I'm working with warnings generated by gcc-4.6 and - yes - I'm
screening false positives and compiling the patches :-)
Luca
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] set_migratetype_isolate: remove unused variable.
@ 2011-05-25 7:28 ` Luca Tettamanti
0 siblings, 0 replies; 10+ messages in thread
From: Luca Tettamanti @ 2011-05-25 7:28 UTC (permalink / raw)
To: Minchan Kim; +Cc: linux-kernel, linux-mm, Andrew Morton
On Wed, May 25, 2011 at 12:29 AM, Minchan Kim <minchan.kim@gmail.com> wrote:
> On Tue, May 24, 2011 at 10:34 PM, Luca Tettamanti <kronos.it@gmail.com> wrote:
>> Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
>
> If it's trivial, please write log body down.
Ok, I'll keep that in mind.
> Anyway, nice catch.
I'm cheating ;-)
I'm working with warnings generated by gcc-4.6 and - yes - I'm
screening false positives and compiling the patches :-)
Luca
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] set_migratetype_isolate: remove unused variable.
2011-05-25 7:28 ` Luca Tettamanti
@ 2011-05-25 7:36 ` KOSAKI Motohiro
-1 siblings, 0 replies; 10+ messages in thread
From: KOSAKI Motohiro @ 2011-05-25 7:36 UTC (permalink / raw)
To: kronos.it; +Cc: minchan.kim, linux-kernel, linux-mm, akpm
(2011/05/25 16:28), Luca Tettamanti wrote:
> On Wed, May 25, 2011 at 12:29 AM, Minchan Kim <minchan.kim@gmail.com> wrote:
>> On Tue, May 24, 2011 at 10:34 PM, Luca Tettamanti <kronos.it@gmail.com> wrote:
>>> Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
>> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
>>
>> If it's trivial, please write log body down.
>
> Ok, I'll keep that in mind.
If you fix zero patch description issue,
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Anyway, nice catch!
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] set_migratetype_isolate: remove unused variable.
@ 2011-05-25 7:36 ` KOSAKI Motohiro
0 siblings, 0 replies; 10+ messages in thread
From: KOSAKI Motohiro @ 2011-05-25 7:36 UTC (permalink / raw)
To: kronos.it; +Cc: minchan.kim, linux-kernel, linux-mm, akpm
(2011/05/25 16:28), Luca Tettamanti wrote:
> On Wed, May 25, 2011 at 12:29 AM, Minchan Kim <minchan.kim@gmail.com> wrote:
>> On Tue, May 24, 2011 at 10:34 PM, Luca Tettamanti <kronos.it@gmail.com> wrote:
>>> Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
>> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
>>
>> If it's trivial, please write log body down.
>
> Ok, I'll keep that in mind.
If you fix zero patch description issue,
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Anyway, nice catch!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] set_migratetype_isolate: remove unused variable.
2011-05-25 7:36 ` KOSAKI Motohiro
@ 2011-05-25 20:31 ` Luca Tettamanti
-1 siblings, 0 replies; 10+ messages in thread
From: Luca Tettamanti @ 2011-05-25 20:31 UTC (permalink / raw)
To: KOSAKI Motohiro; +Cc: minchan.kim, linux-kernel, linux-mm, akpm
zone_idx is never read inside the function.
Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/page_alloc.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 9d5498e..bcbdaf1 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5508,10 +5508,8 @@ int set_migratetype_isolate(struct page *page)
struct memory_isolate_notify arg;
int notifier_ret;
int ret = -EBUSY;
- int zone_idx;
zone = page_zone(page);
- zone_idx = zone_idx(zone);
spin_lock_irqsave(&zone->lock, flags);
--
1.7.5.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] set_migratetype_isolate: remove unused variable.
@ 2011-05-25 20:31 ` Luca Tettamanti
0 siblings, 0 replies; 10+ messages in thread
From: Luca Tettamanti @ 2011-05-25 20:31 UTC (permalink / raw)
To: KOSAKI Motohiro; +Cc: minchan.kim, linux-kernel, linux-mm, akpm
zone_idx is never read inside the function.
Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/page_alloc.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 9d5498e..bcbdaf1 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5508,10 +5508,8 @@ int set_migratetype_isolate(struct page *page)
struct memory_isolate_notify arg;
int notifier_ret;
int ret = -EBUSY;
- int zone_idx;
zone = page_zone(page);
- zone_idx = zone_idx(zone);
spin_lock_irqsave(&zone->lock, flags);
--
1.7.5.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-05-25 20:32 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-24 13:34 [PATCH] set_migratetype_isolate: remove unused variable Luca Tettamanti
2011-05-24 13:34 ` Luca Tettamanti
2011-05-24 22:29 ` Minchan Kim
2011-05-24 22:29 ` Minchan Kim
2011-05-25 7:28 ` Luca Tettamanti
2011-05-25 7:28 ` Luca Tettamanti
2011-05-25 7:36 ` KOSAKI Motohiro
2011-05-25 7:36 ` KOSAKI Motohiro
2011-05-25 20:31 ` [PATCH v2] " Luca Tettamanti
2011-05-25 20:31 ` Luca Tettamanti
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.