All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] regulator: Use _cansleep() for WM8994 regulator GPIOs
@ 2011-05-24 15:14 Mark Brown
  2011-05-25  9:48 ` Liam Girdwood
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2011-05-24 15:14 UTC (permalink / raw)
  To: Liam Girdwood; +Cc: linux-kernel, patches, Mark Brown

The WM8994 regulator driver is perfectly happy if the GPIO used to enable
the regulator sleeps so call the appropriate GPIO API.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/regulator/wm8994-regulator.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/wm8994-regulator.c b/drivers/regulator/wm8994-regulator.c
index 35b2958..1a6a690 100644
--- a/drivers/regulator/wm8994-regulator.c
+++ b/drivers/regulator/wm8994-regulator.c
@@ -43,7 +43,7 @@ static int wm8994_ldo_enable(struct regulator_dev *rdev)
 	if (!ldo->enable)
 		return 0;
 
-	gpio_set_value(ldo->enable, 1);
+	gpio_set_value_cansleep(ldo->enable, 1);
 	ldo->is_enabled = true;
 
 	return 0;
@@ -57,7 +57,7 @@ static int wm8994_ldo_disable(struct regulator_dev *rdev)
 	if (!ldo->enable)
 		return -EINVAL;
 
-	gpio_set_value(ldo->enable, 0);
+	gpio_set_value_cansleep(ldo->enable, 0);
 	ldo->is_enabled = false;
 
 	return 0;
-- 
1.7.5.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] regulator: Use _cansleep() for WM8994 regulator GPIOs
  2011-05-24 15:14 [PATCH] regulator: Use _cansleep() for WM8994 regulator GPIOs Mark Brown
@ 2011-05-25  9:48 ` Liam Girdwood
  0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2011-05-25  9:48 UTC (permalink / raw)
  To: Mark Brown
  Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com

On 24/05/11 16:14, Mark Brown wrote:
> The WM8994 regulator driver is perfectly happy if the GPIO used to enable
> the regulator sleeps so call the appropriate GPIO API.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  drivers/regulator/wm8994-regulator.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 

Applied.

Thanks

Liam

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-25  9:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-24 15:14 [PATCH] regulator: Use _cansleep() for WM8994 regulator GPIOs Mark Brown
2011-05-25  9:48 ` Liam Girdwood

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.