Re: [PATCH] wpa-gui-e: build the latest version from git sources

[Andreas Oberritter <obi@opendreambox.org>]

Hello Eyal,

thanks for your contribution. See some comments below:

On 05/25/2011 02:58 PM, Eyal Reizer wrote:
> Builds wpa-gui for qt4-embedded from the latest wpa-supplicant (0.8x)
> git sources
> 
> Signed-off-by: Eyal Reizer <eyalr@ti.com>
> ---
>  recipes/wpa-supplicant/wpa-gui-e_git.bb |   32 +++++++++++++++++++++++++++++++
>  1 files changed, 32 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/wpa-supplicant/wpa-gui-e_git.bb
> 
> diff --git a/recipes/wpa-supplicant/wpa-gui-e_git.bb b/recipes/wpa-supplicant/wpa-gui-e_git.bb
> new file mode 100644
> index 0000000..1c990c6
> --- /dev/null
> +++ b/recipes/wpa-supplicant/wpa-gui-e_git.bb
> @@ -0,0 +1,32 @@
> +DESCRIPTION = "Qt embedded interface for choosing which configured network \
> +to connect to. It also provides a method for browsing 802.11 SSID scan \
> +results, an event history log of messages generated by wpa_supplicant, and \
> +a method to add or edit wpa_supplicant networks."
> +SECTION = "network"
> +LICENSE = "GPL BSD"

Which GPL version?

> +HOMEPAGE = "http://hostap.epitest.fi/wpa_supplicant/"
> +RDEPENDS_${PN} = "wpa-supplicant"
> +RRECOMMENDS_${PN} = "glibc-gconv-utf-16"

What is this recommendation good for?

> +
> +SRCREV = "b8fb017272ed4794339978c9fbc0e74571a44728"
> +PR = "r0"

PR = "r0" is the default and can be removed.

> +PV = "0.7.3+0.8.0-rc"
> +PR_append = "+gitr${SRCPV}"

SRCPV should not be used in PR (even if it's been copied from another
recipe which does it wrong).

Regards,
Andreas

> +
> +DEFAULT_PREFERENCE = "-1"
> +
> +SRC_URI = "git://w1.fi/srv/git/hostap.git;protocol=git"
> +
> +S = "${WORKDIR}/git/wpa_supplicant/wpa_gui-qt4"
> +
> +inherit qt4e
> +ARM_INSTRUCTION_SET = "arm"
> +
> +do_install () {
> +       install -d ${D}${bindir}
> +       install -d ${D}${datadir}/wpa_gui
> +       install -d ${D}${datadir}/applications
> +       install -m 755 wpa_gui ${D}/${bindir}/wpa_gui-e
> +}
> +
> +