[PATCH] wpa-gui-e: build the latest version from git sources

[PATCH] wpa-gui-e: build the latest version from git sources

[Eyal Reizer]

Builds wpa-gui for qt4-embedded from the latest wpa-supplicant (0.8x)
git sources

Signed-off-by: Eyal Reizer <eyalr@ti.com>
---
 recipes/wpa-supplicant/wpa-gui-e_git.bb |   32 +++++++++++++++++++++++++++++++
 1 files changed, 32 insertions(+), 0 deletions(-)
 create mode 100644 recipes/wpa-supplicant/wpa-gui-e_git.bb

diff --git a/recipes/wpa-supplicant/wpa-gui-e_git.bb b/recipes/wpa-supplicant/wpa-gui-e_git.bb
new file mode 100644
index 0000000..1c990c6
--- /dev/null
+++ b/recipes/wpa-supplicant/wpa-gui-e_git.bb
@@ -0,0 +1,32 @@
+DESCRIPTION = "Qt embedded interface for choosing which configured network \
+to connect to. It also provides a method for browsing 802.11 SSID scan \
+results, an event history log of messages generated by wpa_supplicant, and \
+a method to add or edit wpa_supplicant networks."
+SECTION = "network"
+LICENSE = "GPL BSD"
+HOMEPAGE = "http://hostap.epitest.fi/wpa_supplicant/"
+RDEPENDS_${PN} = "wpa-supplicant"
+RRECOMMENDS_${PN} = "glibc-gconv-utf-16"
+
+SRCREV = "b8fb017272ed4794339978c9fbc0e74571a44728"
+PR = "r0"
+PV = "0.7.3+0.8.0-rc"
+PR_append = "+gitr${SRCPV}"
+
+DEFAULT_PREFERENCE = "-1"
+
+SRC_URI = "git://w1.fi/srv/git/hostap.git;protocol=git"
+
+S = "${WORKDIR}/git/wpa_supplicant/wpa_gui-qt4"
+
+inherit qt4e
+ARM_INSTRUCTION_SET = "arm"
+
+do_install () {
+       install -d ${D}${bindir}
+       install -d ${D}${datadir}/wpa_gui
+       install -d ${D}${datadir}/applications
+       install -m 755 wpa_gui ${D}/${bindir}/wpa_gui-e
+}
+
+
-- 
1.7.0.4

Re: [PATCH] wpa-gui-e: build the latest version from git sources

[Henning Heinold]

On Wed, May 25, 2011 at 03:58:57PM +0300, Eyal Reizer wrote:
> +       install -d ${D}${datadir}/wpa_gui
> +       install -d ${D}${datadir}/applications

Hi,

why are these dir's needed, when you don't install something
into it?

Bye Henning

Re: [PATCH] wpa-gui-e: build the latest version from git sources

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 2679 bytes --]

Dear Eyal,


please check your `git send-email` setup. Somehow it has the following
in the massage header

        In-Reply-To: <y>
        References: <y>

and your message from Wednesday (Wed, 18 May 2011 16:37:23 +0200) does
too.

        References: <y> <1305614722-5460-1-git-send-email-eyalr@ti.com>
        In-Reply-To: <1305614722-5460-1-git-send-email-eyalr@ti.com>

Therefore the threading gets messed up.

On Mi, 2011-05-25 at 15:58 +0300, Eyal Reizer wrote:
> Builds wpa-gui for qt4-embedded from the latest wpa-supplicant (0.8x)
> git sources

Which build configuration did you use for testing?

> Signed-off-by: Eyal Reizer <eyalr@ti.com>
> ---
>  recipes/wpa-supplicant/wpa-gui-e_git.bb |   32 +++++++++++++++++++++++++++++++
>  1 files changed, 32 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/wpa-supplicant/wpa-gui-e_git.bb
> 
> diff --git a/recipes/wpa-supplicant/wpa-gui-e_git.bb b/recipes/wpa-supplicant/wpa-gui-e_git.bb
> new file mode 100644
> index 0000000..1c990c6
> --- /dev/null
> +++ b/recipes/wpa-supplicant/wpa-gui-e_git.bb

The other recipes are named just `wpa-gui_….bb`. Why `-e` and not
`-qt4`?

> @@ -0,0 +1,32 @@
> +DESCRIPTION = "Qt embedded interface for choosing which configured network \
> +to connect to. It also provides a method for browsing 802.11 SSID scan \
> +results, an event history log of messages generated by wpa_supplicant, and \
> +a method to add or edit wpa_supplicant networks."
> +SECTION = "network"
> +LICENSE = "GPL BSD"
> +HOMEPAGE = "http://hostap.epitest.fi/wpa_supplicant/"
> +RDEPENDS_${PN} = "wpa-supplicant"
> +RRECOMMENDS_${PN} = "glibc-gconv-utf-16"

Please order the variables according to the style guide [1].

> +
> +SRCREV = "b8fb017272ed4794339978c9fbc0e74571a44728"
> +PR = "r0"
> +PV = "0.7.3+0.8.0-rc"
> +PR_append = "+gitr${SRCPV}"
> +
> +DEFAULT_PREFERENCE = "-1"

Since it is a new recipe name and not packaged yet and `PROVIDES` is not
set, I guess you can leave `DP = "-1"` out.

> +
> +SRC_URI = "git://w1.fi/srv/git/hostap.git;protocol=git"
> +
> +S = "${WORKDIR}/git/wpa_supplicant/wpa_gui-qt4"
> +
> +inherit qt4e
> +ARM_INSTRUCTION_SET = "arm"
> +
> +do_install () {
> +       install -d ${D}${bindir}
> +       install -d ${D}${datadir}/wpa_gui
> +       install -d ${D}${datadir}/applications
> +       install -m 755 wpa_gui ${D}/${bindir}/wpa_gui-e
> +}
> +
> +

You do not need the last two empty lines.

If you have some time you could create an include file and build test
and remove old `wpa-gui` versions.


Thanks,

Paul


[1] http://openembedded.org/index.php/Styleguide

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] wpa-gui-e: build the latest version from git sources

[Andreas Oberritter]

Hello Eyal,

thanks for your contribution. See some comments below:

On 05/25/2011 02:58 PM, Eyal Reizer wrote:
> Builds wpa-gui for qt4-embedded from the latest wpa-supplicant (0.8x)
> git sources
> 
> Signed-off-by: Eyal Reizer <eyalr@ti.com>
> ---
>  recipes/wpa-supplicant/wpa-gui-e_git.bb |   32 +++++++++++++++++++++++++++++++
>  1 files changed, 32 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/wpa-supplicant/wpa-gui-e_git.bb
> 
> diff --git a/recipes/wpa-supplicant/wpa-gui-e_git.bb b/recipes/wpa-supplicant/wpa-gui-e_git.bb
> new file mode 100644
> index 0000000..1c990c6
> --- /dev/null
> +++ b/recipes/wpa-supplicant/wpa-gui-e_git.bb
> @@ -0,0 +1,32 @@
> +DESCRIPTION = "Qt embedded interface for choosing which configured network \
> +to connect to. It also provides a method for browsing 802.11 SSID scan \
> +results, an event history log of messages generated by wpa_supplicant, and \
> +a method to add or edit wpa_supplicant networks."
> +SECTION = "network"
> +LICENSE = "GPL BSD"

Which GPL version?

> +HOMEPAGE = "http://hostap.epitest.fi/wpa_supplicant/"
> +RDEPENDS_${PN} = "wpa-supplicant"
> +RRECOMMENDS_${PN} = "glibc-gconv-utf-16"

What is this recommendation good for?

> +
> +SRCREV = "b8fb017272ed4794339978c9fbc0e74571a44728"
> +PR = "r0"

PR = "r0" is the default and can be removed.

> +PV = "0.7.3+0.8.0-rc"
> +PR_append = "+gitr${SRCPV}"

SRCPV should not be used in PR (even if it's been copied from another
recipe which does it wrong).

Regards,
Andreas

> +
> +DEFAULT_PREFERENCE = "-1"
> +
> +SRC_URI = "git://w1.fi/srv/git/hostap.git;protocol=git"
> +
> +S = "${WORKDIR}/git/wpa_supplicant/wpa_gui-qt4"
> +
> +inherit qt4e
> +ARM_INSTRUCTION_SET = "arm"
> +
> +do_install () {
> +       install -d ${D}${bindir}
> +       install -d ${D}${datadir}/wpa_gui
> +       install -d ${D}${datadir}/applications
> +       install -m 755 wpa_gui ${D}/${bindir}/wpa_gui-e
> +}
> +
> +

Re: [PATCH] wpa-gui-e: build the latest version from git sources

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]

Dear Andreas, dear Eyal,


On Mi, 2011-05-25 at 15:36 +0200, Andreas Oberritter wrote:

> On 05/25/2011 02:58 PM, Eyal Reizer wrote:

[…]

> > +SRCREV = "b8fb017272ed4794339978c9fbc0e74571a44728"
> > +PR = "r0"
> 
> PR = "r0" is the default and can be removed.

it seems there are different opinions on this topic. At least the manual
says differently.

        Note
        
        It is good practice to always define PR in your recipes, even
        for the "r0" release, so that when editing the recipe it is
        clear that the PR number needs to be updated.
        
        You should always increment PR when modifying a recipe.
        Sometimes this can be avoided if the change will have no effect
        on the actual packages generated by the recipe, such as updating
        the SRC_URI to point to a new host. If in any doubt then you
        should increase the PR regardless of what has been changed.
        
        The PR value should never be decremented. If you accidentally
        submit a large PR value for example then it should be left at
        the value and just increased for new releases, not reset back to
        a lower version.

> > +PV = "0.7.3+0.8.0-rc"
> > +PR_append = "+gitr${SRCPV}"
> 
> SRCPV should not be used in PR (even if it's been copied from another
> recipe which does it wrong).

I am still confused about this one. That is why I still have not
committed the pkg-config patch yet [2]. Could the right way be
documented in the manual.

[…]


Thanks,

Paul


[1] http://docs.openembedded.org/usermanual/usermanual.html#recipes_versioning
[2] http://patches.openembedded.org/patch/2711/

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] wpa-gui-e: build the latest version from git sources

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 25-05-11 16:03, Paul Menzel wrote:
> Dear Andreas, dear Eyal,
> 
> 
> On Mi, 2011-05-25 at 15:36 +0200, Andreas Oberritter wrote:
> 
>> On 05/25/2011 02:58 PM, Eyal Reizer wrote:
> 
> […]
> 
>>> +SRCREV = "b8fb017272ed4794339978c9fbc0e74571a44728"
>>> +PR = "r0"
>>
>> PR = "r0" is the default and can be removed.
> 
> it seems there are different opinions on this topic. At least the manual
> says differently.
> 
>         Note
>         
>         It is good practice to always define PR in your recipes, even
>         for the "r0" release, so that when editing the recipe it is
>         clear that the PR number needs to be updated.
>         
>         You should always increment PR when modifying a recipe.
>         Sometimes this can be avoided if the change will have no effect
>         on the actual packages generated by the recipe, such as updating
>         the SRC_URI to point to a new host. If in any doubt then you
>         should increase the PR regardless of what has been changed.
>         
>         The PR value should never be decremented. If you accidentally
>         submit a large PR value for example then it should be left at
>         the value and just increased for new releases, not reset back to
>         a lower version.
> 
>>> +PV = "0.7.3+0.8.0-rc"
>>> +PR_append = "+gitr${SRCPV}"
>>
>> SRCPV should not be used in PR (even if it's been copied from another
>> recipe which does it wrong).
> 
> I am still confused about this one. That is why I still have not
> committed the pkg-config patch yet [2]. Could the right way be
> documented in the manual.

It is completely OK to use it in PR if you want the hash in PR, but not PV.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFN3Q5dMkyGM64RGpERAhwhAKCKxo/HdbjYY90JHWbgtyiGCMwLFQCgiaRa
HB1AMRMFaS/r4+iF6S6wa5M=
=XI4d
-----END PGP SIGNATURE-----

Re: [PATCH] wpa-gui-e: build the latest version from git sources

[Reizer, Eyal]

Koen,

Do you mean that using SRCREV instead of SRCPV as below is ok, or should I also remove the PV = "..."?

+PV = "0.7.3+0.8.0-rc"
+PR_append = "+git${SRCREV}"

Best Regards,
Eyal



> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Koen Kooi
> Sent: Wednesday, May 25, 2011 5:13 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [PATCH] wpa-gui-e: build the latest version from git
> sources
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 25-05-11 16:03, Paul Menzel wrote:
> > Dear Andreas, dear Eyal,
> >
> >
> > On Mi, 2011-05-25 at 15:36 +0200, Andreas Oberritter wrote:
> >
> >> On 05/25/2011 02:58 PM, Eyal Reizer wrote:
> >
> > […]
> >
> >>> +SRCREV = "b8fb017272ed4794339978c9fbc0e74571a44728"
> >>> +PR = "r0"
> >>
> >> PR = "r0" is the default and can be removed.
> >
> > it seems there are different opinions on this topic. At least the
> manual
> > says differently.
> >
> >         Note
> >
> >         It is good practice to always define PR in your recipes, even
> >         for the "r0" release, so that when editing the recipe it is
> >         clear that the PR number needs to be updated.
> >
> >         You should always increment PR when modifying a recipe.
> >         Sometimes this can be avoided if the change will have no
> effect
> >         on the actual packages generated by the recipe, such as
> updating
> >         the SRC_URI to point to a new host. If in any doubt then you
> >         should increase the PR regardless of what has been changed.
> >
> >         The PR value should never be decremented. If you accidentally
> >         submit a large PR value for example then it should be left at
> >         the value and just increased for new releases, not reset back
> to
> >         a lower version.
> >
> >>> +PV = "0.7.3+0.8.0-rc"
> >>> +PR_append = "+gitr${SRCPV}"
> >>
> >> SRCPV should not be used in PR (even if it's been copied from
> another
> >> recipe which does it wrong).
> >
> > I am still confused about this one. That is why I still have not
> > committed the pkg-config patch yet [2]. Could the right way be
> > documented in the manual.
> 
> It is completely OK to use it in PR if you want the hash in PR, but not
> PV.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> 
> iD8DBQFN3Q5dMkyGM64RGpERAhwhAKCKxo/HdbjYY90JHWbgtyiGCMwLFQCgiaRa
> HB1AMRMFaS/r4+iF6S6wa5M=
> =XI4d
> -----END PGP SIGNATURE-----
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Re: [PATCH] wpa-gui-e: build the latest version from git sources

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3640 bytes --]

On Wed, May 25, 2011 at 04:18:20PM +0200, Reizer, Eyal wrote:
> Koen,
> 
> Do you mean that using SRCREV instead of SRCPV as below is ok, or should I also remove the PV = "..."?
> 
> +PV = "0.7.3+0.8.0-rc"
> +PR_append = "+git${SRCREV}"

Please stay with ${SRCPV} and +gitr (not +git) if you care about
upgradable paths.

And I don't care if it's in PV or PR and I use it from PR sometimes too,
because it's easier to put ie patches to ${PN}-${PV} dir like
wpa-gui-e-0.7.3+0.8.0-rc/foo.path
and better (even faster for ricers) then shared wpa-gui-e/foo.path

Regards,

> > -----Original Message-----
> > From: openembedded-devel-bounces@lists.openembedded.org
> > [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> > Koen Kooi
> > Sent: Wednesday, May 25, 2011 5:13 PM
> > To: openembedded-devel@lists.openembedded.org
> > Subject: Re: [oe] [PATCH] wpa-gui-e: build the latest version from git
> > sources
> > 
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > On 25-05-11 16:03, Paul Menzel wrote:
> > > Dear Andreas, dear Eyal,
> > >
> > >
> > > On Mi, 2011-05-25 at 15:36 +0200, Andreas Oberritter wrote:
> > >
> > >> On 05/25/2011 02:58 PM, Eyal Reizer wrote:
> > >
> > > […]
> > >
> > >>> +SRCREV = "b8fb017272ed4794339978c9fbc0e74571a44728"
> > >>> +PR = "r0"
> > >>
> > >> PR = "r0" is the default and can be removed.
> > >
> > > it seems there are different opinions on this topic. At least the
> > manual
> > > says differently.
> > >
> > >         Note
> > >
> > >         It is good practice to always define PR in your recipes, even
> > >         for the "r0" release, so that when editing the recipe it is
> > >         clear that the PR number needs to be updated.
> > >
> > >         You should always increment PR when modifying a recipe.
> > >         Sometimes this can be avoided if the change will have no
> > effect
> > >         on the actual packages generated by the recipe, such as
> > updating
> > >         the SRC_URI to point to a new host. If in any doubt then you
> > >         should increase the PR regardless of what has been changed.
> > >
> > >         The PR value should never be decremented. If you accidentally
> > >         submit a large PR value for example then it should be left at
> > >         the value and just increased for new releases, not reset back
> > to
> > >         a lower version.
> > >
> > >>> +PV = "0.7.3+0.8.0-rc"
> > >>> +PR_append = "+gitr${SRCPV}"
> > >>
> > >> SRCPV should not be used in PR (even if it's been copied from
> > another
> > >> recipe which does it wrong).
> > >
> > > I am still confused about this one. That is why I still have not
> > > committed the pkg-config patch yet [2]. Could the right way be
> > > documented in the manual.
> > 
> > It is completely OK to use it in PR if you want the hash in PR, but not
> > PV.
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.5 (Darwin)
> > 
> > iD8DBQFN3Q5dMkyGM64RGpERAhwhAKCKxo/HdbjYY90JHWbgtyiGCMwLFQCgiaRa
> > HB1AMRMFaS/r4+iF6S6wa5M=
> > =XI4d
> > -----END PGP SIGNATURE-----
> > 
> > 
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Type: application/pgp-signature, Size: 205 bytes --]