From: Kukjin Kim <kgene.kim@samsung.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: [PATCH] ARM: exynos4: fix secondary CPU boot
Date: Wed, 25 May 2011 10:28:55 -0700 [thread overview]
Message-ID: <4DDD3C57.6020705@samsung.com> (raw)
In-Reply-To: <1305899190-16732-1-git-send-email-marc.zyngier@arm.com>
On 05/20/11 06:46, Marc Zyngier wrote:
> Patch 7d30e8b38 (ARM: EXYNOS4: Add EXYNOS4 CPU initialization support)
> renamed the s5pv310 to exynos4, and also changed the value of
> EXYNOS4_PA_SYSRAM, which is used to release the secondary CPU from
> spinning in BL0. As a result, CPU1 can't be brought up anymore.
>
> This patch simply reverts EXYNOS4_PA_SYSRAM to its original value,
> which results in a working CPU1.
>
> Tested on an SMDK-v310.
>
> Cc: Kukjin Kim<kgene.kim@samsung.com>
> Signed-off-by: Marc Zyngier<marc.zyngier@arm.com>
> ---
> arch/arm/mach-exynos4/include/mach/map.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos4/include/mach/map.h b/arch/arm/mach-exynos4/include/mach/map.h
> index 6330b73..862967f 100644
> --- a/arch/arm/mach-exynos4/include/mach/map.h
> +++ b/arch/arm/mach-exynos4/include/mach/map.h
> @@ -23,7 +23,7 @@
>
> #include<plat/map-s5p.h>
>
> -#define EXYNOS4_PA_SYSRAM 0x02020000
> +#define EXYNOS4_PA_SYSRAM 0x02025000
>
Hi Marc,
Hmm...the value, 0x02020000 is correct on Exynos4210 now.
So can't apply this but I know, you're right on old version of
Exynos4210...let's think again about this.
Maybe I missed its commit for changing when I submitted it...
> #define EXYNOS4_PA_FIMC0 0x11800000
> #define EXYNOS4_PA_FIMC1 0x11810000
--
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: exynos4: fix secondary CPU boot
Date: Wed, 25 May 2011 10:28:55 -0700 [thread overview]
Message-ID: <4DDD3C57.6020705@samsung.com> (raw)
In-Reply-To: <1305899190-16732-1-git-send-email-marc.zyngier@arm.com>
On 05/20/11 06:46, Marc Zyngier wrote:
> Patch 7d30e8b38 (ARM: EXYNOS4: Add EXYNOS4 CPU initialization support)
> renamed the s5pv310 to exynos4, and also changed the value of
> EXYNOS4_PA_SYSRAM, which is used to release the secondary CPU from
> spinning in BL0. As a result, CPU1 can't be brought up anymore.
>
> This patch simply reverts EXYNOS4_PA_SYSRAM to its original value,
> which results in a working CPU1.
>
> Tested on an SMDK-v310.
>
> Cc: Kukjin Kim<kgene.kim@samsung.com>
> Signed-off-by: Marc Zyngier<marc.zyngier@arm.com>
> ---
> arch/arm/mach-exynos4/include/mach/map.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos4/include/mach/map.h b/arch/arm/mach-exynos4/include/mach/map.h
> index 6330b73..862967f 100644
> --- a/arch/arm/mach-exynos4/include/mach/map.h
> +++ b/arch/arm/mach-exynos4/include/mach/map.h
> @@ -23,7 +23,7 @@
>
> #include<plat/map-s5p.h>
>
> -#define EXYNOS4_PA_SYSRAM 0x02020000
> +#define EXYNOS4_PA_SYSRAM 0x02025000
>
Hi Marc,
Hmm...the value, 0x02020000 is correct on Exynos4210 now.
So can't apply this but I know, you're right on old version of
Exynos4210...let's think again about this.
Maybe I missed its commit for changing when I submitted it...
> #define EXYNOS4_PA_FIMC0 0x11800000
> #define EXYNOS4_PA_FIMC1 0x11810000
--
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2011-05-25 17:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 13:46 [PATCH] ARM: exynos4: fix secondary CPU boot Marc Zyngier
2011-05-20 13:46 ` Marc Zyngier
2011-05-25 17:28 ` Kukjin Kim [this message]
2011-05-25 17:28 ` Kukjin Kim
2011-05-25 18:04 ` Marc Zyngier
2011-05-25 18:04 ` Marc Zyngier
2011-05-25 19:06 ` Kukjin Kim
2011-05-25 19:06 ` Kukjin Kim
2011-05-26 15:11 ` Marc Zyngier
2011-05-26 15:11 ` Marc Zyngier
2011-06-02 7:01 ` Kyungmin Park
2011-06-02 7:01 ` Kyungmin Park
2011-06-02 8:34 ` Marc Zyngier
2011-06-02 8:34 ` Marc Zyngier
2011-06-02 8:39 ` Kyungmin Park
2011-06-02 8:39 ` Kyungmin Park
2011-06-02 8:54 ` Marc Zyngier
2011-06-02 8:54 ` Marc Zyngier
2011-06-14 22:26 ` Angus Ainslie
2011-06-14 22:26 ` Angus Ainslie
2011-06-15 0:52 ` Kyungmin Park
2011-06-15 0:52 ` Kyungmin Park
2011-06-15 9:53 ` Marc Zyngier
2011-06-15 9:53 ` Marc Zyngier
2011-06-29 5:52 ` Kyungmin Park
2011-06-29 5:52 ` Kyungmin Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDD3C57.6020705@samsung.com \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.