From: Jarod Wilson <jarod@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Mauro Carvalho Chehab" <mchehab@infradead.org>,
"David Härdeman" <david@hardeman.nu>,
"Dmitry Torokhov" <dtor@mail.ru>,
"open list:MEDIA INPUT INFRA..." <linux-media@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] rc: double unlock in rc_register_device()
Date: Thu, 26 May 2011 14:49:16 +0000 [thread overview]
Message-ID: <4DDE686C.6000900@redhat.com> (raw)
In-Reply-To: <20110526085201.GF14591@shale.localdomain>
Dan Carpenter wrote:
> If change_protocol() fails and we goto out_raw, then it calls unlock
> twice.
Gah, good catch, I gotta quit adding new bugs... ;)
> I noticed that the other time we called change_protocol() we
> held the &dev->lock, so I changed it to hold it here too.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
> ---
> Compile tested only.
I've sanity-checked the code, and yeah, calling change_protocol()
function pointers with the lock held should be perfectly fine here too.
The change_protocol functions are device-driver-specific, and don't
touch the core rc device lock.
Reviewed-by: Jarod Wilson <jarod@redhat.com>
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
WARNING: multiple messages have this Message-ID (diff)
From: Jarod Wilson <jarod@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Mauro Carvalho Chehab" <mchehab@infradead.org>,
"David Härdeman" <david@hardeman.nu>,
"Dmitry Torokhov" <dtor@mail.ru>,
"open list:MEDIA INPUT INFRA..." <linux-media@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] rc: double unlock in rc_register_device()
Date: Thu, 26 May 2011 10:49:16 -0400 [thread overview]
Message-ID: <4DDE686C.6000900@redhat.com> (raw)
In-Reply-To: <20110526085201.GF14591@shale.localdomain>
Dan Carpenter wrote:
> If change_protocol() fails and we goto out_raw, then it calls unlock
> twice.
Gah, good catch, I gotta quit adding new bugs... ;)
> I noticed that the other time we called change_protocol() we
> held the &dev->lock, so I changed it to hold it here too.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
> ---
> Compile tested only.
I've sanity-checked the code, and yeah, calling change_protocol()
function pointers with the lock held should be perfectly fine here too.
The change_protocol functions are device-driver-specific, and don't
touch the core rc device lock.
Reviewed-by: Jarod Wilson <jarod@redhat.com>
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2011-05-26 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 8:52 [patch] [media] rc: double unlock in rc_register_device() Dan Carpenter
2011-05-26 8:52 ` Dan Carpenter
2011-05-26 14:49 ` Jarod Wilson [this message]
2011-05-26 14:49 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDE686C.6000900@redhat.com \
--to=jarod@redhat.com \
--cc=david@hardeman.nu \
--cc=dtor@mail.ru \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.