All of lore.kernel.org
 help / color / mirror / Atom feed
From: ak@linux.intel.com (Andi Kleen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Do not allow unaligned accesses when CONFIG_ALIGNMENT_TRAP
Date: Thu, 26 May 2011 14:10:24 -0700	[thread overview]
Message-ID: <4DDEC1C0.20807@linux.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1105261650330.3207@xanadu.home>


> It is possible that -fconserve-stack is still valuable on ARM given that
> it is also used with -mno-unaligned-access for other things than
> structure packing on the stack, and therefore its merits can be debated
> independently from the alignment issue at hand.

The big advantage of -fconserve-stack is that it throttles the inliner 
if the inlining
would cause too much stack growth. This is something you likely want
on ARM too, especially as code gets more and more complex.

-Andi

WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@linux.intel.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: "Will Deacon" <will.deacon@arm.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Måns Rullgård" <mans@mansr.com>,
	linux-arm-kernel@lists.infradead.org,
	lkml <linux-kernel@vger.kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	sam@ravnborg.org
Subject: Re: [PATCH] ARM: Do not allow unaligned accesses when CONFIG_ALIGNMENT_TRAP
Date: Thu, 26 May 2011 14:10:24 -0700	[thread overview]
Message-ID: <4DDEC1C0.20807@linux.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1105261650330.3207@xanadu.home>


> It is possible that -fconserve-stack is still valuable on ARM given that
> it is also used with -mno-unaligned-access for other things than
> structure packing on the stack, and therefore its merits can be debated
> independently from the alignment issue at hand.

The big advantage of -fconserve-stack is that it throttles the inliner 
if the inlining
would cause too much stack growth. This is something you likely want
on ARM too, especially as code gets more and more complex.

-Andi


  reply	other threads:[~2011-05-26 21:10 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23 11:16 [PATCH] ARM: Do not allow unaligned accesses when CONFIG_ALIGNMENT_TRAP Catalin Marinas
2011-05-23 12:30 ` Måns Rullgård
2011-05-23 13:25   ` Russell King - ARM Linux
2011-05-23 13:21 ` Russell King - ARM Linux
2011-05-23 13:51   ` Catalin Marinas
2011-05-23 14:37     ` Måns Rullgård
2011-05-23 14:41       ` Catalin Marinas
2011-05-23 14:52       ` Russell King - ARM Linux
2011-05-24  9:39   ` Catalin Marinas
2011-05-24 14:17     ` Måns Rullgård
2011-05-24 15:26       ` Catalin Marinas
2011-05-24 16:23         ` Måns Rullgård
2011-05-24 17:26           ` Nicolas Pitre
2011-05-24 17:13         ` Dave Martin
2011-05-25 11:14           ` Catalin Marinas
2011-05-25 12:43             ` Dave Martin
2011-05-25 13:32               ` Måns Rullgård
2011-05-25 14:05                 ` Dave Martin
2011-05-25 14:48                   ` Måns Rullgård
2011-05-25 14:50                 ` Catalin Marinas
2011-05-25 14:53                   ` Måns Rullgård
2011-05-26 17:10                   ` Will Deacon
2011-05-26 17:10                     ` Will Deacon
2011-05-26 18:14                     ` Måns Rullgård
2011-05-26 18:14                       ` Måns Rullgård
2011-05-26 19:58                     ` Andi Kleen
2011-05-26 19:58                       ` Andi Kleen
2011-05-26 21:03                     ` Nicolas Pitre
2011-05-26 21:03                       ` Nicolas Pitre
2011-05-26 21:10                       ` Andi Kleen [this message]
2011-05-26 21:10                         ` Andi Kleen
2011-05-26 21:26                         ` Måns Rullgård
2011-05-26 21:26                           ` Måns Rullgård
2011-05-27 10:05                         ` Will Deacon
2011-05-27 10:05                           ` Will Deacon
2011-05-27 16:53                           ` Andi Kleen
2011-05-27 16:53                             ` Andi Kleen
2011-05-26 21:51                       ` Russell King - ARM Linux
2011-05-26 21:51                         ` Russell King - ARM Linux
2011-05-26 22:29                         ` Andi Kleen
2011-05-26 22:29                           ` Andi Kleen
2011-05-27  8:38                         ` Catalin Marinas
2011-05-27  8:38                           ` Catalin Marinas
2011-05-27  8:54                           ` Russell King - ARM Linux
2011-05-27  8:54                             ` Russell King - ARM Linux
2011-05-27  9:51                             ` Catalin Marinas
2011-05-27  9:51                               ` Catalin Marinas
2011-05-27  9:56                               ` Catalin Marinas
2011-05-27  9:56                                 ` Catalin Marinas
2011-05-27 12:46                               ` Måns Rullgård
2011-05-27 12:46                                 ` Måns Rullgård
2011-05-28 15:34                                 ` [PATCH] Disable -fconserve-stack on ARM Andi Kleen
2011-05-28 15:34                                   ` Andi Kleen
2011-05-31 16:30                                   ` Catalin Marinas
2011-05-31 16:30                                     ` Catalin Marinas
2011-05-31 18:01                                     ` Andi Kleen
2011-05-31 18:01                                       ` Andi Kleen
2011-06-02 13:08                                       ` Catalin Marinas
2011-06-02 13:08                                         ` Catalin Marinas
     [not found] <mailman.254.1306496353.1533.linux-arm-kernel@lists.infradead.org>
2011-05-27 12:14 ` [PATCH] ARM: Do not allow unaligned accesses when CONFIG_ALIGNMENT_TRAP Frank Hofmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDEC1C0.20807@linux.intel.com \
    --to=ak@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.