From: Liam Girdwood <lrg@ti.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Peter Hsiang <peter.hsiang@maxim-ic.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Hsiang <cdefgab1288@gmail.com>
Subject: Re: [PATCH] ASoC: Remove redundant freq assignment for max98095->sysclk/max98088->sysclk
Date: Fri, 27 May 2011 22:13:50 +0100 [thread overview]
Message-ID: <4DE0140E.6050905@ti.com> (raw)
In-Reply-To: <1306510253.19556.36.camel@phoenix>
On 27/05/11 16:30, Axel Lin wrote:
> Current implementation set max98095->sysclk/max98088->sysclk to freq twice.
> Set it once is enough, this patch removes the first assignment in case
> we may set invalid clock frequency to max98095->sysclk/max98088->sysclk.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> hi Peter,
> I don't have this hardware handy. Can you help to test it?
> Thanks,
> Axel
>
Acked-by: Liam Girdwood <lrg@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: Liam Girdwood <lrg@ti.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Hsiang <peter.hsiang@maxim-ic.com>,
Peter Hsiang <cdefgab1288@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: Remove redundant freq assignment for max98095->sysclk/max98088->sysclk
Date: Fri, 27 May 2011 22:13:50 +0100 [thread overview]
Message-ID: <4DE0140E.6050905@ti.com> (raw)
In-Reply-To: <1306510253.19556.36.camel@phoenix>
On 27/05/11 16:30, Axel Lin wrote:
> Current implementation set max98095->sysclk/max98088->sysclk to freq twice.
> Set it once is enough, this patch removes the first assignment in case
> we may set invalid clock frequency to max98095->sysclk/max98088->sysclk.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> hi Peter,
> I don't have this hardware handy. Can you help to test it?
> Thanks,
> Axel
>
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-05-27 21:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 15:30 [PATCH] ASoC: Remove redundant freq assignment for max98095->sysclk/max98088->sysclk Axel Lin
2011-05-27 21:13 ` Liam Girdwood [this message]
2011-05-27 21:13 ` Liam Girdwood
2011-05-28 1:45 ` Peter Hsiang
2011-05-28 1:45 ` Peter Hsiang
2011-05-28 17:58 ` Mark Brown
2011-05-28 17:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE0140E.6050905@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cdefgab1288@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hsiang@maxim-ic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.