From: Kukjin Kim <kgene.kim@samsung.com>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Thomas Abraham <thomas.ab@samsung.com>,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
ben-linux@fluff.org
Subject: Re: [PATCH v2 7/7] ARM: Exynos4: Add clkdev support
Date: Fri, 27 May 2011 19:14:29 -0700 [thread overview]
Message-ID: <4DE05A85.4050201@samsung.com> (raw)
In-Reply-To: <BANLkTi=LQ2neqPe3Eobmx4Qx2rBQacCx8g@mail.gmail.com>
On 05/27/11 18:53, Kyungmin Park wrote:
> On Sat, May 28, 2011 at 12:26 AM, Thomas Abraham<thomas.ab@samsung.com> wrote:
>> Add clkdev support for Samsung's Exynos4 platform and fixes the
>> incorrect clock name for the dw_mmc controller.
>>
>> Signed-off-by: Thomas Abraham<thomas.ab@samsung.com>
>> ---
>> arch/arm/Kconfig | 1 +
>> arch/arm/mach-exynos4/clock.c | 178 +++++++++------------------
>> arch/arm/mach-exynos4/include/mach/clkdev.h | 7 +
>> arch/arm/mach-exynos4/time.c | 2 +
>> 4 files changed, 67 insertions(+), 121 deletions(-)
>> create mode 100644 arch/arm/mach-exynos4/include/mach/clkdev.h
(snip)
>> diff --git a/arch/arm/mach-exynos4/include/mach/clkdev.h b/arch/arm/mach-exynos4/include/mach/clkdev.h
>> new file mode 100644
>> index 0000000..1247f5e
>> --- /dev/null
>> +++ b/arch/arm/mach-exynos4/include/mach/clkdev.h
>> @@ -0,0 +1,7 @@
>> +#ifndef __MACH_EXYNOS4_CLKDEV_H__
>> +#define __MACH_EXYNOS4_CLKDEV_H__
>> +
>> +#define __clk_get(clk) ({ 1; })
>> +#define __clk_put(clk) do { } while (0)
>> +
>> +#endif
>
> Looks good to me.
>
> One nitpick
> How about to just create the one clkdev.h at plat-samsung with proper
> ifdef endif config.
> I think don't need to create clkdev.h for each SoCs.
No, basically the "mach/clkdev.h" should be added, please see
arch/arm/include/asm/clkdev.h.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2011-05-28 2:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 15:26 [RFC][PATCH v2 0/7] Add clkdev support for Samsung platforms Thomas Abraham
2011-05-27 15:26 ` [PATCH v2 1/7] ARM: SAMSUNG: Add clkdev infrastructure Thomas Abraham
2011-05-27 15:26 ` [PATCH v2 2/7] ARM: S3C24XX: Add clkdev support Thomas Abraham
2011-05-27 15:26 ` [PATCH v2 3/7] ARM: S3C64XX: " Thomas Abraham
2011-05-27 15:26 ` [PATCH v2 4/7] ARM: S5P64X0: " Thomas Abraham
2011-05-27 15:26 ` [PATCH v2 5/7] ARM: S5PC100: " Thomas Abraham
2011-05-27 15:26 ` [PATCH v2 6/7] ARM: S5PV210: " Thomas Abraham
2011-05-27 15:26 ` [PATCH v2 7/7] ARM: Exynos4: " Thomas Abraham
2011-05-28 1:53 ` Kyungmin Park
2011-05-28 2:14 ` Kukjin Kim [this message]
2011-05-28 2:33 ` Kyungmin Park
2011-05-28 2:36 ` Kyungmin Park
2011-05-28 2:36 ` Kyungmin Park
2011-05-28 3:39 ` Thomas Abraham
2011-05-28 3:39 ` Thomas Abraham
2011-05-27 15:26 ` [RFC][PATCH v2 0/7] Add clkdev support for Samsung platforms Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE05A85.4050201@samsung.com \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=kmpark@infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.