* Re: [lm-sensors] [PATCH 1/3] hwmon/sch5627: Factor our some code to
@ 2011-05-28 12:38 Jean Delvare
2011-05-28 18:41 ` Hans de Goede
2011-05-28 19:05 ` Jean Delvare
0 siblings, 2 replies; 3+ messages in thread
From: Jean Delvare @ 2011-05-28 12:38 UTC (permalink / raw)
To: lm-sensors
On Sat, 28 May 2011 09:21:23 +0200, Hans de Goede wrote:
> This patch adds a new sch56xx-common.ko which contains code which will also
> be used in the new sch5636 driver.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/hwmon/Kconfig | 5 +
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/sch5627.c | 334 +++------------------------------------
> drivers/hwmon/sch56xx-common.c | 336 ++++++++++++++++++++++++++++++++++++++++
> drivers/hwmon/sch56xx-common.h | 24 +++
> 5 files changed, 390 insertions(+), 310 deletions(-)
> create mode 100644 drivers/hwmon/sch56xx-common.c
> create mode 100644 drivers/hwmon/sch56xx-common.h
> (...)
> --- /dev/null
> +++ b/drivers/hwmon/sch56xx-common.c
> (...)
> +#define SIO_SCH56XX_LD_EM 0x0C /* Embedded ųController Logical Dev */
A regular "u" will do... I don't know you used but that wasn't even a
Greek mu.
All the rest looks pretty good.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH 1/3] hwmon/sch5627: Factor our some code to
2011-05-28 12:38 [lm-sensors] [PATCH 1/3] hwmon/sch5627: Factor our some code to Jean Delvare
@ 2011-05-28 18:41 ` Hans de Goede
2011-05-28 19:05 ` Jean Delvare
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2011-05-28 18:41 UTC (permalink / raw)
To: lm-sensors
Hi,
On 05/28/2011 02:38 PM, Jean Delvare wrote:
> On Sat, 28 May 2011 09:21:23 +0200, Hans de Goede wrote:
>> This patch adds a new sch56xx-common.ko which contains code which will also
>> be used in the new sch5636 driver.
>>
>> Signed-off-by: Hans de Goede<hdegoede@redhat.com>
>> ---
>> drivers/hwmon/Kconfig | 5 +
>> drivers/hwmon/Makefile | 1 +
>> drivers/hwmon/sch5627.c | 334 +++------------------------------------
>> drivers/hwmon/sch56xx-common.c | 336 ++++++++++++++++++++++++++++++++++++++++
>> drivers/hwmon/sch56xx-common.h | 24 +++
>> 5 files changed, 390 insertions(+), 310 deletions(-)
>> create mode 100644 drivers/hwmon/sch56xx-common.c
>> create mode 100644 drivers/hwmon/sch56xx-common.h
>> (...)
>> --- /dev/null
>> +++ b/drivers/hwmon/sch56xx-common.c
>> (...)
>> +#define SIO_SCH56XX_LD_EM 0x0C /* Embedded ųController Logical Dev */
>
> A regular "u" will do... I don't know you used but that wasn't even a
> Greek mu.
Oh, oops wrong compose sequence. I know the right one now, giving:
µController, or I can just use a regular u if you prefer :)
So do you want me to resend, with this fixed, or will you fix this in
your tree?
Regards,
Hans
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH 1/3] hwmon/sch5627: Factor our some code to
2011-05-28 12:38 [lm-sensors] [PATCH 1/3] hwmon/sch5627: Factor our some code to Jean Delvare
2011-05-28 18:41 ` Hans de Goede
@ 2011-05-28 19:05 ` Jean Delvare
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2011-05-28 19:05 UTC (permalink / raw)
To: lm-sensors
On Sat, 28 May 2011 20:41:40 +0200, Hans de Goede wrote:
> Hi,
>
> On 05/28/2011 02:38 PM, Jean Delvare wrote:
> > On Sat, 28 May 2011 09:21:23 +0200, Hans de Goede wrote:
> >> This patch adds a new sch56xx-common.ko which contains code which will also
> >> be used in the new sch5636 driver.
> >>
> >> Signed-off-by: Hans de Goede<hdegoede@redhat.com>
> >> ---
> >> drivers/hwmon/Kconfig | 5 +
> >> drivers/hwmon/Makefile | 1 +
> >> drivers/hwmon/sch5627.c | 334 +++------------------------------------
> >> drivers/hwmon/sch56xx-common.c | 336 ++++++++++++++++++++++++++++++++++++++++
> >> drivers/hwmon/sch56xx-common.h | 24 +++
> >> 5 files changed, 390 insertions(+), 310 deletions(-)
> >> create mode 100644 drivers/hwmon/sch56xx-common.c
> >> create mode 100644 drivers/hwmon/sch56xx-common.h
> >> (...)
> >> --- /dev/null
> >> +++ b/drivers/hwmon/sch56xx-common.c
> >> (...)
> >> +#define SIO_SCH56XX_LD_EM 0x0C /* Embedded ųController Logical Dev */
> >
> > A regular "u" will do... I don't know you used but that wasn't even a
> > Greek mu.
>
> Oh, oops wrong compose sequence. I know the right one now, giving:
> µController, or I can just use a regular u if you prefer :)
>
> So do you want me to resend, with this fixed, or will you fix this in
> your tree?
I'll fix it, no worry.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-28 19:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-28 12:38 [lm-sensors] [PATCH 1/3] hwmon/sch5627: Factor our some code to Jean Delvare
2011-05-28 18:41 ` Hans de Goede
2011-05-28 19:05 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.