From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"Andreas Färber" <andreas.faerber@web.de>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Avi Kivity" <avi@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Use SIGIO with caution
Date: Tue, 31 May 2011 09:26:41 -0500 [thread overview]
Message-ID: <4DE4FAA1.7080109@codemonkey.ws> (raw)
In-Reply-To: <4DE4F5E2.5020906@siemens.com>
On 05/31/2011 09:06 AM, Jan Kiszka wrote:
> On 2011-05-31 15:47, Anthony Liguori wrote:
>> On 05/29/2011 04:50 PM, Andreas Färber wrote:
>>> BeOS and Haiku don't define SIGIO. When undefined, it won't arrive
>>> and doesn't need to be blocked.
>>>
>>> Signed-off-by: Andreas Färber<andreas.faerber@web.de>
>>
>> Anything to do with signal masks is never a trivial patch BTW...
>>
>> But I actually think explicit handling of SIGIO is unneeded. I think
>> this is a hold over from the pre-I/O thread days where we selectively
>> set SIGIO on certain file descriptors to make sure that when an IO fd
>> became readable, we received a signal to break out of the KVM emulation
>> loop.
>>
>> Can the folks on CC confirm/deny?
>>
>> I can't see any use of SIGIO in the current source tree.
>
> At least qemu-timer.c uses SIGIO in HPET mode. That only applies to
> Linux hosts, though.
Is there any reason we still carry multiple timer implementations these
days?
HPET shouldn't be any better than dynticks.
Regards,
Anthony Liguori
>
> Jan
>
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"Andreas Färber" <andreas.faerber@web.de>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Avi Kivity" <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Use SIGIO with caution
Date: Tue, 31 May 2011 09:26:41 -0500 [thread overview]
Message-ID: <4DE4FAA1.7080109@codemonkey.ws> (raw)
In-Reply-To: <4DE4F5E2.5020906@siemens.com>
On 05/31/2011 09:06 AM, Jan Kiszka wrote:
> On 2011-05-31 15:47, Anthony Liguori wrote:
>> On 05/29/2011 04:50 PM, Andreas Färber wrote:
>>> BeOS and Haiku don't define SIGIO. When undefined, it won't arrive
>>> and doesn't need to be blocked.
>>>
>>> Signed-off-by: Andreas Färber<andreas.faerber@web.de>
>>
>> Anything to do with signal masks is never a trivial patch BTW...
>>
>> But I actually think explicit handling of SIGIO is unneeded. I think
>> this is a hold over from the pre-I/O thread days where we selectively
>> set SIGIO on certain file descriptors to make sure that when an IO fd
>> became readable, we received a signal to break out of the KVM emulation
>> loop.
>>
>> Can the folks on CC confirm/deny?
>>
>> I can't see any use of SIGIO in the current source tree.
>
> At least qemu-timer.c uses SIGIO in HPET mode. That only applies to
> Linux hosts, though.
Is there any reason we still carry multiple timer implementations these
days?
HPET shouldn't be any better than dynticks.
Regards,
Anthony Liguori
>
> Jan
>
next prev parent reply other threads:[~2011-05-31 14:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 21:50 [Qemu-trivial] [PATCH] Use SIGIO with caution Andreas Färber
2011-05-29 21:50 ` [Qemu-devel] " Andreas Färber
2011-05-31 13:47 ` [Qemu-trivial] " Anthony Liguori
2011-05-31 13:47 ` Anthony Liguori
2011-05-31 14:06 ` [Qemu-trivial] " Jan Kiszka
2011-05-31 14:06 ` Jan Kiszka
2011-05-31 14:26 ` Anthony Liguori [this message]
2011-05-31 14:26 ` Anthony Liguori
2011-05-31 14:54 ` [Qemu-trivial] " Jan Kiszka
2011-05-31 14:54 ` Jan Kiszka
2011-05-31 15:44 ` [Qemu-trivial] " Alexander Graf
2011-05-31 15:44 ` Alexander Graf
2011-05-31 15:48 ` [Qemu-trivial] " Anthony Liguori
2011-05-31 15:48 ` Anthony Liguori
2011-05-31 16:16 ` [Qemu-trivial] " Alexander Graf
2011-05-31 16:16 ` Alexander Graf
2011-05-31 19:49 ` [Qemu-trivial] " Anthony Liguori
2011-05-31 19:49 ` Anthony Liguori
2011-05-31 21:11 ` [Qemu-trivial] " Andreas Färber
2011-05-31 21:11 ` Andreas Färber
2011-05-31 21:43 ` [Qemu-trivial] " Jan Kiszka
2011-05-31 21:43 ` [Qemu-devel] " Jan Kiszka
2011-05-31 23:19 ` [Qemu-trivial] " Anthony Liguori
2011-05-31 23:19 ` [Qemu-devel] " Anthony Liguori
2011-05-31 14:11 ` [Qemu-trivial] " Avi Kivity
2011-05-31 14:11 ` Avi Kivity
2011-05-31 21:24 ` [Qemu-trivial] " Andreas Färber
2011-05-31 21:24 ` Andreas Färber
2011-06-01 22:30 ` [Qemu-trivial] " Stefan Hajnoczi
2011-06-01 22:30 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE4FAA1.7080109@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=andreas.faerber@web.de \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.