All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jim Schutt" <jaschut-4OHPYypu0djtX7QSmKvirg@public.gmane.org>
To: Or Gerlitz <or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Bob Pearson
	<rpearson-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>,
	linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Vladimir Sokolovsky
	<vlad-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>,
	Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] mlx4: allow for 4K mtu configuration of IB ports
Date: Tue, 31 May 2011 10:11:58 -0600	[thread overview]
Message-ID: <4DE5134E.6070401@sandia.gov> (raw)
In-Reply-To: <BANLkTinK+YHUyF4ThHQAwFeZ4FNswpY-tw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Or,

Or Gerlitz wrote:
> Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> Jim Schutt <jaschut-4OHPYypu0djtX7QSmKvirg@public.gmane.org> wrote:
>>> no good reason to insist that the VL usage is the same for both
>>> interswitch links, and switch-CA links. Do I need to change this?
> 
>> I don't think changing this is a high priority, since it's a pretty small
>> slice of the world, and QoS on the edge links probably is important
>> to an even smaller slice, but IMHO it would be better to give QoS to
>> HCAs that only support 4 VLs by using a different SL2VL table for links to CAs.
> 
> Jim,
> 
> AFAIK, the way opensm applies an SL-to-VL mapping specification (e.g
> dictated by the admin or maybe your routing engine) on a specific link
> is by modulation on the number of active VLs for that link - e.g say
> the ID mapping was required and there are two VLs for that link, so
> we'll have SL-to-VL of 0->0 1->1 2->0 3->1 and so on. So in that
> respect, I wasn't sure what's the change here for you.

Hmmm, can you tell me where such remapping happens?

What I know about so far is the code in sl2vl_update_table(),
which AFAICS truncates VL values in the SL2VL maps provided
by the routing engine to fit into the number of VLs supported
by a port.

Am I missing something else?

torus-2QoS will currently only use VL values 0 and 4 in the
SL2VL maps it generates for CA ports; i.e. any SL maps either
to VL 0 or VL 4, depending on QoS level.

So sl2vl_update_table() would truncate all those VL 4 values
to 0 in the case of ports that support fewer than 8 data VLs.

What I'm suggesting is that I need to make torus-2QoS generate
SL2VL maps that only reference VLs 0 or 1 for CA ports, in order
to allow it to support 2 QoS levels for CA ports that don't
support 8 data VLs.

-- Jim

> 
> Or.
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2011-05-31 16:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-25 12:10 [PATCH] mlx4: allow for 4K mtu configuration of IB ports Or Gerlitz
     [not found] ` <alpine.LRH.2.00.1105251507140.16147-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2011-05-25 16:13   ` Roland Dreier
     [not found]     ` <BANLkTi=bKdVXm+f+HVeg2tBzT4RBJDCN_w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-25 21:05       ` Or Gerlitz
     [not found]         ` <BANLkTinDCbPXi8zS46wcVW_Yn0fxzbSikw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-25 21:27           ` Roland Dreier
     [not found]             ` <BANLkTikrJ_3f+LwN_R=-AcwCde-KdHJhOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-25 21:46               ` Or Gerlitz
     [not found]                 ` <BANLkTinT5OJdP38Xq=PCtx1wgxDhjVfndA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-25 22:07                   ` Jason Gunthorpe
2011-05-25 22:10                   ` Roland Dreier
     [not found]                     ` <BANLkTi=NkZQX2JFa99qkVpLAchRjNoYOhg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-26  6:24                       ` Or Gerlitz
     [not found]                         ` <4DDDF212.4080700-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-05-26 15:53                           ` Roland Dreier
     [not found]                             ` <BANLkTimrm7bqTT8qAzxdf9tsJuv7+NPO+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-30 22:12                               ` Or Gerlitz
2011-05-25 22:19               ` Bob Pearson
2011-05-25 23:14                 ` Roland Dreier
     [not found]                   ` <BANLkTikLeWHYLKrX8O=syt-Q+b6LP2PCtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-26  6:18                     ` Or Gerlitz
     [not found]                       ` <4DDDF0B1.6090305-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-05-26 14:24                         ` Jim Schutt
     [not found]                       ` <17495_1306419903_p4QEMqSb018281_4DDE6291.1090809@sandia.gov>
     [not found]                         ` <17495_1306419903_p4QEMqSb018281_4DDE6291.1090809-4OHPYypu0djtX7QSmKvirg@public.gmane.org>
2011-05-26 14:30                           ` Jim Schutt
     [not found]                             ` <4DDE63F9.8060502-4OHPYypu0djtX7QSmKvirg@public.gmane.org>
2011-05-26 15:56                               ` Roland Dreier
     [not found]                                 ` <BANLkTimGioibPTUYV046ObOPhHntHxx72w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-30 22:07                                   ` Or Gerlitz
     [not found]                                     ` <BANLkTinK+YHUyF4ThHQAwFeZ4FNswpY-tw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-31 16:11                                       ` Jim Schutt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE5134E.6070401@sandia.gov \
    --to=jaschut-4ohpyypu0djtx7qsmkvirg@public.gmane.org \
    --cc=alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=rpearson-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org \
    --cc=vlad-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.