All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: "Amir G." <amir73il@users.sourceforge.net>
Cc: Dave Chinner <david@fromorbit.com>,
	xfs@oss.sgi.com, linux-ext4@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, sergey57@gmail.com,
	Amir Goldstein <amir73il@users.sf.net>
Subject: Re: [PATCH v2] xfstests: add support for ext4dev FSTYP
Date: Thu, 02 Jun 2011 09:59:35 -0500	[thread overview]
Message-ID: <4DE7A557.9040608@redhat.com> (raw)
In-Reply-To: <BANLkTimKV3LxugkW6_cE5vutjcmatESXuw@mail.gmail.com>

On 6/2/11 2:16 AM, Amir G. wrote:

> OK, after upgrading to newer util-linux and building it from git,
> which also didn't help, I finally found who to blame - me.
> I had an old (noauto) entry in /etc/fstab which claimed that /dev/sda5 is ext4.
> fsck was picking up that entry and insisting that /dev/sda5 is ext4
> (regardless of what it really is)
> blkid isn't doing that silly thing.
> 
> Amir

So where are we at with all this?

I don't really mind adding ext4dev to FSTYP case statements, it -is- something which blkid could, in theory, still return, and making xfstests cope with that and try to invoke fsck -t ext4dev doesn't bother me too much.  It is sadly an fs type embedded into a few tools.

But other than that, I don't think we should be making changes to upstream projects based on your current development hacks (I don't mean hack in a bad way, just that running sed across ext4 to create your custom filesystem for testing should not require upstream projects to change...)

So I'm ok with sprinkling "ext4|ext4dev" around if necessary.  Anyone else disagree?

-Eric

WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@redhat.com>
To: "Amir G." <amir73il@users.sourceforge.net>
Cc: Amir Goldstein <amir73il@users.sf.net>,
	xfs@oss.sgi.com, sergey57@gmail.com,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] xfstests: add support for ext4dev FSTYP
Date: Thu, 02 Jun 2011 09:59:35 -0500	[thread overview]
Message-ID: <4DE7A557.9040608@redhat.com> (raw)
In-Reply-To: <BANLkTimKV3LxugkW6_cE5vutjcmatESXuw@mail.gmail.com>

On 6/2/11 2:16 AM, Amir G. wrote:

> OK, after upgrading to newer util-linux and building it from git,
> which also didn't help, I finally found who to blame - me.
> I had an old (noauto) entry in /etc/fstab which claimed that /dev/sda5 is ext4.
> fsck was picking up that entry and insisting that /dev/sda5 is ext4
> (regardless of what it really is)
> blkid isn't doing that silly thing.
> 
> Amir

So where are we at with all this?

I don't really mind adding ext4dev to FSTYP case statements, it -is- something which blkid could, in theory, still return, and making xfstests cope with that and try to invoke fsck -t ext4dev doesn't bother me too much.  It is sadly an fs type embedded into a few tools.

But other than that, I don't think we should be making changes to upstream projects based on your current development hacks (I don't mean hack in a bad way, just that running sed across ext4 to create your custom filesystem for testing should not require upstream projects to change...)

So I'm ok with sprinkling "ext4|ext4dev" around if necessary.  Anyone else disagree?

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-06-02 14:59 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 12:56 [PATCH v2] xfstests: add support for ext4dev FSTYP amir73il
2011-06-01 12:56 ` amir73il
2011-06-01 23:28 ` Dave Chinner
2011-06-01 23:28   ` Dave Chinner
2011-06-02  2:16   ` Amir G.
2011-06-02  2:16     ` Amir G.
2011-06-02  2:33     ` Amir G.
2011-06-02  2:33       ` Amir G.
2011-06-02  3:08       ` Dave Chinner
2011-06-02  3:08         ` Dave Chinner
2011-06-02  3:49         ` Amir G.
2011-06-02  3:49           ` Amir G.
2011-06-02  6:40           ` Dave Chinner
2011-06-02  6:40             ` Dave Chinner
2011-06-02  7:11             ` Amir G.
2011-06-02  7:11               ` Amir G.
2011-06-02 12:10               ` Lukas Czerner
2011-06-02 12:10                 ` Lukas Czerner
2011-06-02 13:17                 ` Amir G.
2011-06-02 13:17                   ` Amir G.
2011-06-02 14:44                   ` Lukas Czerner
2011-06-02 14:44                     ` Lukas Czerner
2011-06-02  7:16       ` Amir G.
2011-06-02  7:16         ` Amir G.
2011-06-02 14:59         ` Eric Sandeen [this message]
2011-06-02 14:59           ` Eric Sandeen
2011-06-02 17:22           ` Andreas Dilger
2011-06-02 17:22             ` Andreas Dilger
2011-06-03  0:36             ` Ted Ts'o
2011-06-03  0:36               ` Ted Ts'o
2011-06-03  3:26               ` Eric Sandeen
2011-06-03  3:26                 ` Eric Sandeen
2011-06-03  4:59               ` Amir G.
2011-06-03  4:59                 ` Amir G.
2011-06-03  5:06                 ` Eric Sandeen
2011-06-03  5:06                   ` Eric Sandeen
2011-06-03 17:21                   ` Amir G.
2011-06-03 17:21                     ` Amir G.
2011-06-03  2:01           ` Dave Chinner
2011-06-03  2:01             ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE7A557.9040608@redhat.com \
    --to=sandeen@redhat.com \
    --cc=amir73il@users.sf.net \
    --cc=amir73il@users.sourceforge.net \
    --cc=david@fromorbit.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sergey57@gmail.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.