All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] minimal: add weak assigned DISTRO_FEED_CONFIGS variable
@ 2011-06-02 14:44 Simon Busch
  2011-06-02 14:48 ` Martin Jansa
  0 siblings, 1 reply; 9+ messages in thread
From: Simon Busch @ 2011-06-02 14:44 UTC (permalink / raw)
  To: openembedded-devel

Some distros are based on the minimal distro but want to supply another feed configuration.
As minimal uses DISTRO_EXTRA_RDEPENDS to pull distro-feed-configs into the builded image
the new weak assigned variable DISTRO_FEED_CONFIGS makes it possible to specify another
feed configuration.

Signed-off-by: Simon Busch <morphis@gravedo.de>
---
 conf/distro/minimal.conf |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/conf/distro/minimal.conf b/conf/distro/minimal.conf
index 18bcfae..edac24f 100644
--- a/conf/distro/minimal.conf
+++ b/conf/distro/minimal.conf
@@ -53,6 +53,8 @@ INHERIT += "package_ipk"
 IMAGE_FSTYPES ?= "tar.gz jffs2"
 PREFERRED_PKG_FORMAT ?= "ipk"
 
+DISTRO_FEED_CONFIGS ?= "distro-feed-configs"
+
 # Put links to sources in deploy/sources to make it easier for people to be GPL compliant
 INHERIT += "src_distribute_local"
 SRC_DIST_LOCAL ?= "symlink"
@@ -135,7 +137,7 @@ DISTRO_EXTRA_APPS += '${@base_conditional("DISTRO_TYPE", "release", "", "task-cl
 # util-linux-ng-mount util-linux-ng-umount: busybox mount is broken
 # angstrom-libc-fixup-hack: fixes an obscure bug with libc.so symlink
 DISTRO_EXTRA_RDEPENDS += "\
-  distro-feed-configs \
+  ${DISTRO_FEED_CONFIGS} \
   util-linux-ng-mount util-linux-ng-umount \
   angstrom-libc-fixup-hack \
   ${DISTRO_EXTRA_APPS} \
-- 
1.7.4.1




^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] minimal: add weak assigned DISTRO_FEED_CONFIGS variable
  2011-06-02 14:44 [PATCH] minimal: add weak assigned DISTRO_FEED_CONFIGS variable Simon Busch
@ 2011-06-02 14:48 ` Martin Jansa
  2011-06-03 16:07   ` Simon Busch
  0 siblings, 1 reply; 9+ messages in thread
From: Martin Jansa @ 2011-06-02 14:48 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 2010 bytes --]

On Thu, Jun 02, 2011 at 04:44:27PM +0200, Simon Busch wrote:
> Some distros are based on the minimal distro but want to supply another feed configuration.
> As minimal uses DISTRO_EXTRA_RDEPENDS to pull distro-feed-configs into the builded image
> the new weak assigned variable DISTRO_FEED_CONFIGS makes it possible to specify another
> feed configuration.

isn't
DISTRO_FEED_PREFIX
DISTRO_FEED_URI
in
recipes/meta/distro-feed-configs.bb
enought to modify default distro-feed-configs?

and if not cannot we change distro-feed-configs.bb to allow such
modifications?

Regards,

> 
> Signed-off-by: Simon Busch <morphis@gravedo.de>
> ---
>  conf/distro/minimal.conf |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/conf/distro/minimal.conf b/conf/distro/minimal.conf
> index 18bcfae..edac24f 100644
> --- a/conf/distro/minimal.conf
> +++ b/conf/distro/minimal.conf
> @@ -53,6 +53,8 @@ INHERIT += "package_ipk"
>  IMAGE_FSTYPES ?= "tar.gz jffs2"
>  PREFERRED_PKG_FORMAT ?= "ipk"
>  
> +DISTRO_FEED_CONFIGS ?= "distro-feed-configs"
> +
>  # Put links to sources in deploy/sources to make it easier for people to be GPL compliant
>  INHERIT += "src_distribute_local"
>  SRC_DIST_LOCAL ?= "symlink"
> @@ -135,7 +137,7 @@ DISTRO_EXTRA_APPS += '${@base_conditional("DISTRO_TYPE", "release", "", "task-cl
>  # util-linux-ng-mount util-linux-ng-umount: busybox mount is broken
>  # angstrom-libc-fixup-hack: fixes an obscure bug with libc.so symlink
>  DISTRO_EXTRA_RDEPENDS += "\
> -  distro-feed-configs \
> +  ${DISTRO_FEED_CONFIGS} \
>    util-linux-ng-mount util-linux-ng-umount \
>    angstrom-libc-fixup-hack \
>    ${DISTRO_EXTRA_APPS} \
> -- 
> 1.7.4.1
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] minimal: add weak assigned DISTRO_FEED_CONFIGS variable
  2011-06-02 14:48 ` Martin Jansa
@ 2011-06-03 16:07   ` Simon Busch
  2011-06-03 16:17     ` Koen Kooi
  0 siblings, 1 reply; 9+ messages in thread
From: Simon Busch @ 2011-06-03 16:07 UTC (permalink / raw)
  To: openembedded-devel

On 02.06.2011 16:48, Martin Jansa wrote:
> On Thu, Jun 02, 2011 at 04:44:27PM +0200, Simon Busch wrote:
>> Some distros are based on the minimal distro but want to supply another feed configuration.
>> As minimal uses DISTRO_EXTRA_RDEPENDS to pull distro-feed-configs into the builded image
>> the new weak assigned variable DISTRO_FEED_CONFIGS makes it possible to specify another
>> feed configuration.
> 
> isn't
> DISTRO_FEED_PREFIX
> DISTRO_FEED_URI
> in
> recipes/meta/distro-feed-configs.bb
> enought to modify default distro-feed-configs?
> 
> and if not cannot we change distro-feed-configs.bb to allow such
> modifications?

Maybe you are right and it is the better solution to stay with
distro-feed-configs.bb as general solution. The details why I did an own
feed configuration is I don't want all PACKAGE_EXTRA_ARCHS as additional
feed configs. Why should a image which is flashed to a armv4 device pull
the feed configs for a armv7a?

When I have a armv7a device it only needs to get the armv7 +
MACHINE_ARCH + all feed configs from the remote host for an update and
nothing more.

The best solution to archive this is as far as I see to make
distro-feed-configs machine specific and don't add PACKAGE_EXTRA_ARCHS
as feed configuration anymore. For poky-feed-config-opkg in oe-core it's
already the case.

regards,
Simon



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] minimal: add weak assigned DISTRO_FEED_CONFIGS variable
  2011-06-03 16:07   ` Simon Busch
@ 2011-06-03 16:17     ` Koen Kooi
  2011-06-03 16:22       ` Simon Busch
  0 siblings, 1 reply; 9+ messages in thread
From: Koen Kooi @ 2011-06-03 16:17 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03-06-11 18:07, Simon Busch wrote:
> On 02.06.2011 16:48, Martin Jansa wrote:
>> On Thu, Jun 02, 2011 at 04:44:27PM +0200, Simon Busch wrote:
>>> Some distros are based on the minimal distro but want to supply another feed configuration.
>>> As minimal uses DISTRO_EXTRA_RDEPENDS to pull distro-feed-configs into the builded image
>>> the new weak assigned variable DISTRO_FEED_CONFIGS makes it possible to specify another
>>> feed configuration.
>>
>> isn't
>> DISTRO_FEED_PREFIX
>> DISTRO_FEED_URI
>> in
>> recipes/meta/distro-feed-configs.bb
>> enought to modify default distro-feed-configs?
>>
>> and if not cannot we change distro-feed-configs.bb to allow such
>> modifications?
> 
> Maybe you are right and it is the better solution to stay with
> distro-feed-configs.bb as general solution. The details why I did an own
> feed configuration is I don't want all PACKAGE_EXTRA_ARCHS as additional
> feed configs. Why should a image which is flashed to a armv4 device pull
> the feed configs for a armv7a?
> 
> When I have a armv7a device it only needs to get the armv7 +
> MACHINE_ARCH + all feed configs from the remote host for an update and
> nothing more.
> 
> The best solution to archive this is as far as I see to make
> distro-feed-configs machine specific and don't add PACKAGE_EXTRA_ARCHS
> as feed configuration anymore. For poky-feed-config-opkg in oe-core it's
> already the case.

It's also the case for angstrom-feed-configs, which got used as template
for the distro-feed-configs recipe.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFN6Qj9MkyGM64RGpERAn7nAKCJp18FRT3BK7dKsets7aTyBe5c0QCeOT88
oo1QgaUw8BQfYzfI+l/iNSY=
=D1oO
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] minimal: add weak assigned DISTRO_FEED_CONFIGS variable
  2011-06-03 16:17     ` Koen Kooi
@ 2011-06-03 16:22       ` Simon Busch
  2011-06-03 16:38         ` Koen Kooi
  0 siblings, 1 reply; 9+ messages in thread
From: Simon Busch @ 2011-06-03 16:22 UTC (permalink / raw)
  To: openembedded-devel

On 03.06.2011 18:17, Koen Kooi wrote:
> On 03-06-11 18:07, Simon Busch wrote:
>> On 02.06.2011 16:48, Martin Jansa wrote:
>>> On Thu, Jun 02, 2011 at 04:44:27PM +0200, Simon Busch wrote:
>>>> Some distros are based on the minimal distro but want to supply another feed configuration.
>>>> As minimal uses DISTRO_EXTRA_RDEPENDS to pull distro-feed-configs into the builded image
>>>> the new weak assigned variable DISTRO_FEED_CONFIGS makes it possible to specify another
>>>> feed configuration.
>>>
>>> isn't
>>> DISTRO_FEED_PREFIX
>>> DISTRO_FEED_URI
>>> in
>>> recipes/meta/distro-feed-configs.bb
>>> enought to modify default distro-feed-configs?
>>>
>>> and if not cannot we change distro-feed-configs.bb to allow such
>>> modifications?
> 
>> Maybe you are right and it is the better solution to stay with
>> distro-feed-configs.bb as general solution. The details why I did an own
>> feed configuration is I don't want all PACKAGE_EXTRA_ARCHS as additional
>> feed configs. Why should a image which is flashed to a armv4 device pull
>> the feed configs for a armv7a?
> 
>> When I have a armv7a device it only needs to get the armv7 +
>> MACHINE_ARCH + all feed configs from the remote host for an update and
>> nothing more.
> 
>> The best solution to archive this is as far as I see to make
>> distro-feed-configs machine specific and don't add PACKAGE_EXTRA_ARCHS
>> as feed configuration anymore. For poky-feed-config-opkg in oe-core it's
>> already the case.
> 
> It's also the case for angstrom-feed-configs, which got used as template
> for the distro-feed-configs recipe.

Damn it, I missed the PACKAGE_ARCH line within the distro-feed-configs
recipe. But the issue with PACKAGE_EXTRA_ARCHS is still remaining ...

As I see angstrom-feed-configs uses PACKAGE_ARCHS which includes
PACKAGE_ARCHS, but why should I update the feed on my machine for an
architecture I am not running on? So I would propose to only add feeds
for all, ${MACHINE_ARCH} and ${TARGET_ARCH} (whats with noarch, any as
they are listed in bitbake.conf? they are only relicts from old times?).

regards,
Simon



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] minimal: add weak assigned DISTRO_FEED_CONFIGS variable
  2011-06-03 16:22       ` Simon Busch
@ 2011-06-03 16:38         ` Koen Kooi
  2011-06-03 16:41           ` Simon Busch
  0 siblings, 1 reply; 9+ messages in thread
From: Koen Kooi @ 2011-06-03 16:38 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03-06-11 18:22, Simon Busch wrote:
> On 03.06.2011 18:17, Koen Kooi wrote:
>> On 03-06-11 18:07, Simon Busch wrote:
>>> On 02.06.2011 16:48, Martin Jansa wrote:
>>>> On Thu, Jun 02, 2011 at 04:44:27PM +0200, Simon Busch wrote:
>>>>> Some distros are based on the minimal distro but want to supply another feed configuration.
>>>>> As minimal uses DISTRO_EXTRA_RDEPENDS to pull distro-feed-configs into the builded image
>>>>> the new weak assigned variable DISTRO_FEED_CONFIGS makes it possible to specify another
>>>>> feed configuration.
>>>>
>>>> isn't
>>>> DISTRO_FEED_PREFIX
>>>> DISTRO_FEED_URI
>>>> in
>>>> recipes/meta/distro-feed-configs.bb
>>>> enought to modify default distro-feed-configs?
>>>>
>>>> and if not cannot we change distro-feed-configs.bb to allow such
>>>> modifications?
>>
>>> Maybe you are right and it is the better solution to stay with
>>> distro-feed-configs.bb as general solution. The details why I did an own
>>> feed configuration is I don't want all PACKAGE_EXTRA_ARCHS as additional
>>> feed configs. Why should a image which is flashed to a armv4 device pull
>>> the feed configs for a armv7a?
>>
>>> When I have a armv7a device it only needs to get the armv7 +
>>> MACHINE_ARCH + all feed configs from the remote host for an update and
>>> nothing more.
>>
>>> The best solution to archive this is as far as I see to make
>>> distro-feed-configs machine specific and don't add PACKAGE_EXTRA_ARCHS
>>> as feed configuration anymore. For poky-feed-config-opkg in oe-core it's
>>> already the case.
>>
>> It's also the case for angstrom-feed-configs, which got used as template
>> for the distro-feed-configs recipe.
> 
> Damn it, I missed the PACKAGE_ARCH line within the distro-feed-configs
> recipe. But the issue with PACKAGE_EXTRA_ARCHS is still remaining ...
> 
> As I see angstrom-feed-configs uses PACKAGE_ARCHS which includes
> PACKAGE_ARCHS, but why should I update the feed on my machine for an
> architecture I am not running on? So I would propose to only add feeds
> for all, ${MACHINE_ARCH} and ${TARGET_ARCH} (whats with noarch, any as
> they are listed in bitbake.conf? they are only relicts from old times?).

root@usrp-e1xx:~# ls /etc/opkg/
arch.conf  base-feed.conf  debug-feed.conf  gstreamer-feed.conf
noarch-feed.conf  opkg.conf  perl-feed.conf  python-feed.conf
sdk-feed.conf  usrp-e1xx-feed.conf

root@usrp-e1xx:~# grep arm /etc/opkg/*
/etc/opkg/arch.conf:arch arm 16
/etc/opkg/arch.conf:arch armv4 21
/etc/opkg/arch.conf:arch armv4t 26
/etc/opkg/arch.conf:arch armv5te 31
/etc/opkg/arch.conf:arch armv6 36
/etc/opkg/arch.conf:arch armv7 41
/etc/opkg/arch.conf:arch armv7a 46
/etc/opkg/base-feed.conf:src/gz base
http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/base
/etc/opkg/debug-feed.conf:src/gz debug
http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/debug
/etc/opkg/gstreamer-feed.conf:src/gz gstreamer
http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/gstreamer
/etc/opkg/perl-feed.conf:src/gz perl
http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/perl
/etc/opkg/python-feed.conf:src/gz python
http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/python
/etc/opkg/usrp-e1xx-feed.conf:src/gz usrp-e1xx
http://eu.feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/machine/usrp-e1xx
root@usrp-e1xx:~#

So only armv7a there, not armv6 and armv5te, armv4t, etc there.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFN6Q30MkyGM64RGpERAktPAKC8aMVuBcLNcnXtduRDBAmJXU9z0wCeINLn
O1A//kHxU1u7sLKvTZlzSi4=
=jjQK
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] minimal: add weak assigned DISTRO_FEED_CONFIGS variable
  2011-06-03 16:38         ` Koen Kooi
@ 2011-06-03 16:41           ` Simon Busch
  2011-06-03 17:18             ` [PATCH] distro-feed-configs: use ${FEED_ARCH} instead of ${PACKAGE_EXTRA_ARCHES} and bump PR Simon Busch
  2011-06-03 18:28             ` [PATCH] minimal: add weak assigned DISTRO_FEED_CONFIGS variable Koen Kooi
  0 siblings, 2 replies; 9+ messages in thread
From: Simon Busch @ 2011-06-03 16:41 UTC (permalink / raw)
  To: openembedded-devel

On 03.06.2011 18:38, Koen Kooi wrote:
> On 03-06-11 18:22, Simon Busch wrote:
>> On 03.06.2011 18:17, Koen Kooi wrote:
>>> On 03-06-11 18:07, Simon Busch wrote:
>>>> On 02.06.2011 16:48, Martin Jansa wrote:
>>>>> On Thu, Jun 02, 2011 at 04:44:27PM +0200, Simon Busch wrote:
>>>>>> Some distros are based on the minimal distro but want to supply another feed configuration.
>>>>>> As minimal uses DISTRO_EXTRA_RDEPENDS to pull distro-feed-configs into the builded image
>>>>>> the new weak assigned variable DISTRO_FEED_CONFIGS makes it possible to specify another
>>>>>> feed configuration.
>>>>>
>>>>> isn't
>>>>> DISTRO_FEED_PREFIX
>>>>> DISTRO_FEED_URI
>>>>> in
>>>>> recipes/meta/distro-feed-configs.bb
>>>>> enought to modify default distro-feed-configs?
>>>>>
>>>>> and if not cannot we change distro-feed-configs.bb to allow such
>>>>> modifications?
>>>
>>>> Maybe you are right and it is the better solution to stay with
>>>> distro-feed-configs.bb as general solution. The details why I did an own
>>>> feed configuration is I don't want all PACKAGE_EXTRA_ARCHS as additional
>>>> feed configs. Why should a image which is flashed to a armv4 device pull
>>>> the feed configs for a armv7a?
>>>
>>>> When I have a armv7a device it only needs to get the armv7 +
>>>> MACHINE_ARCH + all feed configs from the remote host for an update and
>>>> nothing more.
>>>
>>>> The best solution to archive this is as far as I see to make
>>>> distro-feed-configs machine specific and don't add PACKAGE_EXTRA_ARCHS
>>>> as feed configuration anymore. For poky-feed-config-opkg in oe-core it's
>>>> already the case.
>>>
>>> It's also the case for angstrom-feed-configs, which got used as template
>>> for the distro-feed-configs recipe.
> 
>> Damn it, I missed the PACKAGE_ARCH line within the distro-feed-configs
>> recipe. But the issue with PACKAGE_EXTRA_ARCHS is still remaining ...
> 
>> As I see angstrom-feed-configs uses PACKAGE_ARCHS which includes
>> PACKAGE_ARCHS, but why should I update the feed on my machine for an
>> architecture I am not running on? So I would propose to only add feeds
>> for all, ${MACHINE_ARCH} and ${TARGET_ARCH} (whats with noarch, any as
>> they are listed in bitbake.conf? they are only relicts from old times?).
> 
> root@usrp-e1xx:~# ls /etc/opkg/
> arch.conf  base-feed.conf  debug-feed.conf  gstreamer-feed.conf
> noarch-feed.conf  opkg.conf  perl-feed.conf  python-feed.conf
> sdk-feed.conf  usrp-e1xx-feed.conf
> 
> root@usrp-e1xx:~# grep arm /etc/opkg/*
> /etc/opkg/arch.conf:arch arm 16
> /etc/opkg/arch.conf:arch armv4 21
> /etc/opkg/arch.conf:arch armv4t 26
> /etc/opkg/arch.conf:arch armv5te 31
> /etc/opkg/arch.conf:arch armv6 36
> /etc/opkg/arch.conf:arch armv7 41
> /etc/opkg/arch.conf:arch armv7a 46
> /etc/opkg/base-feed.conf:src/gz base
> http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/base
> /etc/opkg/debug-feed.conf:src/gz debug
> http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/debug
> /etc/opkg/gstreamer-feed.conf:src/gz gstreamer
> http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/gstreamer
> /etc/opkg/perl-feed.conf:src/gz perl
> http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/perl
> /etc/opkg/python-feed.conf:src/gz python
> http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/python
> /etc/opkg/usrp-e1xx-feed.conf:src/gz usrp-e1xx
> http://eu.feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/machine/usrp-e1xx
> root@usrp-e1xx:~#
> 
> So only armv7a there, not armv6 and armv5te, armv4t, etc there.

Yeah, thats the case for angstrom-feed-configs but not
distro-feed-configs ...



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] distro-feed-configs: use ${FEED_ARCH} instead of ${PACKAGE_EXTRA_ARCHES} and bump PR
  2011-06-03 16:41           ` Simon Busch
@ 2011-06-03 17:18             ` Simon Busch
  2011-06-03 18:28             ` [PATCH] minimal: add weak assigned DISTRO_FEED_CONFIGS variable Koen Kooi
  1 sibling, 0 replies; 9+ messages in thread
From: Simon Busch @ 2011-06-03 17:18 UTC (permalink / raw)
  To: openembedded-devel

As the distro feed configs are already machine specific we don't need to include any other
target architecture than specified in ${FEED_ARCH}. Together with all and ${MACHINE_ARCH}
it's all we need to generate the feed package for the machine we build for.

This patch removes some unused code lines too and let bitbake only produce one package
named ${PN} as result. We don't need the -dbg, -dev, ... packages.

Signed-off-by: Simon Busch <morphis@gravedo.de>
---
 recipes/meta/distro-feed-configs.bb |   17 +++++------------
 1 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/recipes/meta/distro-feed-configs.bb b/recipes/meta/distro-feed-configs.bb
index 2540af9..d2cc0a2 100644
--- a/recipes/meta/distro-feed-configs.bb
+++ b/recipes/meta/distro-feed-configs.bb
@@ -1,15 +1,16 @@
 DESCRIPTION = "Configuration files for online package repositories aka feeds"
-PR = "r1"
+PR = "r2"
 
 DISTRO_FEED_PREFIX ?= "remote"
 DISTRO_FEED_URI ?= "http://my-distribution.example/remote-feed/"
 
 do_compile() {
     mkdir -p ${S}/${sysconfdir}/opkg
-    for feed in all ${PACKAGE_EXTRA_ARCHS} ${MACHINE_ARCH}; do
+    for feed in all ${FEED_ARCH} ${MACHINE_ARCH}; do
         echo "src/gz ${DISTRO_FEED_PREFIX}-${feed} ${DISTRO_FEED_URI}/${feed}" > ${S}/${sysconfdir}/opkg/${feed}-feed.conf
     done
 }
+
 do_install () {
         install -d ${D}${sysconfdir}/opkg
         install -m 0644 ${S}/${sysconfdir}/opkg/* ${D}${sysconfdir}/opkg/
@@ -17,14 +18,6 @@ do_install () {
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-#def distro_feed_configs(d):
-#    import bb
-#    parchs = bb.data.getVar( "PACKAGE_EXTRA_ARCHS", d, 1 ).split()
-#    march = bb.data.getVar( "MACHINE_ARCH", d, 1 ).split()
-#    archs = [ "all" ] + parchs + march
-#    confs = [ ( "${sysconfdir}/opkg/%s-feed.conf" % feed ) for feed in archs ]
-#    return " ".join( confs )
-#
-#CONFFILES_${PN} += '${@distro_feed_configs(d)}'
+PACKAGES = "${PN}"
 
-CONFFILES_${PN} += '${@ " ".join( [ ( "${sysconfdir}/opkg/%s-feed.conf" % feed ) for feed in "all ${PACKAGE_EXTRA_ARCHS} ${MACHINE_ARCH}".split() ] ) }'
+CONFFILES_${PN} += '${@ " ".join( [ ( "${sysconfdir}/opkg/%s-feed.conf" % feed ) for feed in "all ${FEED_ARCH} ${MACHINE_ARCH}".split() ] ) }'
-- 
1.7.4.1




^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] minimal: add weak assigned DISTRO_FEED_CONFIGS variable
  2011-06-03 16:41           ` Simon Busch
  2011-06-03 17:18             ` [PATCH] distro-feed-configs: use ${FEED_ARCH} instead of ${PACKAGE_EXTRA_ARCHES} and bump PR Simon Busch
@ 2011-06-03 18:28             ` Koen Kooi
  1 sibling, 0 replies; 9+ messages in thread
From: Koen Kooi @ 2011-06-03 18:28 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03-06-11 18:41, Simon Busch wrote:
> On 03.06.2011 18:38, Koen Kooi wrote:
>> On 03-06-11 18:22, Simon Busch wrote:
>>> On 03.06.2011 18:17, Koen Kooi wrote:
>>>> On 03-06-11 18:07, Simon Busch wrote:
>>>>> On 02.06.2011 16:48, Martin Jansa wrote:
>>>>>> On Thu, Jun 02, 2011 at 04:44:27PM +0200, Simon Busch wrote:
>>>>>>> Some distros are based on the minimal distro but want to supply another feed configuration.
>>>>>>> As minimal uses DISTRO_EXTRA_RDEPENDS to pull distro-feed-configs into the builded image
>>>>>>> the new weak assigned variable DISTRO_FEED_CONFIGS makes it possible to specify another
>>>>>>> feed configuration.
>>>>>>
>>>>>> isn't
>>>>>> DISTRO_FEED_PREFIX
>>>>>> DISTRO_FEED_URI
>>>>>> in
>>>>>> recipes/meta/distro-feed-configs.bb
>>>>>> enought to modify default distro-feed-configs?
>>>>>>
>>>>>> and if not cannot we change distro-feed-configs.bb to allow such
>>>>>> modifications?
>>>>
>>>>> Maybe you are right and it is the better solution to stay with
>>>>> distro-feed-configs.bb as general solution. The details why I did an own
>>>>> feed configuration is I don't want all PACKAGE_EXTRA_ARCHS as additional
>>>>> feed configs. Why should a image which is flashed to a armv4 device pull
>>>>> the feed configs for a armv7a?
>>>>
>>>>> When I have a armv7a device it only needs to get the armv7 +
>>>>> MACHINE_ARCH + all feed configs from the remote host for an update and
>>>>> nothing more.
>>>>
>>>>> The best solution to archive this is as far as I see to make
>>>>> distro-feed-configs machine specific and don't add PACKAGE_EXTRA_ARCHS
>>>>> as feed configuration anymore. For poky-feed-config-opkg in oe-core it's
>>>>> already the case.
>>>>
>>>> It's also the case for angstrom-feed-configs, which got used as template
>>>> for the distro-feed-configs recipe.
>>
>>> Damn it, I missed the PACKAGE_ARCH line within the distro-feed-configs
>>> recipe. But the issue with PACKAGE_EXTRA_ARCHS is still remaining ...
>>
>>> As I see angstrom-feed-configs uses PACKAGE_ARCHS which includes
>>> PACKAGE_ARCHS, but why should I update the feed on my machine for an
>>> architecture I am not running on? So I would propose to only add feeds
>>> for all, ${MACHINE_ARCH} and ${TARGET_ARCH} (whats with noarch, any as
>>> they are listed in bitbake.conf? they are only relicts from old times?).
>>
>> root@usrp-e1xx:~# ls /etc/opkg/
>> arch.conf  base-feed.conf  debug-feed.conf  gstreamer-feed.conf
>> noarch-feed.conf  opkg.conf  perl-feed.conf  python-feed.conf
>> sdk-feed.conf  usrp-e1xx-feed.conf
>>
>> root@usrp-e1xx:~# grep arm /etc/opkg/*
>> /etc/opkg/arch.conf:arch arm 16
>> /etc/opkg/arch.conf:arch armv4 21
>> /etc/opkg/arch.conf:arch armv4t 26
>> /etc/opkg/arch.conf:arch armv5te 31
>> /etc/opkg/arch.conf:arch armv6 36
>> /etc/opkg/arch.conf:arch armv7 41
>> /etc/opkg/arch.conf:arch armv7a 46
>> /etc/opkg/base-feed.conf:src/gz base
>> http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/base
>> /etc/opkg/debug-feed.conf:src/gz debug
>> http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/debug
>> /etc/opkg/gstreamer-feed.conf:src/gz gstreamer
>> http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/gstreamer
>> /etc/opkg/perl-feed.conf:src/gz perl
>> http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/perl
>> /etc/opkg/python-feed.conf:src/gz python
>> http://feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/python
>> /etc/opkg/usrp-e1xx-feed.conf:src/gz usrp-e1xx
>> http://eu.feeds.angstrom-distribution.org/feeds/next/ipk/eglibc/armv7a/machine/usrp-e1xx
>> root@usrp-e1xx:~#
>>
>> So only armv7a there, not armv6 and armv5te, armv4t, etc there.
> 
> Yeah, thats the case for angstrom-feed-configs but not
> distro-feed-configs ...

Yes, that's what I said in my email.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFN6SfcMkyGM64RGpERAhdLAJ0dadfJRZvJFUlvCQz41CnJbf1mbgCgpfQW
MtmNJrvRKRxTwDPJc0CfJdM=
=/+Se
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2011-06-03 18:32 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-02 14:44 [PATCH] minimal: add weak assigned DISTRO_FEED_CONFIGS variable Simon Busch
2011-06-02 14:48 ` Martin Jansa
2011-06-03 16:07   ` Simon Busch
2011-06-03 16:17     ` Koen Kooi
2011-06-03 16:22       ` Simon Busch
2011-06-03 16:38         ` Koen Kooi
2011-06-03 16:41           ` Simon Busch
2011-06-03 17:18             ` [PATCH] distro-feed-configs: use ${FEED_ARCH} instead of ${PACKAGE_EXTRA_ARCHES} and bump PR Simon Busch
2011-06-03 18:28             ` [PATCH] minimal: add weak assigned DISTRO_FEED_CONFIGS variable Koen Kooi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.