From: Jens Axboe <jaxboe@fusionio.com>
To: Steven Lang <tirea@google.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: Small cleanup patch
Date: Fri, 3 Jun 2011 21:16:15 +0200 [thread overview]
Message-ID: <4DE932FF.4040008@fusionio.com> (raw)
In-Reply-To: <BANLkTi=qFqUv00QCh5yBV9_7jCg07E4qZ3mE7uAm_tugns7dow@mail.gmail.com>
On 2011-06-03 21:14, Steven Lang wrote:
> The wrong ddir enum was being used here, which trips up compilers
> which want to strictly check enum usage.
>
> diff --git a/fio.c b/fio.c
> index 76c6ebd..34956e9 100644
> --- a/fio.c
> +++ b/fio.c
> @@ -180,7 +180,7 @@ static void set_sig_handlers(void)
> * Check if we are above the minimum rate given.
> */
> static int __check_min_rate(struct thread_data *td, struct timeval *now,
> - enum td_ddir ddir)
> + enum fio_ddir ddir)
> {
> unsigned long long bytes = 0;
> unsigned long iops = 0;
Oops, thanks and applied.
--
Jens Axboe
next prev parent reply other threads:[~2011-06-03 19:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 19:14 Small cleanup patch Steven Lang
2011-06-03 19:16 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-03-14 11:50 Jeroen Dekkers
2004-03-14 17:29 ` Yoshinori K. Okuji
2004-03-14 17:58 ` Jeroen Dekkers
2004-03-14 18:17 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE932FF.4040008@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=fio@vger.kernel.org \
--cc=tirea@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.