All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Small cleanup patch
Date: Sun, 14 Mar 2004 18:29:32 +0100	[thread overview]
Message-ID: <200403141829.32769.okuji@enbug.org> (raw)
In-Reply-To: <20040314115054.GA16146@dekkers.cx>

On Sunday 14 March 2004 12:50, Jeroen Dekkers wrote:
>       * fs/fat.c (log2): Change name to grub_log2. All callers 
changed.

This should be written like this:

        * fs/fat.c (log2): Renamed to ...
        (grub_log2): ... this.
        All callers changed.

This is the traditional in GRUB.

BTW, I think this function should be named fat_log2 rather than
grub_log2, because it's local. Or, is it better to define this globally
in somewhere else?

The other changes are very good.

Thanks,
Okuji




  reply	other threads:[~2004-03-14 17:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-14 11:50 Small cleanup patch Jeroen Dekkers
2004-03-14 17:29 ` Yoshinori K. Okuji [this message]
2004-03-14 17:58   ` Jeroen Dekkers
2004-03-14 18:17     ` Marco Gerards
  -- strict thread matches above, loose matches on Subject: below --
2011-06-03 19:14 Steven Lang
2011-06-03 19:16 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200403141829.32769.okuji@enbug.org \
    --to=okuji@enbug.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.