* [CIFS] possible memory corruption in cifs_parse_mount_options()
@ 2011-06-06 7:33 Vasily Averin
[not found] ` <4DEC82B8.7000701-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Vasily Averin @ 2011-06-06 7:33 UTC (permalink / raw)
To: linux-cifs-u79uwXL29TY76Z2rM5mHXA, Steve French
error path after mountdata check frees uninitialized mountdata_copy
Signed-off-by: Vasily Averin <vvs-3ImXcnM4P+0@public.gmane.org>
---
fs/cifs/connect.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 6d88b82..dd5e33e 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -784,7 +784,7 @@ cifs_parse_mount_options(const char *mountdata, const char
*devname,
struct smb_vol *vol)
{
char *value, *data, *end;
- char *mountdata_copy, *options;
+ char *mountdata_copy = NULL, *options;
unsigned int temp_len, i, j;
char separator[2];
short int override_uid = -1;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [CIFS] possible memory corruption in cifs_parse_mount_options()
[not found] ` <4DEC82B8.7000701-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
@ 2011-06-06 15:34 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2011-06-06 15:34 UTC (permalink / raw)
To: Vasily Averin; +Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA, Steve French
Merged, after fixing patch corruption (line wrap due to emailer?)
On Mon, Jun 6, 2011 at 2:33 AM, Vasily Averin <vvs-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> wrote:
> error path after mountdata check frees uninitialized mountdata_copy
>
> Signed-off-by: Vasily Averin <vvs-3ImXcnM4P+0@public.gmane.org>
> ---
> fs/cifs/connect.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 6d88b82..dd5e33e 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -784,7 +784,7 @@ cifs_parse_mount_options(const char *mountdata, const char
> *devname,
> struct smb_vol *vol)
> {
> char *value, *data, *end;
> - char *mountdata_copy, *options;
> + char *mountdata_copy = NULL, *options;
> unsigned int temp_len, i, j;
> char separator[2];
> short int override_uid = -1;
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-06 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-06 7:33 [CIFS] possible memory corruption in cifs_parse_mount_options() Vasily Averin
[not found] ` <4DEC82B8.7000701-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2011-06-06 15:34 ` Steve French
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.