From: Liam Girdwood <lrg@ti.com>
To: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Cc: "dp@opensource.wolfsonmicro.com" <dp@opensource.wolfsonmicro.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"tiwai@suse.de" <tiwai@suse.de>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jonathan Cameron <jic23@cam.ac.uk>
Subject: Re: [PATCH] wm8940: remove unecessary if statement
Date: Mon, 6 Jun 2011 10:51:58 +0100 [thread overview]
Message-ID: <4DECA33E.5040306@ti.com> (raw)
In-Reply-To: <4DEC9E6B.8030505@cam.ac.uk>
On 06/06/11 10:31, Jonathan Cameron wrote:
> On 06/06/11 01:47, Greg Dietsche wrote:
>> the code always returns ret regardless, so if(ret) check is unecessary.
> Good point, though please spell check your commit messages.
> unecessary -> unnecessary
>
> Also if you want to do this sort of cleanup, please also fix the
> equivalent in wm8940_resume and wm8940_add_widgets. Ack is for
> what is here, plus those if you do them.
>
> Just as an aside, there is no earthly point in cc'ing lkml for a
> simple cleanup like this. Just adds to already huge amount of noise!
>>
>> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
> Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Liam Girdwood <lrg@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: Liam Girdwood <lrg@ti.com>
To: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.de" <tiwai@suse.de>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"dp@opensource.wolfsonmicro.com" <dp@opensource.wolfsonmicro.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wm8940: remove unecessary if statement
Date: Mon, 6 Jun 2011 10:51:58 +0100 [thread overview]
Message-ID: <4DECA33E.5040306@ti.com> (raw)
In-Reply-To: <4DEC9E6B.8030505@cam.ac.uk>
On 06/06/11 10:31, Jonathan Cameron wrote:
> On 06/06/11 01:47, Greg Dietsche wrote:
>> the code always returns ret regardless, so if(ret) check is unecessary.
> Good point, though please spell check your commit messages.
> unecessary -> unnecessary
>
> Also if you want to do this sort of cleanup, please also fix the
> equivalent in wm8940_resume and wm8940_add_widgets. Ack is for
> what is here, plus those if you do them.
>
> Just as an aside, there is no earthly point in cc'ing lkml for a
> simple cleanup like this. Just adds to already huge amount of noise!
>>
>> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
> Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-06-06 9:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 0:47 [PATCH] wm8940: remove unecessary if statement Greg Dietsche
2011-06-06 9:31 ` Jonathan Cameron
2011-06-06 9:51 ` Liam Girdwood [this message]
2011-06-06 9:51 ` Liam Girdwood
2011-06-06 20:53 ` [PATCH v2] wm8940: remove unnecessary if statements Greg Dietsche
2011-06-07 8:01 ` Jonathan Cameron
2011-06-07 8:33 ` Liam Girdwood
2011-06-07 8:48 ` Mark Brown
2011-06-06 12:45 ` [PATCH] wm8940: remove unecessary if statement Greg Dietsche
2011-06-06 13:05 ` Jonathan Cameron
2011-06-06 20:58 ` Greg Dietsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DECA33E.5040306@ti.com \
--to=lrg@ti.com \
--cc=Gregory.Dietsche@cuw.edu \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.