All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki Poulose <suzuki@in.ibm.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	kexec@lists.infradead.org, lkml <linux-kernel@vger.kernel.org>,
	Simon Horman <horms@verge.net.au>,
	linux ppc dev <linuxppc-dev@lists.ozlabs.org>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [RFC][PATCH] powerpc: Use the #address-cells information to parsememory/reg
Date: Mon, 06 Jun 2011 16:59:26 +0530	[thread overview]
Message-ID: <4DECBA16.7070300@in.ibm.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6D8AD73@saturn3.aculab.com>

On 06/06/11 14:30, David Laight wrote:
>>> Changed the add_usable_mem_property() to accept FILE* fp instead of
> int fd,
>>> as most of the other users of read_memory_region_limits() deals with
> FILE*.
>>>
>>> Signed-off-by: Suzuki K. Poulose<suzuki@in.ibm.com>
>>
>> Could you please let me know your thoughts/comments about this patch ?
>
> Is the change to use 'FILE *' actually progress?
> I'd have thought that the randomly aligned read/lseek system calls
> that this allows to happen are not desirable for anything that
> isn't a true file.
I will revert the other users back to 'fd'
>
> I'd also suggest that the sizeof's should be applied to the
> actual type of the variable being read/written, not arbitrarily
> 'long' or 'int', and this probably ought to be some fixed size type.
I have used 'unsigned long'(for word sized values) or 'unsigned long long'
(for double words) just to make sure we get the right values. Is this OK ?

Thanks
Suzuki

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Suzuki Poulose <suzuki@in.ibm.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	kexec@lists.infradead.org, lkml <linux-kernel@vger.kernel.org>,
	Simon Horman <horms@verge.net.au>,
	linux ppc dev <linuxppc-dev@lists.ozlabs.org>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [RFC][PATCH] powerpc: Use the #address-cells information to parsememory/reg
Date: Mon, 06 Jun 2011 16:59:26 +0530	[thread overview]
Message-ID: <4DECBA16.7070300@in.ibm.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6D8AD73@saturn3.aculab.com>

On 06/06/11 14:30, David Laight wrote:
>>> Changed the add_usable_mem_property() to accept FILE* fp instead of
> int fd,
>>> as most of the other users of read_memory_region_limits() deals with
> FILE*.
>>>
>>> Signed-off-by: Suzuki K. Poulose<suzuki@in.ibm.com>
>>
>> Could you please let me know your thoughts/comments about this patch ?
>
> Is the change to use 'FILE *' actually progress?
> I'd have thought that the randomly aligned read/lseek system calls
> that this allows to happen are not desirable for anything that
> isn't a true file.
I will revert the other users back to 'fd'
>
> I'd also suggest that the sizeof's should be applied to the
> actual type of the variable being read/written, not arbitrarily
> 'long' or 'int', and this probably ought to be some fixed size type.
I have used 'unsigned long'(for word sized values) or 'unsigned long long'
(for double words) just to make sure we get the right values. Is this OK ?

Thanks
Suzuki

WARNING: multiple messages have this Message-ID (diff)
From: Suzuki Poulose <suzuki@in.ibm.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Simon Horman <horms@verge.net.au>,
	linux ppc dev <linuxppc-dev@lists.ozlabs.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	kexec@lists.infradead.org, lkml <linux-kernel@vger.kernel.org>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [RFC][PATCH] powerpc: Use the #address-cells information to parsememory/reg
Date: Mon, 06 Jun 2011 16:59:26 +0530	[thread overview]
Message-ID: <4DECBA16.7070300@in.ibm.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6D8AD73@saturn3.aculab.com>

On 06/06/11 14:30, David Laight wrote:
>>> Changed the add_usable_mem_property() to accept FILE* fp instead of
> int fd,
>>> as most of the other users of read_memory_region_limits() deals with
> FILE*.
>>>
>>> Signed-off-by: Suzuki K. Poulose<suzuki@in.ibm.com>
>>
>> Could you please let me know your thoughts/comments about this patch ?
>
> Is the change to use 'FILE *' actually progress?
> I'd have thought that the randomly aligned read/lseek system calls
> that this allows to happen are not desirable for anything that
> isn't a true file.
I will revert the other users back to 'fd'
>
> I'd also suggest that the sizeof's should be applied to the
> actual type of the variable being read/written, not arbitrarily
> 'long' or 'int', and this probably ought to be some fixed size type.
I have used 'unsigned long'(for word sized values) or 'unsigned long long'
(for double words) just to make sure we get the right values. Is this OK ?

Thanks
Suzuki

  reply	other threads:[~2011-06-06 11:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4DC923C4.6080707@in.ibm.com>
     [not found] ` <4DC92784.2040001@in.ibm.com>
     [not found]   ` <20110510134152.GB18537@in.ibm.com>
     [not found]     ` <4DCA285D.2080006@in.ibm.com>
2011-05-30  6:30       ` [RFC][PATCH] powerpc: Use the #address-cells information to parse memory/reg Suzuki Poulose
2011-05-30  6:30         ` Suzuki Poulose
2011-05-30  6:30         ` Suzuki Poulose
2011-06-06  7:18         ` Suzuki Poulose
2011-06-06  7:18           ` Suzuki Poulose
2011-06-06  7:18           ` Suzuki Poulose
2011-06-06  8:51           ` Sebastian Andrzej Siewior
2011-06-06  8:51             ` Sebastian Andrzej Siewior
2011-06-06  8:51             ` Sebastian Andrzej Siewior
2011-06-06 11:02             ` Suzuki Poulose
2011-06-06 11:02               ` Suzuki Poulose
2011-06-06 11:02               ` Suzuki Poulose
2011-06-06  9:00           ` [RFC][PATCH] powerpc: Use the #address-cells information to parsememory/reg David Laight
2011-06-06  9:00             ` David Laight
2011-06-06  9:00             ` David Laight
2011-06-06 11:29             ` Suzuki Poulose [this message]
2011-06-06 11:29               ` Suzuki Poulose
2011-06-06 11:29               ` Suzuki Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DECBA16.7070300@in.ibm.com \
    --to=suzuki@in.ibm.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=bigeasy@linutronix.de \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.