From: viresh.kumar@st.com (viresh kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] gpio/spear-plgpio: Add plgpio driver for SPEAr platform
Date: Tue, 7 Jun 2011 14:05:35 +0530 [thread overview]
Message-ID: <4DEDE2D7.6030100@st.com> (raw)
In-Reply-To: <20110603175020.GD15616@ponder.secretlab.ca>
On 06/03/2011 11:20 PM, Grant Likely wrote:
> On Mon, May 30, 2011 at 12:09:02PM +0530, Viresh Kumar wrote:
>> > Plgpio pads on few spear machines can be configured as gpios. This patch adds
>> > support for configuring these PLGPIOs.
>> >
>> > This was earlier posted & reviewed as part of arch/arm/plat-spear/ code.
>> >
>> > Reviewed-by: Stanley Miao <stanley.miao@windriver.com>
>> > Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
>
> This ends up being yet-another-mmio-gpio implementation. Please look
> at bgpio_init() in drivers/basic_mmio_gpio.c. This driver should be
> refactored to use that.
Ok. Will check that.
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh kumar <viresh.kumar@st.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Armando VISCONTI <armando.visconti@st.com>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Vipin KUMAR <vipin.kumar@st.com>,
Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
Deepak SIKRI <deepak.sikri@st.com>,
Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
Amit VIRDI <Amit.VIRDI@st.com>,
Pratyush ANAND <pratyush.anand@st.com>,
Bhupesh SHARMA <bhupesh.sharma@st.com>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] gpio/spear-plgpio: Add plgpio driver for SPEAr platform
Date: Tue, 7 Jun 2011 14:05:35 +0530 [thread overview]
Message-ID: <4DEDE2D7.6030100@st.com> (raw)
In-Reply-To: <20110603175020.GD15616@ponder.secretlab.ca>
On 06/03/2011 11:20 PM, Grant Likely wrote:
> On Mon, May 30, 2011 at 12:09:02PM +0530, Viresh Kumar wrote:
>> > Plgpio pads on few spear machines can be configured as gpios. This patch adds
>> > support for configuring these PLGPIOs.
>> >
>> > This was earlier posted & reviewed as part of arch/arm/plat-spear/ code.
>> >
>> > Reviewed-by: Stanley Miao <stanley.miao@windriver.com>
>> > Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
>
> This ends up being yet-another-mmio-gpio implementation. Please look
> at bgpio_init() in drivers/basic_mmio_gpio.c. This driver should be
> refactored to use that.
Ok. Will check that.
--
viresh
next prev parent reply other threads:[~2011-06-07 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 6:39 [PATCH 0/3] SPEAr: Add plgpio support Viresh Kumar
2011-05-30 6:39 ` [PATCH 1/3] gpio/spear-plgpio: Add plgpio driver for SPEAr platform Viresh Kumar
2011-05-30 6:39 ` Viresh Kumar
2011-06-03 17:50 ` Grant Likely
2011-06-03 17:50 ` Grant Likely
2011-06-07 8:35 ` viresh kumar [this message]
2011-06-07 8:35 ` viresh kumar
2011-05-30 6:39 ` [PATCH 2/3] SPEAr: Add machine support for plgpio Viresh Kumar
2011-05-30 6:39 ` [PATCH 3/3] SPEAr3xx: Update defconfig " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEDE2D7.6030100@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.