From: Jan Kiszka <jan.kiszka@siemens.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 6/7] msix: Align MSI-X constants to libpci definitions and extend them
Date: Wed, 08 Jun 2011 16:46:13 +0200 [thread overview]
Message-ID: <4DEF8B35.10901@siemens.com> (raw)
In-Reply-To: <20110608144313.GS32149@valinux.co.jp>
On 2011-06-08 16:43, Isaku Yamahata wrote:
> On Wed, Jun 08, 2011 at 12:26:44PM +0200, Jan Kiszka wrote:
>> Add PCI_MSIX_TABLE and PCI_MSIX_PBA, align other MSIX related constant
>> names to libpci style. Will be used for device assignment code in
>> qemu-kvm.
>
> So since libpci would be used by qemu, you are claiming that
> it should be switched to libpci style from Linux pci_regs.h?
No, libpci won't be used (I'm about to remove that dependency from
qemu-kvm). We are just copying its definitions, so I think we should
align to its style.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-06-08 14:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 10:26 [Qemu-devel] [PATCH 0/7] msi: Small cleanups and fixes Jan Kiszka
2011-06-08 10:26 ` [Qemu-devel] [PATCH 1/7] msi: Fix copy&paste mistake in msi_uninit Jan Kiszka
2011-06-08 10:26 ` [Qemu-devel] [PATCH 2/7] msi: Guard msi/msix_write_config with msi_present Jan Kiszka
2011-06-08 12:28 ` Gerd Hoffmann
2011-06-08 12:33 ` Jan Kiszka
2011-06-08 14:32 ` Jan Kiszka
2011-06-08 10:26 ` [Qemu-devel] [PATCH 3/7] msi: Guard msi_reset " Jan Kiszka
2011-06-08 10:26 ` [Qemu-devel] [PATCH 4/7] msi: Use msi/msix_present more consistently Jan Kiszka
2011-06-08 10:26 ` [Qemu-devel] [PATCH 5/7] ahci/intel-hda: Properly reset MSI state Jan Kiszka
2011-06-08 10:53 ` Alexander Graf
2011-06-08 10:55 ` Jan Kiszka
2011-06-08 10:26 ` [Qemu-devel] [PATCH 6/7] msix: Align MSI-X constants to libpci definitions and extend them Jan Kiszka
2011-06-08 14:43 ` Isaku Yamahata
2011-06-08 14:46 ` Jan Kiszka [this message]
2011-06-08 20:14 ` Michael S. Tsirkin
2011-06-08 10:26 ` [Qemu-devel] [PATCH 7/7] msi: Move PCI_MSI_PENDING_32/64 into pci_regs.h Jan Kiszka
2011-06-08 10:46 ` [Qemu-devel] [PATCH 8/7] ivshmem: Reset MSI-X state on device reset Jan Kiszka
2011-06-08 20:15 ` [Qemu-devel] [PATCH 0/7] msi: Small cleanups and fixes Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEF8B35.10901@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.