From: Jan Kiszka <jan.kiszka@web.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them
Date: Wed, 08 Jun 2011 22:48:10 +0200 [thread overview]
Message-ID: <4DEFE00A.5050005@web.de> (raw)
In-Reply-To: <20110608195316.GD30805@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
On 2011-06-08 21:53, Michael S. Tsirkin wrote:
> On Wed, Jun 08, 2011 at 06:21:51PM +0200, Jan Kiszka wrote:
>> Add PCI_MSIX_TABLE and PCI_MSIX_PBA, align other MSIX related constant
>> names to libpci style. Will be used for device assignment code in
>> qemu-kvm.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> Besides keeping pci_regs.h aligned with the original,
> I also think ideally pci register banging should stay
> within the pci subsystem.
>
> Could we add high-level APIs to help with that,
> instead of having kvm look at config space directly?
We could move the related static inlines from msi/msix.c to the headers
in order to test for bits etc. Still, kvm needs to interpret the config
space of the assigned device, so the abstraction will remain rather low.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2011-06-08 20:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 16:21 [Qemu-devel] [PATCH v2 0/9] msi: Small cleanups and fixes Jan Kiszka
2011-06-08 16:21 ` [Qemu-devel] [PATCH v2 1/9] msi: Fix copy&paste mistake in msi_uninit Jan Kiszka
2011-06-08 16:21 ` [Qemu-devel] [PATCH v2 2/9] msi: Guard msi/msix_write_config with msi_present Jan Kiszka
2011-06-08 16:21 ` [Qemu-devel] [PATCH v2 3/9] msi: Guard msi_reset " Jan Kiszka
2011-06-08 16:21 ` [Qemu-devel] [PATCH v2 4/9] msi: Use msi/msix_present more consistently Jan Kiszka
2011-06-08 16:21 ` [Qemu-devel] [PATCH v2 5/9] msi: Invoke msi/msix_reset from PCI core Jan Kiszka
2011-06-08 19:59 ` Michael S. Tsirkin
2011-06-08 20:47 ` Jan Kiszka
2011-06-08 16:21 ` [Qemu-devel] [PATCH v2 6/9] msi: Invoke msi/msix_write_config " Jan Kiszka
2011-06-08 16:21 ` [Qemu-devel] [PATCH v2 7/9] msi: Invoke msi/msix_uninit " Jan Kiszka
2011-06-08 16:21 ` [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them Jan Kiszka
2011-06-08 19:46 ` Michael S. Tsirkin
2011-06-08 19:53 ` Michael S. Tsirkin
2011-06-08 20:48 ` Jan Kiszka [this message]
2011-06-08 21:00 ` Michael S. Tsirkin
2011-06-08 21:02 ` Jan Kiszka
2011-06-08 21:09 ` Michael S. Tsirkin
2011-06-08 21:11 ` Jan Kiszka
2011-06-08 21:15 ` Michael S. Tsirkin
2011-06-08 16:21 ` [Qemu-devel] [PATCH v2 9/9] msi: Move PCI_MSI_PENDING_32/64 into pci_regs.h Jan Kiszka
2011-06-08 19:48 ` Michael S. Tsirkin
2011-06-08 20:44 ` Jan Kiszka
2011-06-08 20:56 ` Michael S. Tsirkin
2011-06-08 20:57 ` Jan Kiszka
2011-06-08 21:01 ` Michael S. Tsirkin
2011-06-08 21:03 ` Jan Kiszka
2011-06-08 21:14 ` Michael S. Tsirkin
2011-06-08 21:18 ` Jan Kiszka
2011-06-08 21:24 ` Jan Kiszka
2011-06-08 21:30 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEFE00A.5050005@web.de \
--to=jan.kiszka@web.de \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.