All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: Igor Grinberg <grinberg@compulab.co.il>
Cc: Tony Lindgren <tony@atomide.com>,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC
Date: Thu, 09 Jun 2011 11:23:14 +0200	[thread overview]
Message-ID: <4DF09102.9080503@ahsoftware.de> (raw)
In-Reply-To: <4DF078E4.8040903@compulab.co.il>

Hello,

Am 09.06.2011 09:40, schrieb Igor Grinberg:
> On 06/09/11 03:21, Alexander Holler wrote:

> I see. Is the new patch version somehow provides better functionality?
> You configure the gpio for output, this means that the pin is actually driven
> and not just relies on internal pullup (which can vary from chip to chip).
> I know nothing about that msecure stuff, but may be it is better to drive the pin,
> then just configuring the mux (enabling internal pullup)...

Just using the internal pullup was enough with my BeagleBoard C4.

>> Below is an updated version. The gpio_export() might be removed too.
>
> The original patch version is already in Linus' tree, so this one will not apply as it is.
> If you decide it is better then the original one, then it must be rebased.
> Otherwise, looks OK.

I'm fine with either version, so no new patch is necessary. ;)

Regards,

Alexander

WARNING: multiple messages have this Message-ID (diff)
From: holler@ahsoftware.de (Alexander Holler)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC
Date: Thu, 09 Jun 2011 11:23:14 +0200	[thread overview]
Message-ID: <4DF09102.9080503@ahsoftware.de> (raw)
In-Reply-To: <4DF078E4.8040903@compulab.co.il>

Hello,

Am 09.06.2011 09:40, schrieb Igor Grinberg:
> On 06/09/11 03:21, Alexander Holler wrote:

> I see. Is the new patch version somehow provides better functionality?
> You configure the gpio for output, this means that the pin is actually driven
> and not just relies on internal pullup (which can vary from chip to chip).
> I know nothing about that msecure stuff, but may be it is better to drive the pin,
> then just configuring the mux (enabling internal pullup)...

Just using the internal pullup was enough with my BeagleBoard C4.

>> Below is an updated version. The gpio_export() might be removed too.
>
> The original patch version is already in Linus' tree, so this one will not apply as it is.
> If you decide it is better then the original one, then it must be rebased.
> Otherwise, looks OK.

I'm fine with either version, so no new patch is necessary. ;)

Regards,

Alexander

  reply	other threads:[~2011-06-09  9:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-04 14:29 rtc-twl: catch22 in 2.6.37 and 2.6.38 when clock was never set Alexander Holler
2011-04-05 10:14 ` Alexander Holler
2011-04-05 13:40   ` [PATCH] arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC Alexander Holler
2011-04-05 13:40     ` Alexander Holler
2011-05-31 10:29     ` Tony Lindgren
2011-05-31 10:29       ` Tony Lindgren
2011-06-07  8:01       ` Alexander Holler
2011-06-07  8:01         ` Alexander Holler
2011-06-07  9:50         ` Igor Grinberg
2011-06-07  9:50           ` Igor Grinberg
2011-06-07 11:15           ` Alexander Holler
2011-06-07 11:15             ` Alexander Holler
2011-06-08 21:57             ` Igor Grinberg
2011-06-08 21:57               ` Igor Grinberg
2011-06-09  0:21               ` Alexander Holler
2011-06-09  0:21                 ` Alexander Holler
2011-06-09  7:40                 ` Igor Grinberg
2011-06-09  7:40                   ` Igor Grinberg
2011-06-09  9:23                   ` Alexander Holler [this message]
2011-06-09  9:23                     ` Alexander Holler
2011-05-31 10:28   ` rtc-twl: catch22 in 2.6.37 and 2.6.38 when clock was never set Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF09102.9080503@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=grinberg@compulab.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.