From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] at91: move a/a/c/arm926ejs/at91/clock.c -> a/a/lib/at91
Date: Thu, 09 Jun 2011 11:46:08 +0200 [thread overview]
Message-ID: <4DF09660.2040903@gmail.com> (raw)
In-Reply-To: <4DF0949A.7030503@emk-elektronik.de>
Dear Reinhard Meyer,
Am 09.06.2011 11:38, schrieb Reinhard Meyer:
> Dear Andreas Bie?mann,
>> The at91/clock.c is copied from linux kernel and has support for both
>> arm920t and arm926ejs core devices. Therefore this patch moves this
>> generic at91/clock.c to a new place at arch/arm/lib/at91 to be used from
>> at91 family devices.
>>
>> We build a new libat91-common.o to provide the required symbols to both
>> cpu types.
>>
>> Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
>> ---
>> Makefile | 3 +
>> arch/arm/cpu/arm926ejs/at91/Makefile | 1 -
>> arch/arm/cpu/arm926ejs/at91/clock.c | 215 ----------------------------------
>> arch/arm/lib/at91/Makefile | 45 +++++++
>> arch/arm/lib/at91/clock.c | 215 ++++++++++++++++++++++++++++++++++
>> 5 files changed, 263 insertions(+), 216 deletions(-)
>> delete mode 100644 arch/arm/cpu/arm926ejs/at91/clock.c
>> create mode 100644 arch/arm/lib/at91/Makefile
>> create mode 100644 arch/arm/lib/at91/clock.c
>
> Please use the "git-mv" command to move the file "clock.c".
I did it that way ... but I think there was another trick for
git-format-patch ... will have a look for that
> On any account, we should discuss about opening a subdir lib scheme first.
> Currently arch/arm/lib does not have any subdirectories.
Well as described in cover letter this was discussed before. See the
other discussion on gmane:
http://mid.gmane.org/BANLkTimn29vmAYGb5csMdCYS-xx6zD_6Zw at mail.gmail.com
I think this solution was preferred by Albert too. But I'm open for
another solution, so lets see what possibilities you have.
> I _do_ see the problems of the current ARM directory structure which makes
> the ARM core a more important criteria than SoC family especially in the
> Atmel context where the SoCs have identical peripheral blocks but can have
> different ARM cores.
correct
regards
Andreas Bie?mann
next prev parent reply other threads:[~2011-06-09 9:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 23:27 [U-Boot] [PATCH 0/2] unify hw level clock for at91 cores Andreas Bießmann
2011-06-07 23:27 ` [U-Boot] [PATCH 1/2] at91: move a/a/c/arm926ejs/at91/clock.c -> a/a/lib/at91 Andreas Bießmann
2011-06-09 9:38 ` Reinhard Meyer
2011-06-09 9:46 ` Andreas Bießmann [this message]
2011-06-09 10:23 ` Reinhard Meyer
2011-06-09 11:07 ` Andreas Bießmann
2011-06-07 23:27 ` [U-Boot] [PATCH 2/2] arm920t/at91: use new clock features from libat91-common Andreas Bießmann
2011-06-08 17:06 ` Jens Scharsig
2011-06-08 20:10 ` [U-Boot] [PATCH v2] " Andreas Bießmann
2011-06-26 17:39 ` Jens Scharsig
[not found] ` <1307563560-13358-1-git-send-email-andreas.devel@googlemail.com>
[not found] ` <4DF09096.2010201@emk-elektronik.de>
2011-06-09 9:49 ` Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF09660.2040903@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.