From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm920t/at91: use new clock features from libat91-common
Date: Thu, 09 Jun 2011 11:49:47 +0200 [thread overview]
Message-ID: <4DF0973B.9010102@gmail.com> (raw)
In-Reply-To: <4DF09096.2010201@emk-elektronik.de>
resent to right list ...
Dear Reinhard Meyer,
Am 09.06.2011 11:21, schrieb Reinhard Meyer:
> Dear Andreas Bie?mann,
>> This patch enables the new clock features from new libat91-common. This
>> is a required step to get at91rm9200_usart replaced by atmel_usart
>> driver.
>>
>> Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
>>
>> Cc: Jens Scharsig <js_at_ng@scharsoft.de>
>> Cc: Eric B?nard <eric@eukrea.com>
>
> I think this should go into NEXT unleass it unbreaks that board right now.
> You mentioned in another mail that it would be ok to be in 2011.09.
> Is that OK?
I'm fine with that. The arm920t/at91 boards do build (with minor
warnings in at91_emac and at91rm9200_usart) and work on real hardware
since 9e8df9c4db7835152996c96cc432dc6dd70bb17c
The warnings are:
- 'at91_emac.c:487:2: warning: dereferencing type-punned pointer will
break strict-aliasing rules' in at91_emac -> you know about that
... it is the same as in macb driver and will also be fixed soon.
- 'at91rm9200_usart.c:39:2: warning: #warning Please update to use C
structur SoC access !' -> at91rm9200_usart will be removed soon
Therefore I do not see any reason to remove those arm920t/at91 boards.
I will do some more testing with atmel_usart driver on atrm9200 devices
and send for review this weekend. The big removal of old-style
at91rm9200 boards can begin after that cause the deprecated
at91rm9200_usart driver needs some outdated stuff which will also be
removed in that step.
Besides that, I found out cpu.c (in that commit) is missing a GPL header
and copyright notice. So please do not add this version.
regards
Andreas Bie?mann
prev parent reply other threads:[~2011-06-09 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 23:27 [U-Boot] [PATCH 0/2] unify hw level clock for at91 cores Andreas Bießmann
2011-06-07 23:27 ` [U-Boot] [PATCH 1/2] at91: move a/a/c/arm926ejs/at91/clock.c -> a/a/lib/at91 Andreas Bießmann
2011-06-09 9:38 ` Reinhard Meyer
2011-06-09 9:46 ` Andreas Bießmann
2011-06-09 10:23 ` Reinhard Meyer
2011-06-09 11:07 ` Andreas Bießmann
2011-06-07 23:27 ` [U-Boot] [PATCH 2/2] arm920t/at91: use new clock features from libat91-common Andreas Bießmann
2011-06-08 17:06 ` Jens Scharsig
2011-06-08 20:10 ` [U-Boot] [PATCH v2] " Andreas Bießmann
2011-06-26 17:39 ` Jens Scharsig
[not found] ` <1307563560-13358-1-git-send-email-andreas.devel@googlemail.com>
[not found] ` <4DF09096.2010201@emk-elektronik.de>
2011-06-09 9:49 ` Andreas Bießmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF0973B.9010102@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.